From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C499C7619A for ; Tue, 11 Apr 2023 23:04:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 998B4900002; Tue, 11 Apr 2023 19:04:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 949456B0075; Tue, 11 Apr 2023 19:04:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E92E900002; Tue, 11 Apr 2023 19:04:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6F8A06B0074 for ; Tue, 11 Apr 2023 19:04:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 35708A0B87 for ; Tue, 11 Apr 2023 23:04:25 +0000 (UTC) X-FDA: 80670640890.23.57E346B Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf02.hostedemail.com (Postfix) with ESMTP id 04AB78001A for ; Tue, 11 Apr 2023 23:04:22 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b="l/tefIBw"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=QbH0rvoG; dmarc=none; spf=pass (imf02.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681254263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gsbn2oyKgih4x2C06Ah8fFpl2xaJq27kMcEbABkhWFY=; b=ZE+29i8lwO5sUj5F+G0+OmO1roAwdVM2NJoe0dIdR3ZWHTYVFeIeM2yF5TVgJtqL1gBYfV UZ1nhMDFzqjnlUtVSs3Ni03gLz6MY3hWu0MOqpq9L30reTEg0yV5WdFGQ7Z2n54sFccIQT PuzPbucf+KTDSPuRag9XhCoVzU7MTVk= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b="l/tefIBw"; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=QbH0rvoG; dmarc=none; spf=pass (imf02.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681254263; a=rsa-sha256; cv=none; b=N8Ga0MPHKh7zGSeRAp738nWDDDfBijAHHq77dofpfCbEQ61bekNI+xCRPZKnLP3kjV0B6b F6t38Ihq8Hz4k75hJbmozgXmfM1LADeGoka+NkH12VNetKVE/nRL5BMkD4uv4JI/7L2sfJ OKOGTTH4I3IMRKX8+fylb2KaANOgbaI= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C9F895C018A; Tue, 11 Apr 2023 19:04:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 11 Apr 2023 19:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681254260; x=1681340660; bh=gs bn2oyKgih4x2C06Ah8fFpl2xaJq27kMcEbABkhWFY=; b=l/tefIBwRsVvQpaogC J7B7EnYcAR08db2luxaD81KGRmZrorH9dEFLyi8DKxAgP02/4PbU+IQnY9jJ4joq v9uO/V7zHURvxFaXGm1m9fIyCKJioumsRoUOi1gRlih5QSCOmz1tH+RD47HQGQwu pTal7H4domS1joO+0DvM3DJp0qzbQBNA7fbhErypCIVPvF5AnZoBqc5OLTma03GN 4802BP2nVEnRaDuRFh5jOyGOCnVXg+Vz/vv3KcWwQPNVsWePRzLegOuTbTmUFrL8 WMfxgGVqxCL6375N9L1dynhkOJ6lGAx+AzM56kSqwZggHcTv5aUgqpKZIgejjemS Oxcw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681254260; x=1681340660; bh=gsbn2oyKgih4x 2C06Ah8fFpl2xaJq27kMcEbABkhWFY=; b=QbH0rvoGb1hFhDc0ra+rQxrOrh1rv KZKjFMrmtl8JEKBghEUqOVY+sSWD67vupdLAU5wi0VFcXZ2AkUrBe9R0d+pjGwyA U9+ZAdcat/iojatXAk7BONaf+N74Kv9H4CUvbHVcIv6YtDN6nbj3JAQJkDP4Kl3D M+VXL8p5Sd58+Leo1uxObdu3U1FZ43Z84bXnSvHKS/+SN1tumg3cEDMHO7g4vqVD lUR6pCUOMYArz46H9Ub9bE4hoX9D0NAE53aUH90lykKxyr7Z9HKdrstihEoxhRxR QuhCZTX9ZNv2Hq17KBFqdSwkhi3jD1PEVb0rBRUKA7E2p6LFalN6+xOEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekhedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefuthgvfhgrnhcutfhovghstghhuceoshhhrhesuggvvhhk vghrnhgvlhdrihhoqeenucggtffrrghtthgvrhhnpeevlefggffhheduiedtheejveehtd fhtedvhfeludetvdegieekgeeggfdugeeutdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Apr 2023 19:04:18 -0400 (EDT) References: <20230406165339.1017597-1-shr@devkernel.io> <20230406165339.1017597-2-shr@devkernel.io> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Matthew Wilcox Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, Bagas Sanjaya Subject: Re: [PATCH v5 1/3] mm: add new api to enable ksm per process Date: Tue, 11 Apr 2023 16:03:57 -0700 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 04AB78001A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: k5tbqnxj1wa4ma6i59qs97ub75n6e897 X-HE-Tag: 1681254262-369329 X-HE-Meta: U2FsdGVkX1/HV9bFImMhq7pXdYLtZiFviRs5j7a3ySl5Uq7Y/2z8wY9Lq33xx5fKCt+6j4j2l3P30Ucwyl234escwFKMZum4AMPY2FVsxrTbpf+GNmvIHFmPrVWJl2NJDcLUH2yTrcT54fzQU71QqO7N38Xe/EPHwas9Z5z9NQwm9yrhKgk6XopHLiXxX8nxoqhQoZuJv3Y+2uyqA56aKewX+VH4vs44LduWenYOD45oCnZancGDDy9cDyDIZPrhIGE/8NTEEYkorzIOBVW7HelTTOtzmobmakfSgj9kikWJ/l1K2UMnm8WuXGcAVdTHKrXyRk/FVilOqS0RLeU60LoTnvwK5Ra3ObFndUahsiuMAukfKfxP3Joh1IYm+KWnZ0OE+DpVfXEJe5MMTBZmUPmySM4n37B0k2Dcv+8ZHgW4KbSjC83pyNnrnPmykiGZ4V5bisSBkIinSK45YIquoT2WOTjUqvEioZjvvkB+oMMq1qsig4Txs17GOSVRuN7bzQvTwFtjo4ZBIr3L0hyCwC6IV/XpzX+f3KUgw63LWbys5xzXMc1og1L35Cj+fpGg2ugEc8vx3ONX/v9iLJAJeatOupyPzskZuXNtHBD3wuiO3IojpQBg53qcNzBb4opjdrGLK3rUsnJl6Iy5WFooRLIsSV7z9RGvnJaC+Ep9xMNR6G+3xAARpaLgh/ATMphMsxFdD+5HwfSd5auQj4cLIjzDTkFehNosfcadhN3fEP1orXr936mtt0h9HAytN5DvlE8ciYTjgKxnrs00yBm21rsL1X332ewbkdRG9+jfQF6paoQ3IUpaCipnm+qFiEDVKkGbOay6arCCckRik1lT7YWG7u4Z8YgJRcQUKFVzkhohoSk8VHp3IT7V+rdBg4TsEnn6qqx7qXLOlgYRm8X2mpYzSmcBgnjuQMX8vpPp/SkKp0RYZ8dQtzGWcePhqpDv7iatSOY0UoUnb19C2Ut zUSwIEcV vTb3pwtzu4dJnQHSR9fSyRshvmaxFRewORIUl5/oHwQn338HN6JTicaJpYsIZMVRd3+v1j6Tb1KjHjMXMZ9Wnt34W/oFwU/4CZ/1ummQMi9qN2o6jkJoAPJAofIt5uZ78G2DAh43pQCFVgPipALHuok3wlX3OFix239pl6jhL2rhvgzA+Jd4/cFvbw9JmMepwioDY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > On Thu, Apr 06, 2023 at 09:53:37AM -0700, Stefan Roesch wrote: >> + case PR_SET_MEMORY_MERGE: >> + if (mmap_write_lock_killable(me->mm)) >> + return -EINTR; >> + >> + if (arg2) { >> + int err = ksm_add_mm(me->mm); >> + if (err) >> + return err; > > You'll return to userspace with the mutex held, no? > Thanks for catching this, I'll fix it in the next version.