From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E59F0C77B7A for ; Mon, 17 Apr 2023 16:43:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E35D6B0072; Mon, 17 Apr 2023 12:43:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 593B66B0074; Mon, 17 Apr 2023 12:43:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 482348E0002; Mon, 17 Apr 2023 12:43:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 38B656B0072 for ; Mon, 17 Apr 2023 12:43:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F16681C64E3 for ; Mon, 17 Apr 2023 16:43:08 +0000 (UTC) X-FDA: 80691452856.27.A28E594 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf24.hostedemail.com (Postfix) with ESMTP id F090B180008 for ; Mon, 17 Apr 2023 16:43:06 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=b+Mrrqmk; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=OmXJCtZ0; spf=pass (imf24.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.28 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681749787; a=rsa-sha256; cv=none; b=For0qGW8l/MFnxSQptU74+w0LO0lSgX5QvETFzhFBOREHu+HdEozxgt/a27wrFn8AVh7ve VV3cdeiLTXKv2yB0W5DElfNvT5uemuNQ8bjgmNQaj3JoHcS1Y28csqSxL9u98qziCEDgfD 1IFkuwk6psl7LNNtYz6VaVC5J+48agA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=b+Mrrqmk; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=OmXJCtZ0; spf=pass (imf24.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.28 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681749787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YDe3y1T8NWWsjl/y28nmrnwl6G1y0u8s1lFy/i0ih80=; b=iU/mIYVvU1jzewrAuhFPl4gBXUttyBYbBlSPzjFnvNx1ye/bxKldMrbW7XVvISn2kB4SpB 5JpH1sKg3bus/5uZhQU63jfOARXx+AwGKbbaHPv5yjea6REPorpv/nP67y/Wvd5akHGf3V EDOcg5oltpHv01xVDEs/GkiBOhkNatw= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 49C1D5C007C; Mon, 17 Apr 2023 12:43:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 17 Apr 2023 12:43:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1681749786; x=1681836186; bh=YD e3y1T8NWWsjl/y28nmrnwl6G1y0u8s1lFy/i0ih80=; b=b+MrrqmkqnhWnXyJzS +Hug34CJDBjbLk5mJEQi4cnFU/leVEaDstO0jkZZv3DZGS+QaNMEacn1E5hS985x Rq2B/cmHgqjyF4t7EUcQ4IYgKTn9Km0262ErSAjFO2o/xjf/VhWNKnJjRenYuXBN 0US8Hr6b1oGQTDDh2PHEGXr9MntmpuCfdqOVQHadrOP3U48KHXHIS3eQ9rQe4HFb wPN9xBMC7Ow5GuwKFEfSyOjTRoE7QXT61XkipHiu7kQe0ku/JH3GTs6Z9ppHkqn2 xGqVINFBYcGV9EicZAhEHzSjx3ny7545Okc25v4sGXa/YBP40GxWpMYV1+CBf/Sq hyRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681749786; x=1681836186; bh=YDe3y1T8NWWsj l/y28nmrnwl6G1y0u8s1lFy/i0ih80=; b=OmXJCtZ0e8x+NUyE3P6D2U2F1NBIO dzCNJxBz85VvpX8WrqJOEZ1yp1D65nsJkLziTq8BrS4FmYvZgbxQ2G7R27EAWv21 0bx/yjSHqzRK8w8ZWaVp0WXL7frKJrHxZ2/wutn09xDw25NAvtTjmGeNpAG4pukv ipewXi0x7D6siNWcJXqVqOCdICB0mjdMktmqEp4mXCKz2gY5quwFRpxnW+SP6oFp eGxJ/kwLoB7YWA2CedgOceSWdbTP/bJwfDKYhnhXKGEptW/AxGPjYCG00JDU8l85 7UwsDoKqsDbsCopDPLy3xXsB6RxhyAJLqVBFaLEjZvkmzTedafLd6ojPw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeliedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdu geeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Apr 2023 12:43:04 -0400 (EDT) References: <20230415225913.3206647-1-shr@devkernel.io> <20230415225913.3206647-4-shr@devkernel.io> <355f42d1-4354-376d-ab27-7e55d06e64a6@redhat.com> <954d6b1f-5b4d-48e5-02fe-646b3e79f6e5@redhat.com> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: David Hildenbrand Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya Subject: Re: [PATCH v8 3/3] selftests/mm: add new selftests for KSM Date: Mon, 17 Apr 2023 09:42:39 -0700 In-reply-to: <954d6b1f-5b4d-48e5-02fe-646b3e79f6e5@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Queue-Id: F090B180008 X-Rspamd-Server: rspam01 X-Stat-Signature: gwz1a6gn5rm58ffbiu4s4y1x41zzosj8 X-HE-Tag: 1681749786-384012 X-HE-Meta: U2FsdGVkX19+n935RG/hVz3o5T9BKxDNjtvqjrzBoOYM9ZF2jfQz6gq+wYfbXxoW6ICbnFOrVaw/k4sLBYD5z+7p2Gq1Q6JDcokXosr6VSmIemF4CZefsuzIn2ZRbkKiyKO9RJRiWqUBOhm/4zZi3pPLEK6sDgpcX+AmIdjPNK7IihngP911HqOxslA16O3po/fik4euQ47DM3P41W3es3mCgpbvpEpvd0tQxP6nGjF0V27qfSubhLlm2gaVUCyxez4iGGhAkKNCyMbaUeRlTXLUIVMsR0e6n0clJijF++uR1feaKA9+kzGAs0P8ph4qFlMMzArBXfvE+AY4eB4I2TFrtn/yzC3w16LsWHQm7OsxEWd/Q0Msq4+ZB+mg9HjGplJqvZcfFvkdLAD2yA1tQZPK6OXZ9dwxUcR9erUrJgJA8WXYRgCfmPt2WHpsIRcV9Jb3WmZLZB0rp5Ht5s8cph5WXnXiWgx8eYg7f0B7ZTbMC7T+seKC/D2bVm9h+lxLBb65ApUZCMoOrCdDocEj0xYj9iPJlSmbM8UWCgLuM2I0hRDOEN0FxaJTDZ5dT2om7FGeF6OwJY38X0ocSMyhVDsP453ryjKm3yBkOKkn7kgIn03i/OCmY+3wiOKSgr28xhS2FR8FK3LWdo8OicG3IeN3WBdHaijuFZviEcjlrp8zzbnqbsNWqLyUljDf6VTKQYkt+YBOHaVuZ7Z3BhH1KO3ylANiflQVAfbtBdvpl7PV8opj7bapcIvZmd0LAsX1pjrSyw2CSYj3kIT31g4s5YERYj/yoqL9As17savGniCx/n2UBfRi7dh/D2ITHhpN/qqjnm/jZ55YKmwMv1UeeEc6mVPSXOGn+xtypymWMrTd0m3T98R6Tnin5OF+Kd3v8MXhDGOKgQoVLcFGDAvFbvmWkd81C32yXlaZJnOZwmWWB3UFDl6sk56KyCApLiE2pCJQsdK9AJ7rE7KaPyB yJ0Sdjtt lpjUkccU0BDPjz5qP3XAC5LeFogjerjKZmJJ/+gj/5KSU4RKxmCV4qcxMRqdxZKdwbV8H/mpHOczbTo1DFuyIcsRkTr8Rk+3ai9sEOOOwl5ChFq1Rh+ZNrEo6s/xtggjxPts3x5MXPmepPTjX+OlqB3mrsbobFdzg8IQ7A+SuUIsti71TB1uAfO7mX7mEfHxb/S29 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > On 17.04.23 16:35, David Hildenbrand wrote: >>> +/* Verify that KSM can be enabled / queried with prctl. */ >>> +static void test_prctl(void) >>> +{ >>> + int ret; >>> + >>> + ksft_print_msg("[RUN] %s\n", __func__); >>> + >>> + ret = prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); >>> + if (ret < 0 && errno == EINVAL) { >>> + ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n"); >>> + return; >>> + } else if (ret) { >>> + ksft_test_result_fail("PR_SET_MEMORY_MERGE=1 failed\n"); >>> + } >> Just realized we're missing a "return;" in case of the failure here. >> > > > And we should probably fix that as well: > > ERROR: do not initialise globals to 0 > #235: FILE: tools/testing/selftests/mm/ksm_tests.c:57: > +int debug = 0; > > total: 1 errors, 0 warnings, 512 lines checked I'll fix it in the next version.'