From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDDCBD1039E for ; Sun, 27 Oct 2024 06:55:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6EA86B0082; Sun, 27 Oct 2024 02:55:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1ED16B0085; Sun, 27 Oct 2024 02:55:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE5F76B0088; Sun, 27 Oct 2024 02:55:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9F7BF6B0082 for ; Sun, 27 Oct 2024 02:55:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B24A3121A4F for ; Sun, 27 Oct 2024 06:55:06 +0000 (UTC) X-FDA: 82718470338.26.4843F7D Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf02.hostedemail.com (Postfix) with ESMTP id AAD1580002 for ; Sun, 27 Oct 2024 06:54:42 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ALDNT+zZ; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730011967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vw3H4pusaQ5DOw6+PyiDapAmvqYWQPaCzTwI8aIt2NU=; b=hk8iBppnq549l+prlQn1yIx3Ufmadfsd1aE00KXsbNWIUp8OUYcsTFiyKZ16SuT+H3IzYS PJAG/AU/Ng1YbiOMhbQW4DBVZPxwOdxCJXzbxVSFzMMZqX2MZLj58M+aIOzEIME5HO3lbB bEb+I+YEiWDbHC5nPunisqHceE3Gkv0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730011967; a=rsa-sha256; cv=none; b=uXTPT/98ucZUGWk3Os/Krrwwfd6HmRx7VJesLncoIwqXr74czmN7cErWzoMN5FCLAE48VW mg6GLOk/+7yBJ38FJ+27XOyAwCRE5EeqFNTsw/amEEXuq9OBYHz8jXYM3A6KwqsT4unSf3 otLmbcS8YZjXGniW7Ns52AkNHcxFGXg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ALDNT+zZ; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Sat, 26 Oct 2024 23:55:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730012121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vw3H4pusaQ5DOw6+PyiDapAmvqYWQPaCzTwI8aIt2NU=; b=ALDNT+zZybCxXr4AleNgQbZljfuohJuCq+3RER0kWkH/SPGlOt7CPrHJuxGCKtE7d2TPxG CgtC8/kqWweHQ52UgPI2tYw2YjeZ9KRJPmLfl4lYDPv66XHUm0C+okPAUOEK5tMyMEU3QW waIL++MgR1WPdZkDH0S1OuK8p1BOv1o= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Hugh Dickins , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team , Yu Zhao Subject: Re: [PATCH v2] memcg: workingset: remove folio_memcg_rcu usage Message-ID: References: <20241026163707.2479526-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241026163707.2479526-1-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AAD1580002 X-Stat-Signature: rw67i3x9d5j8ba9sit1t1bskbyoqxo3g X-HE-Tag: 1730012082-506139 X-HE-Meta: U2FsdGVkX1+M8l0chQidGm915cXRfy/Lt0SZiHIC6Kgolydhu6d6mBbvaNy9t7/gDw/S66q5atVrhh/Noe5OiXlLfSDyNHzEUqDbgpIwej57KcZHaSxP2Br+AVJ9ao39c0GPqzqlru23M4D10BpAFv/1iUF7v1bzbAvOIHR4n/MFDNKoHJl/I+VqF9u68qqRGNagjHD6TRr5ikTjfV7VhdIUWd7DlL0pAvn8mzXAGrvd5ayV2a6NGGEGx6rWgeCgD7jgU9JFyPx2kcBFWeXfTKUFURbE1AdC/p1f6XCvyNje+ZGu4i5ieTO1dCx8MeuuWgEsL05fAMQ0dbLr6b/bgAfsKy0aQyC5vyvVHQ/ksqAOGbbYqLyd1JB5q5qTpG6OBA3mxDcZox3i0YKw28/ToxDTW356j4pjdwPQ5j2rbiRQMI7aFRbg+REr287/l8t0oS0zAZgSMR08o9uTLPdm8dSu0Z0bAKC1wN/udL7HNTLJIIiAICU1byo1FaYq1E4hK2TjG/HCa5huQVL07M0ELmqBmgdTy1wL2up1NrkCmbOPR+vCRZbwyGirnBJ95DBWv04degfORZQ/T5xYK9Hz89ikwRSx6Qi8H0g4EEZUTi+Lr6EmrY9mVAX8l20P3ib3qN5KrbQHGtA4QM/gCvgjqDyT0iIk5qj0Y7g8Bvwhi1xWGh0/t4Yr/YJLx6iVbfWqSa8fFxZKl8iQkg6pJiG0CtM52uGsrlEer1D3X65CV+rnAWpJoX2gbAk34oqeKV2J4plXmGeUswNSK1693AdhJI1VgyDZEixhc5C0F8Y6id1bdtnK3j8UpKYm29mu3OYJvSGauBAkEOXwtzjm9K234yFn3Bg8d6GXi8XpzekpWNWBGu4tOBIiAV09TQYtjGBT7Yz2Suq88JMLYvLokXSEac/dBE+I8y7kLF5HhH1IiL7tKpojMvj6lm4qQ190OWnkBbKF0yDqHRvSn3+oZTI FX56Jane oAyWMXAJ7hUi1Anut/un4C5u19IxrSF/QvuSGeBxowfP9pGXspSl2JpF2N0ilruff5TZKQzwbFOb6yK33OZ14bU+1sS0+LK4wSy6D4g3wqSDDivQHsdBaYAgogKBmdAcdGfY8005vupiPDheOW8vZQDOZLxnziBNPyU74mXuysRuSZb8bt3NTRvVo4iLX1EGmB+ntCRshlBKI1CmdpZ74w2pSMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Oct 26, 2024 at 09:37:07AM GMT, Shakeel Butt wrote: > The function workingset_activation() is called from > folio_mark_accessed() with the guarantee that the given folio can not be > freed under us in workingset_activation(). In addition, the association > of the folio and its memcg can not be broken here because charge > migration is no more. There is no need to use folio_memcg_rcu. Simply > use folio_memcg_charged() because that is what this function cares > about. > > Signed-off-by: Shakeel Butt > Suggested-by: Yu Zhao > --- > Andrew, please put this patch after charge migration deprecation series. > > Changes since v1: > - Fix for mem_cgroup_disabled(). (Yu Zhao) > It seems like folio_memcg_charged() is not defined for CONFIG_MEMCG=n config option. The following stub should fix the build for such config. diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 89a1e9f10e1b..5502aa8e138e 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1055,6 +1055,11 @@ static inline struct mem_cgroup *folio_memcg(struct folio *folio) return NULL; } +static inline bool folio_memcg_charged(struct folio *folio) +{ + return false; +} + static inline struct mem_cgroup *folio_memcg_check(struct folio *folio) { return NULL;