From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D19EEE269 for ; Thu, 12 Sep 2024 21:28:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B95A6B0083; Thu, 12 Sep 2024 17:28:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 068726B0088; Thu, 12 Sep 2024 17:28:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4AD76B0089; Thu, 12 Sep 2024 17:28:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C72166B0083 for ; Thu, 12 Sep 2024 17:28:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39E90C0829 for ; Thu, 12 Sep 2024 21:28:17 +0000 (UTC) X-FDA: 82557374634.17.72ED175 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf17.hostedemail.com (Postfix) with ESMTP id 6FF8540005 for ; Thu, 12 Sep 2024 21:28:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=GLmDmZnP; spf=pass (imf17.hostedemail.com: domain of justinstitt@google.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726176389; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EVBoJCNLRR8X5TrQ/I9maABRhanYWycmzMG9wsr9TFk=; b=UUPZGpWx6eFw5rEwj90XbzhhwqWazZWDyh+09z+Vja4yuWXMBS4nqepa9vCqV8pV4cqmfT aBBNzzmoJ0B0GxSLV4rp5EbZMOq2PKI9Ghqd4G3+Yde59wDcCkLTG84HFWDu56+VXbbGNu cdqaULFREjNCETJSi8aoHm/EiIvIIqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726176389; a=rsa-sha256; cv=none; b=VEg7pteKZrjodlZAfJP+euFBZ6Bh4fHXiHIEQ7OWi4DKE5pywYvKsRtn0Ffleas0ESIJMe t8y/4LnGv0McUoBgMDiEGpRHDtMUx9a7i2Nl1La0GJ5sBfbisSRaFoSreMp9ZugQPR1cM5 ZZETe0wTPHxEVmNTAgc3jiB31E06wA0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=GLmDmZnP; spf=pass (imf17.hostedemail.com: domain of justinstitt@google.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3e033e66a31so796441b6e.0 for ; Thu, 12 Sep 2024 14:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726176493; x=1726781293; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EVBoJCNLRR8X5TrQ/I9maABRhanYWycmzMG9wsr9TFk=; b=GLmDmZnPXm7rBa20d2ezdQQP2+SrNWMlW2wPLntTghmmSuwelzXNkIPhDmQyPnbnQr lXD67A43THf2C7WgdPUDxNu0OaeJ3KfJW8mj78L7pvXPk/pROjs7RZilZ/B9fCgvAbjb Ys0lp0oLNwwSZ99700l0WYzDeFT27wEavBbkHy3K4YuEwnYLiRGuYpDlpLAikAd7Iy/S lr23IEF2OxwQApgFY5A2fCiyslm5tIiCDRlzCUwfdEgCVfj2RR7RZtF3Wy9Smulxl61A U0mw64YsthwERxGAPj+TJcE3aG6y3EWRfn1O7Y56mapvrOKAurD7udzeKTladLEbFq32 Zh6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726176493; x=1726781293; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EVBoJCNLRR8X5TrQ/I9maABRhanYWycmzMG9wsr9TFk=; b=KYUunE5YfgjOyKGtIPxPypPwDX0GL7UMxJpU4OAWUkArfoLCCPLSTLi+tUMYzRAk+U TUHinmIcEDwtWMy/+m0DWlszMw1Lpgik65aeYosfZT6ZI5AQ0sW3Q4v/IvmtNi1dg817 yit0NKE3UiFHSEuhJd3EMxVFjoMleTh9+M5rH7VLVA2DwPII/sEEk2DLvOqf9zSRSDH7 nLyemkBSUskEBHz8xABf8u3d5Sg+zX/kxrgnMf2o4W1NwEm7WlRXBV50C/mDnDjeFws9 oca4Nj3Tv9EZ1+KvJNDfWK91K/QallkbmGb2Vx4xMBf2SeKHVp/TbP2nCmb4TBZf65rq RboQ== X-Forwarded-Encrypted: i=1; AJvYcCWdA2ULEE1i/ro2SLByfBhVZoszafnjmAJNmARAOaLCABiE7Pcm9eNfmHSHDV2PMvDpU2MZx0uymQ==@kvack.org X-Gm-Message-State: AOJu0YzKSwW10C8XaB22FV+SD9G3Y532qGt8it6cFO6fJiYoPRczzRIl WaJZqmY086cKMTo7OWnO9q84Est2rY7N9hFuqg0Fqqwg3GUFv4PYuOkaiiMb2Q== X-Google-Smtp-Source: AGHT+IE+PplQfr1wmi1rPq6cfJUOVee5axfQ/fpUSWcQDWuQhtkqeGRwdyj65KxYO5B4v8hXLcmStg== X-Received: by 2002:a05:6808:10c1:b0:3e0:6809:ab18 with SMTP id 5614622812f47-3e071a8f33emr2960910b6e.13.1726176493194; Thu, 12 Sep 2024 14:28:13 -0700 (PDT) Received: from google.com (30.64.135.34.bc.googleusercontent.com. [34.135.64.30]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3e039c05857sm2544147b6e.45.2024.09.12.14.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 14:28:12 -0700 (PDT) Date: Thu, 12 Sep 2024 14:28:10 -0700 From: Justin Stitt To: Yafang Shao Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, alx@kernel.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Subject: Re: [PATCH v8 8/8] drm: Replace strcpy() with strscpy() Message-ID: References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-9-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828030321.20688-9-laoar.shao@gmail.com> X-Rspamd-Queue-Id: 6FF8540005 X-Stat-Signature: 7yx87osyfjotmmdiz6nog5a8zskx3ak3 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1726176494-247141 X-HE-Meta: U2FsdGVkX19eo74k3bJEFRn4u4aOOzW/4WgDouBt9Uj0+p77stMv8ZllZSB+EjvNuYiSK0Sts9s7ltEWVuYEyLOypOxFB4GJ9LpxB2nb2Wsc8kY/0B67joYJO+MchnMoMHuWl68i2TYX0dsyPAIbc91/MTVPriMYlDma0p5tEvd3UFF1gl0ShRTwmtjjg6INpETVteJoQvgCXEQXs+i469/tjNsiE01C3/Yp4TmL9Wp67OxcItLuk6nhYj5psYMotBdQ6CaqAYOmz0B9V77wAB8IS5TJmAx6bVFM/sKbZf774lVVKsE6/3yReCp61mH1Srkvft7FnGTUGgUScbb6ZD/FUldrYLSLVYQ9BIlMpDpjLj4FCKSYqIMf9dGYhZlfFlrWXDJoDFSjmCYhpgf4uR/Mx28JN0y9AEZBNE7Eiku5hL9+Walx8eC2oHSsqBWHnF8Ik2bkzZlClv/VXqXGAMkf78q0glFhdCmBTODtxsGBlQNMQd96QFDMPzppFnYA4/GYPQqAZhTyT2067pvjVTu69oWtBnmRTHLs0EPirZR56b6BAj+OpZw2ad6ohdCUHMyerFE+XB5l2IY/HW7fidEvMLuEkCg1sfFZqNvKt/ZqtKQxWWFSTGquHjyk6T9/aa6CzKxuzS0FAplIoBlJ/bkh3KkjXpTnbN5PfGTA+7+PijSI0Cy5bGsb6j0Qf4aUj3aGMKh3eyDke0nKLxGvo067LSbTPOEbPk61tofZSaCdFhXqBf0C31rGIY62p92DCkx/UNe29ZrhXiMXcaA9ycx4k3N7pVDRPv21mIg5YDIzSrMK5yOLCENfPlEOFihfcILaRV/2On4/oA1clA1LE4zu6c5kSh5EXpGHmcfdxqd5qDWP8uVagNLAtbYJCaWLk7GwccA1cPDYe7glH+hfhCLhT5CPSIQE3pinvtJ71hcL11JzTM4EtVv5vWbmriot9LgSwnYKSWxS/P1SHPS AdT2m14B H28dobsvw/km2weIrjAmI0j9w/4HtZ4g2Ti5LJPKglMoB2OHDpBc/z//PFPl12GX7SGhVMTXx0taPr0xV2L+otf/iSD0BuzwtJMwE5vLu4tmrldZ5mlqOv9ze8pnU9WqIciJ1Oy1L9zFhfBEYPUmYFvHqoFnKH+mgFQEAYYAb99t+MwXZQEbKrGvs2Qyi27ABhwUCTpobplo+bme3SWWRu46lzNyjlprctgZlQLHAhmy1c2CedmihK4uS9eAjykPAqGXCiG578LGCLCGggyvDoCoAPlpl8AoUQZferBE/0/DhNDpoA1GUN0TDo7vadIcj6hVCphfQJnvl9c2lsPprBske3ObzExJJLLd8luPsDSo9BuZapGE2XKNu8rnAk5uHzecsqo8RQ/QrbxG0ITxKIHYz8BuTK8yvZSo5FvcQkWCH7gOj/4lOxyPe1SeRnpd5h/af8bhTaiUEgX9OqLIXMgIR84g/jhqwD68IMoUbXLRBruogF9xhBoSOu2SbIBbHxGUBwVqU3X8BXrs4Hd/A23daEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Wed, Aug 28, 2024 at 11:03:21AM GMT, Yafang Shao wrote: > To prevent erros from occurring when the src string is longer than the > dst string in strcpy(), we should use strscpy() instead. This > approach also facilitates future extensions to the task comm. > > Signed-off-by: Yafang Shao > Acked-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > --- > drivers/gpu/drm/drm_framebuffer.c | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c > index 888aadb6a4ac..2d6993539474 100644 > --- a/drivers/gpu/drm/drm_framebuffer.c > +++ b/drivers/gpu/drm/drm_framebuffer.c > @@ -868,7 +868,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, > INIT_LIST_HEAD(&fb->filp_head); > > fb->funcs = funcs; > - strcpy(fb->comm, current->comm); > + strscpy(fb->comm, current->comm); > > ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB, > false, drm_framebuffer_free); > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c There are other strcpy() in this file but it seems all control paths to the copies themselves stem from string literals, so it is probably fine not to also change those ones. But, if a v9 is required and you're feeling up to it, we should probably replace them too, as per [1]. > index 96c6cafd5b9e..afa9dae39378 100644 > --- a/drivers/gpu/drm/i915/i915_gpu_error.c > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c > @@ -1412,7 +1412,7 @@ static bool record_context(struct i915_gem_context_coredump *e, > rcu_read_lock(); > task = pid_task(ctx->pid, PIDTYPE_PID); > if (task) { > - strcpy(e->comm, task->comm); > + strscpy(e->comm, task->comm); > e->pid = task->pid; > } > rcu_read_unlock(); > -- > 2.43.5 > > Reviewed-by: Justin Stitt [1]: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy Thanks Justin