From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EC8C3601E for ; Thu, 10 Apr 2025 17:45:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F0996B00B5; Thu, 10 Apr 2025 13:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67B6C6B00BB; Thu, 10 Apr 2025 13:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A926B00B9; Thu, 10 Apr 2025 13:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26FF46B00B4 for ; Thu, 10 Apr 2025 13:45:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CC3B91A1246 for ; Thu, 10 Apr 2025 17:45:32 +0000 (UTC) X-FDA: 83318861304.06.2C0D3FC Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf10.hostedemail.com (Postfix) with ESMTP id BF109C0013 for ; Thu, 10 Apr 2025 17:45:30 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DZ5wBMh+; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744307131; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WvTNL6Tsz/oYgydOCDMb/zQ2Ru8zownM+E92WVITLxA=; b=BtdwpoSC99tH9sqnMkW5tG3IqptrgFqWtaINAdplG7E7txqC0JL4IGCo6Lqpgs/noGbHWw OfIgxYw1mHjfoqoMbNZr8d/kBPsnYNDpMESq0jCpOVbXL85Zi+29egBiGGYXobmZFx+gV7 PHEC3rN/f6QJBBpl4UWinp7iKiCBWpM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744307131; a=rsa-sha256; cv=none; b=SCjQMH46gmkNk0AIWlNfZt3AcMUn5aFBKew4zEhQkYhjb4UHzYpXj0j0QdP54zWXZt4hx8 uF/vaJieaJzeJeRzJVmYWtjlf6eD6k/qyrjTSmMTccBxwc/X6LAoNqDGXHMzypoYgEg2Oo dyWH6+Yzy/NWgCyy/uj+yjJf/zlDplI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=DZ5wBMh+; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 10 Apr 2025 10:45:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744307128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WvTNL6Tsz/oYgydOCDMb/zQ2Ru8zownM+E92WVITLxA=; b=DZ5wBMh+U8fsJHqeilcVKpqGpqvLqKZFPCPQw2wZcs+2Ai5g5FRntchqXLEA7ae6xKtXvi WRRMTMvhFoA4j9MVh/kRqIBCULIJIuAOkDRfe+TG9u4KtGASgZa3z+dVEfQfB+HbHuNUpx 5E4fvU9xQ7dfioWNSlT3Gkmze34T2fM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Muchun Song Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcontrol: fix swap counter leak from offline cgroup Message-ID: References: <20250410081812.10073-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410081812.10073-1-songmuchun@bytedance.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BF109C0013 X-Stat-Signature: crfew19373w8jbjatj1zbht1uo917k18 X-HE-Tag: 1744307130-471389 X-HE-Meta: U2FsdGVkX18Kv3jJvoCpMp3n6y4Bg6ZO0nyTlcpDysm1/8ocJ4b9QY6zBwVjE35Q8zySVHOWFlC2K18/D1fEczUwuTKDo25XSxXD1MWiMwgt61NKRtPqt9NQPjEqat9Z7zFz7GUyC/Q/1XgHNVEjXqdD8mid7Ayn0xZGY0emSVylSwm16MUQ7JaPb01Wk6XSd46CcwQNVLXfirh7uSTU/lSdtrq46G+L88lpzjCofDlXbkdtHq02GhWJjc1LcwaWmi5LeWCbwsjW2pMN4dwFBU8dLQKpwYgfI7fXhv76wg8VwPFmgoEKmLeq49f8aLodleXOCQP0+Lx16+cYSrhclVu3c0I4zgTOVwrSbGBxKipmLh+UKnToPnYtwqw3wFCoRl2uEy7NjB1KgW18aWzku91GaxI+Fg9VtZPcnzXuDwKUOxrY/FKLl8g6cjw5XhntptEuradFIHNbWvSNjgp5rz/GMGtr/zaaMyRMV35trEzjRQKynQLUANxH8JiU81egSKnCfD5bAW5JoPe4L2bJxm8+zpvNvkJkiMz2EiD1pvshMayoz3XhwgeA49DUwk+i8Ar61MWq1aYyZ7qs/OT1O+7QXfbRkQM4HKvYr+oY9vDsttIma0QYB41PK+RhMeqSqtMDbOOIcnRZGVHAjOgwAsysCQo5QF1FPl4GP4jY88m4f1EpLd6b7gfPh+cXNVrV0n27q/slF3BrpcSUt7sySl3CzifWHwWm4nTtLlsWtx0AlDp8ZbooMCnnlTsRMRL/wj0y7Y1BGm1gsNy9ADgXyZ7vZNkv5WZHAzmQEgfKld9PlSQRPhrs7ZB4sAbPiUvKY0UD6/u6sZZKm+wb2Y0y/KaE7Q7TAwPpr8/PfpAhcr+yBu7SwaVjlx/bdmfs1bJSGMXcuC6FhuL+Weil2aqXuwPKvAHyysqZcm9USToTxB0QvfqpLfszJYsl4njYdRQScHnImCM7eIWr2q7Vviq +GFyMW3D uT0PCFCCkyjcRgkD7giEFwbtrlnqv++RoEL4vEeefH7x2ImpYnePC85hC/HKEyw27Dk1A15e7Y9aAGhnE4PtCV6q2/dX9zHYmDN9K05oh5Q3k+a6ilqgNjoIceazYaOLiYwyGCI1Ro6Otf4NeU7wWqy6djhbXyrReHbIazSKVEZDKFGeR1WQcp/0dGbwEre+9JAvtP612GItS+bU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 10, 2025 at 04:18:12PM +0800, Muchun Song wrote: > The commit 73f839b6d2ed addressed an issue regarding the swap > counter leak that occurred from an offline cgroup. However, the > commit 89ce924f0bd4 modified the parameter from @swap_memcg to > @memcg (presumably this alteration was introduced while resolving > conflicts). Fix this problem by reverting this minor change. > > Fixes: 89ce924f0bd4 ("mm: memcontrol: move memsw charge callbacks to v1") > Signed-off-by: Muchun Song Acked-by: Shakeel Butt