From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45612C36014 for ; Mon, 31 Mar 2025 20:08:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AB7C280002; Mon, 31 Mar 2025 16:08:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85A92280001; Mon, 31 Mar 2025 16:08:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 721EB280002; Mon, 31 Mar 2025 16:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 54D56280001 for ; Mon, 31 Mar 2025 16:08:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B6EF140264 for ; Mon, 31 Mar 2025 20:08:44 +0000 (UTC) X-FDA: 83282934168.10.E2CB4D8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 5578AC000A for ; Mon, 31 Mar 2025 20:08:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=I5bC2xF6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RF5YC24n; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=I5bC2xF6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RF5YC24n; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf22.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743451722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AxtSZhlAxFKzw4BBK9N+f4ji1shi8sIGCG+DPES+K8E=; b=vDBmLtGjdRp4+ZM4BIr798A8+tec1IZmjVc9LWS8W92SK008WEfS3G52dcgicvAoKStfrO WZj4G+iptrl/b9a2wQBfmyC8/y3oVTAyz1KEyohFyiSglNewQjP/wNuwjJh7pcjuqqV+ly sd6GL5b7DolEbY8C1+nOktwyfdWVIsw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743451722; a=rsa-sha256; cv=none; b=DNbTrSA3Dq7YheN+WWQ3lODpCGrr1rXVbQU4xmdDIOiexTNM/UQChcwIEXAAyba5f42yca 6kPGbZ6NJDrAaHtMWovvGCCcgZu/qoVT0B0dxZN4TYqiYMwXemDbZgUtXJ0H6nDP5XtRX9 SE1bmqcwdNQKpZ0M9HNGi4B4RrR/kc4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=I5bC2xF6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RF5YC24n; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=I5bC2xF6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RF5YC24n; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf22.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CA32E2119E; Mon, 31 Mar 2025 20:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743451720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AxtSZhlAxFKzw4BBK9N+f4ji1shi8sIGCG+DPES+K8E=; b=I5bC2xF6nDlaylLh4AAdv7nsn5oB7BO41B2+y+9MizIINY44kEfQRFgGntbCBTKk70uCSK deOrxgmCLXTKfbqDTVEO42uorkscnabtM/SYtJ85bnfTaa4JNKYPkWNyaZR3UaoEoCc32R Ldt1tWl1dSS+28oCR2yvGSekC3DkdFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743451720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AxtSZhlAxFKzw4BBK9N+f4ji1shi8sIGCG+DPES+K8E=; b=RF5YC24n1ncWpar9FZf2m6v0xaQo5z2f1LQgH//Ld8UeAKmyfHAmFHyrsGkJ6ZCuFNkgF6 3xczLODr45fwJFAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743451720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AxtSZhlAxFKzw4BBK9N+f4ji1shi8sIGCG+DPES+K8E=; b=I5bC2xF6nDlaylLh4AAdv7nsn5oB7BO41B2+y+9MizIINY44kEfQRFgGntbCBTKk70uCSK deOrxgmCLXTKfbqDTVEO42uorkscnabtM/SYtJ85bnfTaa4JNKYPkWNyaZR3UaoEoCc32R Ldt1tWl1dSS+28oCR2yvGSekC3DkdFU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743451720; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AxtSZhlAxFKzw4BBK9N+f4ji1shi8sIGCG+DPES+K8E=; b=RF5YC24n1ncWpar9FZf2m6v0xaQo5z2f1LQgH//Ld8UeAKmyfHAmFHyrsGkJ6ZCuFNkgF6 3xczLODr45fwJFAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3372C13A1F; Mon, 31 Mar 2025 20:08:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id mcNfCUj26mc4HwAAD6G6ig (envelope-from ); Mon, 31 Mar 2025 20:08:40 +0000 Date: Mon, 31 Mar 2025 21:08:30 +0100 From: Pedro Falcato To: Ignacio Encinas Cc: Andrew Morton , linux-mm@kvack.org, Lorenzo Stoakes , "Liam R. Howlett" , linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, syzbot+419c4b42acc36c420ad3@syzkaller.appspotmail.com Subject: Re: [PATCH v2] mm: annotate data race in update_hiwater_rss Message-ID: References: <20250331-mm-maxrss-data-race-v2-1-cf958e6205bf@iencinas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250331-mm-maxrss-data-race-v2-1-cf958e6205bf@iencinas.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5578AC000A X-Stat-Signature: dk9b5cexehrkfmhxd3134a99murpws3q X-Rspam-User: X-HE-Tag: 1743451722-483910 X-HE-Meta: U2FsdGVkX1+MAORKI346w9m4XOMDD6g+GK1673x5+rMlEPzbxVHZhk3VaT6Pm4sAmF7PMlCiSMGEg07oG2q5jgB4uN33Kv6zkFmbv+iSfTCqI/AkmzTJNfpIIj8Gktqn8FCgZiczAjL+dbYvjiEinZyoVWfHQFeuPN3wBMjH4yVrj1wy+2MyK/m9QUMgVEEzt5aOJIPFDw9G/ghk1jasGW+zK5aAP42h0hixzmYiTAggJ7H0wb1eqrCGafGkTYANxjBpFlIkJDzGKQEO1LZjIq2ROQPe6fHjKGVW/ox/hMePC6wTjCzqTrV/cISJYEYXkiR1If+gyY3l955dtadqbOprBmWFrLv4o9B8IAn78m8Ap2npq8dwtpHAQFN57IedPFFqZFiBgobpCXVU3Ty+2UKo66TKeiFwsP+9TpRGQC2irc6eUnbufL5i9uwHmPiuR8YHm/aNJYJCNM8CZHl3RuUA6W1JtQEsvGukFVnz16RFTXES4giGA9VqiMTYbUEx+i6SZdJc2ro4mCQ2uMVpGaTzjL2AK7d7dtKA9/iLtxbDJRzm2rEG4mH+inAkThn0OOPMWPfX8AbIl03t/iUrVaNGnR38lxkKhZo3tjPbxIOFJxBlVJhEhq4BxUGmQWBtB0d9CEPWv1L+FeUKnlYey0GMvbhhL0tiZG3NTcS0dZKhrxTBJtPwz8qEUu50MgvP2mMaJX5g8eelbgoWDMOzDuJnvdf1RX3rzZb1KnLAqdxGwP8eJfwce6wKI/9qU7HQPERN0zT5/MBUgAXy7IlQStt6e2ZDZEsk+XEncNYSLUmIteXKHikdjJH7sZ8ob0se9BSxW3d/yuDFxCb5FvcyXLg3/8RlzgP8BDzqvQ5csHqHoFhjvEaix/ijSKlFzR4sHb+JbCCaNwm1EU89e1L6O4PynEGlTHkpJ8skM7pPpXLn3FsMGFc+jFJ8qZKkRLGh9rWWlOx7L28PTed/IEe hs2hbvm9 H/qyTY5OdJNer+J3zqC2jrjYIkbd+WQM4hbXUWDNsQHS8NE7V5+wLtQb1lfm5n1W5ByJHxldTvS5ACAujivDiQBzMzSWv3lRIeumuIanHiG1g4EMnCpLQGTF0Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.013549, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 09:57:05PM +0200, Ignacio Encinas wrote: > mm_struct.hiwater_rss can be accessed concurrently without proper > synchronization as reported by KCSAN. > > This data race is benign as it only affects accounting information. > Annotate it with data_race() to make KCSAN happy. > > Reported-by: syzbot+419c4b42acc36c420ad3@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/67e3390c.050a0220.1ec46.0001.GAE@google.com/ > Suggested-by: Lorenzo Stoakes > Signed-off-by: Ignacio Encinas Looks good, thank you for the contribution! Acked-by: Pedro Falcato -- Pedro