From: Shakeel Butt <shakeel.butt@linux.dev>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
tj@kernel.org, cgroups@vger.kernel.org, hannes@cmpxchg.org,
lizefan.x@bytedance.com, longman@redhat.com,
kernel-team@cloudflare.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] cgroup/rstat: Avoid thundering herd problem by kswapd across NUMA nodes
Date: Mon, 24 Jun 2024 15:17:11 -0700 [thread overview]
Message-ID: <qolg56e7mjloynou6j7ar7xzefqojp4cagzkb3r6duoj5i54vu@jqhi2chs4ecj> (raw)
In-Reply-To: <CAJD7tkZT_2tyOFq5koK0djMXj4tY8BO3CtSamPb85p=iiXCgXQ@mail.gmail.com>
On Mon, Jun 24, 2024 at 02:43:02PM GMT, Yosry Ahmed wrote:
[...]
> >
> > > There is also
> > > a heuristic in zswap that may writeback more (or less) pages that it
> > > should to the swap device if the stats are significantly stale.
> > >
> >
> > Is this the ratio of MEMCG_ZSWAP_B and MEMCG_ZSWAPPED in
> > zswap_shrinker_count()? There is already a target memcg flush in that
> > function and I don't expect root memcg flush from there.
>
> I was thinking of the generic approach I suggested, where we can avoid
> contending on the lock if the cgroup is a descendant of the cgroup
> being flushed, regardless of whether or not it's the root memcg. I
> think this would be more beneficial than just focusing on root
> flushes.
Yes I agree with this but what about skipping the flush in this case?
Are you ok with that?
next prev parent reply other threads:[~2024-06-24 22:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 11:55 Jesper Dangaard Brouer
2024-06-24 12:46 ` Yosry Ahmed
2024-06-24 17:32 ` Shakeel Butt
2024-06-24 17:40 ` Yosry Ahmed
2024-06-24 19:29 ` Shakeel Butt
2024-06-24 19:37 ` Yosry Ahmed
2024-06-24 20:18 ` Shakeel Butt
2024-06-24 21:43 ` Yosry Ahmed
2024-06-24 22:17 ` Shakeel Butt [this message]
[not found] ` <CAJD7tka0b52zm=SjqxO-gxc0XTib=81c7nMx9MFNttwVkCVmSg@mail.gmail.com>
2024-06-25 0:24 ` Shakeel Butt
[not found] ` <CAJD7tkaMeevj2TS_aRj_WXVi26CuuBrprYwUfQmszJnwqqJrHw@mail.gmail.com>
2024-06-25 15:32 ` Jesper Dangaard Brouer
2024-06-25 16:00 ` Yosry Ahmed
2024-06-25 16:21 ` Shakeel Butt
2024-06-25 20:45 ` Yosry Ahmed
2024-06-25 21:20 ` Shakeel Butt
2024-06-25 21:24 ` Yosry Ahmed
2024-06-25 22:35 ` Christoph Lameter (Ampere)
2024-06-25 22:59 ` Yosry Ahmed
2024-06-26 21:35 ` Jesper Dangaard Brouer
2024-06-26 22:07 ` Yosry Ahmed
2024-06-27 9:21 ` Jesper Dangaard Brouer
2024-06-27 10:36 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qolg56e7mjloynou6j7ar7xzefqojp4cagzkb3r6duoj5i54vu@jqhi2chs4ecj \
--to=shakeel.butt@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hawk@kernel.org \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox