From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846C9C18E7C for ; Wed, 26 Feb 2025 16:43:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0FB828000A; Wed, 26 Feb 2025 11:43:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF41280008; Wed, 26 Feb 2025 11:43:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC37B28000A; Wed, 26 Feb 2025 11:43:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 99E43280008 for ; Wed, 26 Feb 2025 11:43:12 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 137B0C1CC0 for ; Wed, 26 Feb 2025 16:43:12 +0000 (UTC) X-FDA: 83162665824.28.FB24490 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf19.hostedemail.com (Postfix) with ESMTP id 6C91F1A0014 for ; Wed, 26 Feb 2025 16:43:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OhBqGgJX; spf=pass (imf19.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740588188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dLIcEwz1cYEXVv+Z1t+YhrwjlkT01+yxfGT8JGTBVMA=; b=VkAPON8acKCkMf4lye0fG63UFG5cPXsB2CyWELC7aXr9Vf++FD76nYSJWTg2CJxL7nll1k mXRq6rpKsx3eUtmC7l2qZUNaFGag6p9BCgi+ICvLdE5185bx2eGHWOtKEifTVxR9/M+REO aPW5EFiMpmyXmxMG29YlMm5gqn8/dLg= ARC-Authentication-Results: i=2; imf19.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OhBqGgJX; spf=pass (imf19.hostedemail.com: domain of maciej.wieczor-retman@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=maciej.wieczor-retman@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740588188; a=rsa-sha256; cv=fail; b=Gf5dvBusHKdcp312orwrI0QfJWZjdpClu+gkBjXUst0gmq2r6oVw8/Zc9u2xzVqx0fEXq8 x4vCvfCd590yjUFaHUfcGTarsGvvvxUp9haryqYZk+7gt+bx3cY4KoRbacLakK9e+q/lmo gtqLYLa3PEE1uOCTzHJsTPmPDgdR0Co= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740588187; x=1772124187; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=SOxWUVeb+hO5tvOyRIDxk779Kp/RviUASZBCbfFpAEY=; b=OhBqGgJX1UfPqv4Ybc3QqgkBTndssLTlBHrCY+vWa5Q+/K93JK2ExGK/ SH6ScjXd6CrxVlsCOL9bRsREfG0h0M3O1cVKeXMXqqeUmUPzuWSnN64eH uWevCqW/kfMdnhKFsQgpvUqcOQZo89b1NQ1+p8xJfe/D7428C04xXoil4 uy6wnwHbW1atihNP014nWbAvG5lUO/TxCmupbN9IggefePhbjNKcfCkQH ZNc0ct0CllIywtbKm0CT7W191D6bMF/7eZ4/+OJFUOlcNExnx5xjYJT3c rBx2WotwaK4s1ArVuJ7O3XtrQpPToB74T1I7EG1sxNyzSUPEk+X8q+M3I w==; X-CSE-ConnectionGUID: /fjfziUUTH2gDuWnUtsLRg== X-CSE-MsgGUID: MEL53ntOSTmh0C3T327a3Q== X-IronPort-AV: E=McAfee;i="6700,10204,11357"; a="45358355" X-IronPort-AV: E=Sophos;i="6.13,317,1732608000"; d="scan'208";a="45358355" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 08:43:05 -0800 X-CSE-ConnectionGUID: HOP3DFL0TxmdptOvJqrkQw== X-CSE-MsgGUID: Fj7o3xGtSE2di5qBYjuIzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="147673486" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 08:43:04 -0800 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 26 Feb 2025 08:43:03 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 26 Feb 2025 08:43:03 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Wed, 26 Feb 2025 08:43:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OLVGRdG/sxd7Go8E0dIQVKc4YZjjvaJVFamdlU41gUFv9ssQmFPdP9HgDPF4zIHeoaGjYksSFQ2yRKJQUOdw47/sOwKP15vMbUrhCtkG68FsjExevpQrHxfQal4AAzqb8Uo84/J+PnmpgehFmvU4nOAR3AI1oQ4v6rkdPrVHXhtkBGcC5/7zVBTcs3m5LJAtmXQ/3X79FvpIJQ3fet7OV8LH1RMs9jfWzTqwLTczrwsP5ra/FZtKU+bM+3XAuwZzBCEI6wT+XBZa3FuDV/rmJcIZRgHX22fOxGOGap/LjLIaSJ0XnZPCp3gnUzkw5Sz4WL90TmxvgPiz9nfSTheolQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dLIcEwz1cYEXVv+Z1t+YhrwjlkT01+yxfGT8JGTBVMA=; b=AnLUH9bX1EzXSg8QJd6I4HPzCrJLqoJ+svD4mcvlPPMChT88Qr400SdhgcJwbjcc8CnuOLL1CdXj4s/0w0f/G8ElKezm+daE8lL1m1v0cVzDLLbz6Z2Nr4z6nGoRSXzf8kGS0Y89dwdkJs3y391TP5UunDVhyoZReTl+2Fs/38aLfw25HsiNcz4Q3vuaM/IKRJr80M8z0LlEefFSA2uUje5jCJr87w1IVJZNI60JScO0a6d3xr59WzTTeAqVgqNbT3t8uIjE/juSy6q6dSWQ2uRAtznLz1E8qHZoyCAwse6hY9yk2Z6OxrKizjLnhUvKgRVVpQ1cUchfqDivX15+aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN0PR11MB6231.namprd11.prod.outlook.com (2603:10b6:208:3c4::15) by MW4PR11MB5773.namprd11.prod.outlook.com (2603:10b6:303:180::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.20; Wed, 26 Feb 2025 16:42:58 +0000 Received: from MN0PR11MB6231.namprd11.prod.outlook.com ([fe80::a137:ffd0:97a3:1db4]) by MN0PR11MB6231.namprd11.prod.outlook.com ([fe80::a137:ffd0:97a3:1db4%4]) with mapi id 15.20.8489.018; Wed, 26 Feb 2025 16:42:58 +0000 Date: Wed, 26 Feb 2025 17:42:18 +0100 From: Maciej Wieczor-Retman To: Andrey Konovalov CC: Vitaly Buka , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 01/14] kasan: sw_tags: Use arithmetic shift for shadow computation Message-ID: References: <168f775c4587f3a1338271390204a9fe16b150dd.1739866028.git.maciej.wieczor-retman@intel.com> <6wdzi5lszeaycdfjjowrbsnniks35zhatavknktskslwop5fne@uv5wzotu4ri4> Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: DU7P191CA0026.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:54e::6) To MN0PR11MB6231.namprd11.prod.outlook.com (2603:10b6:208:3c4::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN0PR11MB6231:EE_|MW4PR11MB5773:EE_ X-MS-Office365-Filtering-Correlation-Id: 8528ab9d-ec3f-4fec-b5cb-08dd5684a065 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TFJOeXZMMjErU2pqNkl3cHVaMjdLeEtqRVZ5czFVeVRBdHA2QWM3dXlVcktQ?= =?utf-8?B?Z3hCLzdlMjRySVoxaTh5RmNBVmpRQk5tRENVbEN6NmFiN0xzajlwVVJvUDM3?= =?utf-8?B?TEl3VzZHTVJTOExhU0UzYkhTbU9nMGl6L1NDYWRFL3owUFlLYk5rSzMxQ0FV?= =?utf-8?B?L3JyeDZtREpLYmdWRS9EZEU3cFhBMW41MjBrbUxIbzVWTlJWbnRpbG5PQm1H?= =?utf-8?B?d05UdmZIQlllbTZ6b2dXNGhoMHdkOCtnNmlrWWVoTjhORHNBZzdpdFJYMzR6?= =?utf-8?B?UnNQVlo1bTd1eTN1WGVKcXdIREYwMS9RNk5VS3g5RVJYV2FkMUpIWTdSbklw?= =?utf-8?B?dHoyL1V4QUYwSDVOcUphNjFUQnVIQ0xSOEYrL1lRcE1BT085TEdjMkZ6c0tt?= =?utf-8?B?SkZCZ2s5TjdSQ29YMUtDbHpuRytmdFNVdlNEekNuNEJCd09UaHlRVzBRb0Ru?= =?utf-8?B?azQ5WkExVWhyaCtvQ1NySG1aTjc1WENsOGVTTjBSbnBMZXY3S3psUDh3RmNY?= =?utf-8?B?dHZlVFRDb1d0dlkza0NORnN5TzlVZlJPUWRIMnp6bmpidTNBS1EyRlZOSklY?= =?utf-8?B?UzBSZDFoVEJyNkMxbmQyV3FEQm03OWRmcXJIOXNnZVE3bkRFUFZtc2VMUTkw?= =?utf-8?B?WXBoYWd1QzRFalFjZ0ozKzNSNXdvTU5RT3QzdVE5aDhrQlFPelZPVmc0QUdU?= =?utf-8?B?SkpCOUVUako3RytVeTg4Y0pkVktoRkF5ekpTd1dudys5ZUh1enJOaTRLUUtl?= =?utf-8?B?bk1HRVBlREN3cUlUeVYyREFxUXZxZG5YN05RU3Fsais4N2dudlVHQWY3N3J5?= =?utf-8?B?V3NWSnFodExMOFc5QmE5RzhpUlVOa1RGQzAzNWdQRWdjajBsNFRqZ3lLdUpu?= =?utf-8?B?OEs2SDRPWmQ1Tm04RDAvbEZaRnNTZFQ1KzFJZS80Y0hMYWcyeFU1MGtrSXor?= =?utf-8?B?bnc3anRTd1hTRXNWdzhDUGFRMElZRmlQT0xuRDRodmh6Z09OUmlSV1FRbHdE?= =?utf-8?B?bnR2cTFYTCtiUW1QdmxZaFowbWZBTTErUGNFZlFqbDJraGRLcGpUODFyOTRs?= =?utf-8?B?VG1pM3l0bFFjV2RoTXpYemxReU5GRmliR3IxbDNyNkVPdzhvM0NQTzZLdmhh?= =?utf-8?B?VENGaDNMNENDRGl4VXdaNTFpYmdjZVNhWTRhOUF2NE1EZitxZmJMcTliQ0cx?= =?utf-8?B?L0pjMVhYWmkvd0dEdGcyZXdMcWNqS3JBdnZod1JGT3NKc1czeExkcnBEc1FS?= =?utf-8?B?RVBid1Rid21QVDRVZHRFRFhKWDdMS0pzbEZKMGl6NklRMGQ5SGpzZTgzOW9Q?= =?utf-8?B?WjcwWGI4UkkvYktHbkNaKzlEYjduUHJWMjN1dGtFU01OeUZqRXJMTTZuUHRm?= =?utf-8?B?dnl3c3FQTDJsemY4cWRQSGVHZ3lhTVlpUk94eGRFbHRNandYcGZDYitsQk10?= =?utf-8?B?clQ2TXdhdy9Pd0xrU3ZiVnVEKzVHT0FpSjQwS2tRY1N4VWYySkR3bHI0Tm0r?= =?utf-8?B?ZTlUVEJJS2RTUHdVbTZ0OHpCbWxsbzVhUVdqQkVCWHdWOEhBdzBxTHlYZXdj?= =?utf-8?B?Q0JQclFRUjZqYTJ0L3RnN2dDVHFSeVJFbnFDZzkrdFNHRGpFUXBseDVaWWRo?= =?utf-8?B?UkJnTXYybk1pU2lNYnN2V0NTVFEvdFBRQW9PRnJpdVc3dGo3ckVYT3M4WWd5?= =?utf-8?B?SFh0WUF5M25taC8xemxPNGVSZmFlTDIzd1JkK1o4cUtjREREcU1GN24wVEVi?= =?utf-8?B?OWxMUlBwWG9SdU5rUVc3c05SMkpEREdzWlI0aFdCZlNpVHBjaDBUMklIbm5N?= =?utf-8?B?cHlpSEJFV0IvSUs3RnZKdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN0PR11MB6231.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTFiOGVaWk9oYjd3QWxYZWVyei9jWEpwdlpSalIxYWFrUmltZ0drY1lPeklj?= =?utf-8?B?SHIxcmdjSGl2YXJaTXVxcGlXZHlwWFAzaTNnNXNCdnlrR1ZNcXdxUmxHR2tX?= =?utf-8?B?MkVUTXlaalZSb1JySlJTc05YQ2NRTEE5MHJsaGswTS9LWXRjQVRZNTNFK2NW?= =?utf-8?B?Y1I1VVh0dkNmRVk2RGlRY2tDOTlKOVdNZFFVSGluUHAxUmtsMGJQV1QrSjFX?= =?utf-8?B?MWM1a3MxQjg3dXBRSkdzWG1JZWd5eUl3dVJtUWFyZVlZYU9sK3VkYlcyckg0?= =?utf-8?B?dStWelRWcFFCT0UrdStVWEhSNnI1OXFnQUwzYnl3TzRQTXpjRk1jU1hhdjdl?= =?utf-8?B?aVd6VzBRM21hdnQ5cmNMWEkxRjVuQUdsdjBXeHpkQmVkd3EvelBCalU3NzdE?= =?utf-8?B?K0RqcG4rbU16TzNXdmJYT3pjajlDOWJ3OU5CdmpldHRwYktadjV5NkhMaVhN?= =?utf-8?B?L0ttL0ZXd2ZSY2dqalZZaG00WS9CNWtPTFhlZUE5Um1SVWRrVGhoWTZJQ2ND?= =?utf-8?B?dmJhV1hBc25HK29OWjY2d1dsSkZudUNEQktFK0hNZkI3VVkvS2lMMWNjblRI?= =?utf-8?B?eENrOVBmYTNqd2NFcHNvcllnUXFsd0tPZUVBZEpUQmtzRzREeEZKYzdDWGJK?= =?utf-8?B?c2FTdHlMVWNBQm5TalZ1cVVPU1pxbTlwcndaTVgralczWEtLL1lsWFNBc00v?= =?utf-8?B?SDB4NVA4SEpWNnRTaXN3ZnlrdkVRRmR6b091RzBRalZZRjJoV2Jrc1hERlYz?= =?utf-8?B?aGMzd0pmVzkvZzFSQVZmamRQTHRMN0dGVTdUdFUwaERUOGNMWEhOQ2NoZ3hN?= =?utf-8?B?OFl1UmpQY2lrbHBZejZFTlRiY3U3UmVlbmUwSXBkRFB5dUxtaGFrZ21FaDlB?= =?utf-8?B?dVBVL3FHT0tleU02akgwZ1ptbWlUMWxXbm91OStRRnhBb1lyTTUwNUxpeGln?= =?utf-8?B?cElpNGRyeEdWY0lZdlpDS3JEZVBRYXI5M2VBR3VUYXlWUHVoYTlkWCtjaWhL?= =?utf-8?B?Vkh5YmVvcmJwSWxLd09WSjlFcm11QVRpWGhtYjNBSVVjUmdGQ1o4N2JRMncr?= =?utf-8?B?RCttOVZMUzJyaEhRbFZoRDNpUlJKeENRQmdlSkVudXVwV09RNmdmTnhFOVEw?= =?utf-8?B?YlF1SGZWRFdtb1B3NThlc1RsZlJ4eUg3dTBXb29OeVhzWkdLMjI4a0QxejJP?= =?utf-8?B?Nk05TFZyYS9vUGdjMTErYWhwWTVLRzNIUGFuYUxnT0I2dlQyaDJjN1dzczA3?= =?utf-8?B?bDVPand5Y1lEWDB1VDFDSUNFZVdIa3gyTEFHdm9RTGp6bitBZmJraGRpNFN1?= =?utf-8?B?VFRwTngvNFlkVGlHNkxjU29zSHJ2T2RGNU1QcHhOU0oySkc1elJKRXBRUEl5?= =?utf-8?B?bnRxR2oxYUEwaURCREJIRW1MKzR6ZFB2bWtaNkovNDZFNjNXa3NOdG1HZmdI?= =?utf-8?B?M3YxdEhxOWhiRTEzU1NYRGVHcG54ZnhGb2ZSdHc5OVoyMkl3ejNOekZsWTVS?= =?utf-8?B?a1o0b0VsVWc5aWU4a0wxSGkxeGRjSmZVSEJXWjNXbktEdmpua0U1MlE2a3lK?= =?utf-8?B?OUNybGlLQmI2VXQzTlNzUitzeGFEdVk0NW40S0ZTeVBhZWExQWRVWSsxbFRQ?= =?utf-8?B?d2xwaWxLaTg5Q0FkOHc0L0Urc2s2bnBheHhyWXNTcVZsM2FWQ01CUmtKbEI3?= =?utf-8?B?c1pWRFl2aEJ6bFBhQUorOWNxVW5SUnhYRk12RTF1OWZ6WisxdEFoamhLVTRT?= =?utf-8?B?eTZJZTU0MjJqWEtUNzRwdzNEK3Q5UWN2N3BLNFlhcndwakw3aTFBdUY0SnZ5?= =?utf-8?B?MjNuQ0ZFY1ZDUHlCNzY5cTc1NnFzcExtUjFrRXZDMGRvbk95S29BV0w5ZEN4?= =?utf-8?B?andaaEpibDV2UUxvNUQwdTl4WUhQRExWdFlhdWtUWHJ6OW9WM1ptUE5acWht?= =?utf-8?B?VHFLbWh4RUdLM3RodWZBMEFtbklrODVJb0t3ck5XbnhWdlgrR3c2b29lSVZR?= =?utf-8?B?cGNBKzlhVnN3NDNxWk9nV2RZRkoyZG5MRXFzbHhKWHUzeFAyZGcybUJqYUhk?= =?utf-8?B?MWdSWkh3TWZLbE01QXJRaHFjNU40UkJLWUplaFRUSUlkTzhmSHYrVjZHcjQx?= =?utf-8?B?ZExpTWhoWWowR3pCUmpGdlp3VGlKVlVoYnM4WjdyWFk2WFg0TWZ2UHlDd3c4?= =?utf-8?Q?7qX0GMQLelO72p48/UC6C6g=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8528ab9d-ec3f-4fec-b5cb-08dd5684a065 X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2025 16:42:58.5304 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xT5Y0wDm089wxqx6KA7Z/nzo2BD6qS+wWKZT0nRYrW1YZ7hUhoxxEv/QmcujIVsYNzmw4b/8lociRtQvBZQgp3DaXpivgktYnCtdMGyfva0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5773 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6C91F1A0014 X-Stat-Signature: x4yyffizgatpbfytaqe6h45rub1yh4if X-HE-Tag: 1740588187-329132 X-HE-Meta: U2FsdGVkX1/pCcH3QG4IUDQ9XzD6pdwmCkgnXYzAJSIiCJwaq9TTp585KCAlvv1Sgnxw8wAtvFIaKB5yPkJ59vqdYU8KW3He//0+YzGJA+YjB9DgJEGVR8QWJVpJS+fHCNQ9Y07nnyiqAOQ17O4hgz6GgJN3F6a7sLcaZ90K82IFfpcxI1R4Z63eSM8bhDi/MFx4nwolsMfQnIFt3Lv/QtnwLjdrDcYvrPrhN9Lsnf7nVFre8d9DWy8DQW7O/rEgzRRd8gg4RC8RoWxXosptEoXX23QA7D5Po2wvhTA3Zl9q3detMm8GfRX1rZpz657U4O/AkLXsFw/SfTAHipTETjjPwnckaJFs124i3ichFXTubpi4o70YfoyzjYWS7N/9IVrxOT7o02TRCxRopllZkQXiupqBb7cK5ZE0PDKLG0XTKZZee4KPT3tLIt16N3+AAnjSDdDobIjy3jHjn2/F7j2vSVOPSakB+fI7tIHbInUIAyUmmRVKS8NcyJmEDBySr3Mw0LKAedGykMxJK6z2+A3AeiEEEoHm1MGrobQyRDWRoBg0Uu2XpGkVIxEAg/R3LW7OJiKHug1wjCn42+pgSM//vW6DQ+a8joUIzL9MvGofqUoGv4I6pjdAzHE1R3EpGvQEA706wC4K7cDZGYyUJ1vlrgBEVOtLphEoTtMbdVFpuvmm8rzQ4xBsdyXrZMn7iM+AaQdSE32smT7WFJng1FOpNsn8loKCeEXUB72qXCqYifgcbZruPksKtG7KHYWjlxhtw27EdURi2HZXqqako+1R4zRIDUwiEqBEkfHjhNTQBmI7owfr69W58pRVmQJCboDBVe8oe0nvb9Vf0N0jX01Zc8XYZeniwvSbbiva3445H/rn8ftBQ+J69k0pDdzB/VYis8dzJr1HurhBQ4xLWM/oisE945NLeIR88KKCGdBzQBYlDkt5iN61Ft4yFczBDSmJvfgHwoX9ELNrOQR Rwfi/YVQ Zvi0YjQ1krgMo5V8ThO3xwPc6jPJKaiyQdisoJEHlHA11NwbsG5LQTdgGGwIVf5bd9CxgEBYP1o1MmReaew0eAehIDvISvZQjqkgUSFriGkRWYfsppI7S1sEE2A/nuXtzhlu4O07EFcP0yyPPefTGCCcpZdcNzNDNXK3L8I7mMjeLUf5RHlpTNscL3YZfko3QzIT+ncc1RyvBNA2cM3rqHz82LOxVcIzIcKbgGsn6PSfYFVQUzj+S2IMPNuor5HWpbx31PFjXYpndGRPXciLbExDhj4YSX5OmQ/ov8R0QJE3viZR99KoA6ZhRJp68RGmaj+rP92vBK7QCJA7nM8cApttRglnAetv/M4T2zPYfmmYNLNfci6Y4ZPmLc6xlYIE9YTpqikL/vHkkCcSxNjb7U9QMZr0XqTr31S5j1cUeR3n3IzZZUU1pY7x1juEn3jM+wqTQmOlksvcGhaBbIU8SC0ToTvB6nbrO1R3sDEVTreHep6y5BE/WQi1CdyjdFZnOYqs4CZtunYUWAMnEMu+dUt1Acu7zbHPdmT6l6zBCcA7cuGa+IzeELSX0bMQ0k0dl+M+j/RhS0XyTGc7ueVgsUqey/+aVAv/b/zMjfKZAPSiMHXY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-02-25 at 22:38:06 +0100, Andrey Konovalov wrote: >On Tue, Feb 25, 2025 at 9:13 PM Maciej Wieczor-Retman > wrote: >> >> >>Thanks for letting me know about the tag resets, that should make changing the >> >>check in kasan_non_canonical_hook() easier. >> > >> >Ah, but the [0xff00000000000000, 0xffffffffffffffff] won't be true for x86 >> >right? Here the tag reset function only resets bits 60:57. So I presume >> >[0x3e00000000000000, 0xffffffffffffffff] would be the range? >> >> Sorry, brain freeze, I meant [0x1e00000000000000, 0xffffffffffffffff] > >+Vitaly, who implemented [1] > >Ah, so when the compiler calculates the shadow memory address on x86, >it does | 0x7E (== 0x3F << 1) [2] for when CompileKernel == true, >because LAM uses bits [62:57], I see. Thanks for the links, now I see what you meant. > >What value can bit 63 and take for _valid kernel_ pointers (on which >KASAN is intended to operate)? If it is always 1, we could arguably >change the compiler to do | 0xFE for CompileKernel. Which would leave >us with only one region to check: [0xfe00000000000000, >0xffffffffffffffff]. But I don't know whether changing the compiler >makes sense: it technically does as instructed by the LAM spec. >(Vitaly, any thoughts? For context: we are discussing how to check >whether a pointer can be a result of a memory-to-shadow mapping >applied to a potentially invalid pointer in kernel HWASAN.) With LAM, valid pointers need to have bits 63 and 56 equal for 5 level paging and bits 63 and 47 equal for 4 level paging. Both set for kernel addresses and both clear for user addresses. >With the way the compiler works right now, for the perfectly precise >check, I think we need to check 2 ranges: [0xfe00000000000000, >0xffffffffffffffff] for when bit 63 is set (of a potentially-invalid >pointer to which memory-to-shadow mapping is to be applied) and >[0x7e00000000000000, 0x7fffffffffffffff] for when bit 63 is reset. Bit >56 ranges through [0, 1] in both cases. > >However, in these patches, you use only bits [60:57]. The compiler is >not aware of this, so it still sets bits [62:57], and we end up with >the same two ranges. But in the KASAN code, you only set bits [60:57], >and thus we can end up with 8 potential ranges (2 possible values for >each of the top 3 bits), which gets complicated. So checking only one >range that covers all of them seems to be reasonable for simplicity >even though not entirely precise. And yes, [0x1e00000000000000, >0xffffffffffffffff] looks like the what we need. Aren't the 2 ranges you mentioned in the previous paragraph still valid, no matter what bits the __tag_set() function uses? I mean bits 62:57 are still reset by the compiler so bits 62:61 still won't matter. For example addresses 0x1e00000000000000 and 0x3e00000000000000 will resolve to the same thing after the compiler is done with them right? > >[1] https://github.com/llvm/llvm-project/commit/cb6099ba43b9262a317083858a29fd31af7efa5c >[2] https://github.com/llvm/llvm-project/blob/llvmorg-20-init/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp#L1259 -- Kind regards Maciej Wieczór-Retman