From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5283C27C55 for ; Mon, 10 Jun 2024 14:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285BF6B0095; Mon, 10 Jun 2024 10:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20E136B0096; Mon, 10 Jun 2024 10:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 061106B0098; Mon, 10 Jun 2024 10:53:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D7B9B6B0095 for ; Mon, 10 Jun 2024 10:53:34 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5D3AD80B6F for ; Mon, 10 Jun 2024 14:53:34 +0000 (UTC) X-FDA: 82215272748.26.416BD6D Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by imf23.hostedemail.com (Postfix) with ESMTP id 4CE3B14001A for ; Mon, 10 Jun 2024 14:53:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=gNS0cPAE; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf23.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718031211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o9UpQ8SinD6WVcDO33xVDCTBVusEJQKNKyZBqbuV5A0=; b=pzMkQVdoRrHfgZL9USJuvclj9Dz7j3sqIEMdLh7gzLhCsx0vOuxbdeNH/cl6QDyH9SIjTp hL6fyIG7ty/4x6ioa77MegX53nr/9dpMzZPgwHnETb8nIoJ+gOMhcpWLag+aYIEScY+knM 4sl8tZhe/O05oPcQZ7//Qj6oYXVdUkI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=gNS0cPAE; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf23.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.12 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718031211; a=rsa-sha256; cv=none; b=t+ZZrveabM1SeaxvpQjUC5wJnpbseXRTwpq3KmNLnFKDKB/6kguntHedQMlpSBh2aiRARd C9iwmjGvtYVWroXgt/XfEik+7zOzZJwi2pF1lDVhvaeVUFQE29+mV/uuGA7hQzLcZeaBy+ 7g7/eE8qTcMdYcIBAU3njjxk/sRRtys= Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20240610145328euoutp02486eba11c5388c953e88caff3c6bef4d~XrEgFuJLy2384023840euoutp026 for ; Mon, 10 Jun 2024 14:53:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20240610145328euoutp02486eba11c5388c953e88caff3c6bef4d~XrEgFuJLy2384023840euoutp026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1718031208; bh=o9UpQ8SinD6WVcDO33xVDCTBVusEJQKNKyZBqbuV5A0=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=gNS0cPAEa3WOB5qEC5DXD6pRnB1FIVFjO8YrNdLwQeOfXmqfChcu4Aix13FOG6/X9 Cdmk8FCBIFhsihrk5pkLWbKKQmmjXToWy1E+BJtGz/HaIoh4wN/jl+cMRFfyP0Wy4/ Zr/Q7Xzn9d6OYT8XC/3Vfh/qT6H4G7FyEklkJQ74= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20240610145327eucas1p1dd85462827a14c8df503fabed8349988~XrEfzkLL90858308583eucas1p13; Mon, 10 Jun 2024 14:53:27 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id C0.A3.09620.76317666; Mon, 10 Jun 2024 15:53:27 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c~XrEfYjiPx0884708847eucas1p1K; Mon, 10 Jun 2024 14:53:27 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20240610145327eusmtrp112e0bdac246d1499209a8cd444a47dc3~XrEfX28Vw2921429214eusmtrp1Y; Mon, 10 Jun 2024 14:53:27 +0000 (GMT) X-AuditID: cbfec7f5-d1bff70000002594-da-66671367850f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 82.1E.09010.76317666; Mon, 10 Jun 2024 15:53:27 +0100 (BST) Received: from CAMSVWEXC01.scsc.local (unknown [106.1.227.71]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240610145327eusmtip2cf537ea4cf511ac2d8cd0ac1e4292a7d~XrEfLZTwF0509505095eusmtip2W; Mon, 10 Jun 2024 14:53:27 +0000 (GMT) Received: from CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) by CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 10 Jun 2024 15:53:22 +0100 Received: from CAMSVWEXC01.scsc.local ([::1]) by CAMSVWEXC01.scsc.local ([fe80::7d73:5123:34e0:4f73%13]) with mapi id 15.00.1497.012; Mon, 10 Jun 2024 15:53:22 +0100 From: Daniel Gomez To: Baolin Wang CC: "akpm@linux-foundation.org" , "hughd@google.com" , "willy@infradead.org" , "david@redhat.com" , "wangkefeng.wang@huawei.com" , "chrisl@kernel.org" , "ying.huang@intel.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ryan.roberts@arm.com" , "shy828301@gmail.com" , "ziy@nvidia.com" , "ioworker0@gmail.com" , Pankaj Raghav , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/7] mm: shmem: extend shmem_partial_swap_usage() to support large folio swap Thread-Topic: [PATCH 4/7] mm: shmem: extend shmem_partial_swap_usage() to support large folio swap Thread-Index: AQHauAk6tPOy90LG0EqwmRY04o2YSLHBCwmA Date: Mon, 10 Jun 2024 14:53:22 +0000 Message-ID: In-Reply-To: <358924679107339e6b17a5d8b1b2e10ae6306227.1717673614.git.baolin.wang@linux.alibaba.com> Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [106.110.32.67] Content-Type: text/plain; charset="us-ascii" Content-ID: <9FF719F11960B546A2F926BF1CD6BC46@scsc.local> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGKsWRmVeSWpSXmKPExsWy7djPc7rpwulpBo3LDCw+3xWymLN+DZvF /73HGC2aHjxisvi6/hezxdNPfSwWi34bW1zeNYfN4t6a/6wWPbunMlosOLGY0aLx831Gi98/ gBInZ01msZh99B67A7/HmnlrGD12zrrL7rFgU6lHy5G3rB6bV2h5LN7zkslj06pONo9Nnyax e5yY8ZvFY+dDS4/e5ndsHu/3XWXz+LxJLoA3issmJTUnsyy1SN8ugSuj++BC1oKNnBVTr8g2 MC5g72Lk5JAQMJGY+fwLI4gtJLCCUeL055ouRi4g+wujxM0lT9khnM+MEq9mnWKF6Xj64ABU YjmjxMftJ5jhqnZvbWCEcM4wSvR+/cwK4axklHj65ApYP5uApsS+k5uA+jk4RAT0JXrn+oLU MAscYpVoPHsO7BJhgWSJ/5NmgtWLCKRITP8+mQnCNpKYfGwiG4jNIqAqsf3lPWaQObwCvhLn /kaChDmByht6ZoG1MgrISjxa+QvsUWYBcYlbT+YzQbwgKLFo9h5mCFtM4t+uh2wQto7E2etP GCFsA4mtS/exQNiKEh3HbrJBzNGRWLD7E5RtKbFl50oWCFtbYtnC12AzeYHmn5z5BKp3L5fE nuMlELaLxJUJy6H2Cku8Or6FfQKjziwk581CsmIWkhWzkKyYhWTFAkbWVYziqaXFuempxcZ5 qeV6xYm5xaV56XrJ+bmbGIFJ8/S/4193MK549VHvECMTB+MhRgkOZiURXqGM5DQh3pTEyqrU ovz4otKc1OJDjNIcLErivKop8qlCAumJJanZqakFqUUwWSYOTqkGJuanrBIu60tSbM+KyHT6 hDuc2xhctUEnjO3ervrrf49GiXbf//tf03nzk7msH+z32E/xuyV400P2b9Sqxm8nXf0tn+5R vNYpZ+g/edFHVUG3b1xfr5S+yGhQrmxfHMd26MK2ZZMW/mmNYlP6z1uSFcXzoktLwXOGrPK9 x+umVm9ub1yaJTE7gmtK53m/7EVphpLf+y1lVgWndL5epXSiUbi4b/1Cg9VrDJfZvn37efKq OH2vZf+v6Zw7GeKjlJ/XKy7heEM3/fwZ+2pnxpJfJdl2UhL5u7byM0/8e1J715MFS5d97fh/ 6sBDPqvkDdtzJu6xlexdubdEbf2UtLzwz1avHutKls59Ias0/+uj20osxRmJhlrMRcWJANKE EXkJBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPKsWRmVeSWpSXmKPExsVy+t/xe7rpwulpBjPWi1p8vitkMWf9GjaL /3uPMVo0PXjEZPF1/S9mi6ef+lgsFv02tri8aw6bxb01/1ktenZPZbRYcGIxo0Xj5/uMFr9/ ACVOzprMYjH76D12B36PNfPWMHrsnHWX3WPBplKPliNvWT02r9DyWLznJZPHplWdbB6bPk1i 9zgx4zeLx86Hlh69ze/YPN7vu8rm8XmTXABvlJ5NUX5pSapCRn5xia1StKGFkZ6hpYWekYml nqGxeayVkamSvp1NSmpOZllqkb5dgl5G98GFrAUbOSumXpFtYFzA3sXIySEhYCLx9MEBIJuL Q0hgKaNEz5NdUAkZiY1frrJC2MISf651sUEUfWSUuPS8F6xISOAMo8SNve4QiZWMEm1/XoEl 2AQ0Jfad3ARkc3CICOhL9M71BalhFjjEKtF49hwjSI2wQLLE/0kzwTaICKRIbO46wQ5hG0lM PjaRDcRmEVCV2P7yHjPIHF4BX4lzfyMhds1ilLj/7ShYLydQb0PPLDCbUUBW4tHKX2BzmAXE JW49mc8E8YGAxJI955khbFGJl4//QX2mI3H2+hNGCNtAYuvSfSwQtqJEx7GbbBBzdCQW7P4E ZVtKbNm5kgXC1pZYtvA12ExeAUGJkzOfsExglJmFZPUsJO2zkLTPQtI+C0n7AkbWVYwiqaXF uem5xUZ6xYm5xaV56XrJ+bmbGIEpcduxn1t2MK589VHvECMTB+MhRgkOZiURXqGM5DQh3pTE yqrUovz4otKc1OJDjKbAsJvILCWanA9Mynkl8YZmBqaGJmaWBqaWZsZK4ryeBR2JQgLpiSWp 2ampBalFMH1MHJxSDUzbp/qVvln0IqZl1dQtG4rnvlz2xC+Hp6vMN+jexcrWLO5zip9YWCoa DbTy7zYsbNKT4ZoQwH+BX0hv/vVJjmHcCju+HZJVdrGYItDcUJgn8VDI8Gak8ey/3B/qP2js fTYrpNdlvuvhY81Ldxfv03x/uaBYu0bloFKbN9MFz63FXlfLD8eGdJ552NS77MP9S3E9RmHS NXpbxf4Ybqx+Gl7zZLPm3Kv/Sud47FcOLbNj3/CiUc1NuzgyJz2gWM8s0nhVBPdCntLtZ60V HP38JzFGK++WdHp1LtFU8UV+aLhLwFLJs6/ai5dm8Qe9qtl0snZO4hN/5ZBbM1901LWwZsu1 /2GquVR1aeFflmAPJZbijERDLeai4kQAgaTV1RIEAAA= X-CMS-MailID: 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c X-Msg-Generator: CA X-RootMTR: 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240610145327eucas1p1bb32a985f8eaddf8cdda0b5415c1868c References: <358924679107339e6b17a5d8b1b2e10ae6306227.1717673614.git.baolin.wang@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4CE3B14001A X-Stat-Signature: 9pfkzsm71sqbrjyzbcb9ofpo13o91ois X-HE-Tag: 1718031210-178024 X-HE-Meta: U2FsdGVkX1/c1N+pecgTaGuGyXZLpqMKJ6wMFayJDP82k2kC/D9sXvsQAtOZFNKGmTTC+Gtg0aJiwwp7evOK2s//7i1K2cp0FG9ijCbncAyqgp/sWoBicNTfoWhi+nxTtB2y1W4T1ZkAUnEIi4DxB8EiE1rlDXNxtRsDVq6rWLbcq6AYKDpf2wXT04OThZIxWv9bhUBNvqIP968lrA1bmA1fOf5g67ISbgOi74YF7ke4BfJyLGyJD39Q2+dhTdAvjrJl+9ipaRqjwhzgYDb6r2EoD8cqCMj5J0w5T1gYraT/xL4OE1pqhFYey3PseJlWasYWb9ulNrIQIxpITgsJUNRcq2rMJ5gDT17DrOZHViUyzGWqacQQvQtUpev72pbYIvFgGeBO1lGtLxwXuvAUZajKsEd2pB+1FYX8h6yNpr08rLxF53ZqGC+G7dvR0zMaK3pjggsL2u8Gk7FlgN0KDuZPdVwKFxPzniPga0uMzy9YuMLcod4TAIAq0V9F3IfggeX0TwDSmroYq6hkmGGeTVXLrUTX+5LklYSELms4MtSpAEGWOyhximrpvseM2JnsKoowgGVX+3Xrhy1y+FJIc8Q3ztgAu1H0hwOJ3zcgJCIj6vpJ6bB1hFr4GCRf9X4byhf4CxgOjup6ledAqTxE19bypWgrTFhPDQE4ButT3DxPGrTdaqX/k8ZM9qVbohIqT5dzbsIOLV/HdWy4i7AEKmLg51XNHQdkVoYYnbyzFDERbj1Cs3GfmSiMCIHyQvIRmrG2eMWnJDW99vm/R7EODqv6gK1r83UTPIp8KtHTSui5YvE5OsYBuQ3dMEC8r5XIhEeUCpT2Gis71tLfY3Dng1g2m93ACDod3hsEXSKcy92rqw9mjWxwxE/qETi5VSpH47nvyqzV8gi9+Z9DMZNPPZjrf4KrMoncDWyKcCRT53x+Ded9o0TZQS5OxfRIzPq7hbH214NpVrbcCgB0VuU T2r0X3/H ROtldMWrhy+Lm5J1sISBLXm8PEhMOfgGcBpwGDMsWfoNVxcIUqHrB9vZpPg4Nc6/RL3B3czCqeI0ufTwXHHQA+/u8dqFGE3KUzgwlv6RSTRSrEU3yx7s737fj/mYQn23iBBHr8EM8PwecuWVyZFKwsmZjmRxo7BRsZ0ZO3poX0rgdodekKR0C9B1+CAQqD9PwgS0ALujJb0qhMIA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baolin, On Thu, Jun 06, 2024 at 07:58:54PM +0800, Baolin Wang wrote: > To support shmem large folio swapout in the following patches, using > xa_get_order() to get the order of the swap entry to calculate the swap > usage of shmem. >=20 > Signed-off-by: Baolin Wang > --- > mm/shmem.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/mm/shmem.c b/mm/shmem.c > index eefdf5c61c04..0ac71580decb 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -865,13 +865,16 @@ unsigned long shmem_partial_swap_usage(struct addre= ss_space *mapping, > struct page *page; > unsigned long swapped =3D 0; > unsigned long max =3D end - 1; > + int order; > =20 > rcu_read_lock(); > xas_for_each(&xas, page, max) { > if (xas_retry(&xas, page)) > continue; > - if (xa_is_value(page)) > - swapped++; > + if (xa_is_value(page)) { > + order =3D xa_get_order(xas.xa, xas.xa_index); > + swapped +=3D 1 << order; I'd get rid of order and simply do: swapped +=3D 1UL << xa_get_order() > + } > if (xas.xa_index =3D=3D max) > break; > if (need_resched()) { > --=20 > 2.39.3 > =