From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64733C4829A for ; Tue, 13 Feb 2024 23:55:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0B296B009B; Tue, 13 Feb 2024 18:55:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7196B00A0; Tue, 13 Feb 2024 18:55:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C345A6B00AC; Tue, 13 Feb 2024 18:55:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AE7186B009B for ; Tue, 13 Feb 2024 18:55:23 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 79FC7160D3C for ; Tue, 13 Feb 2024 23:55:23 +0000 (UTC) X-FDA: 81788439726.10.A73B79B Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf11.hostedemail.com (Postfix) with ESMTP id 74AB940013 for ; Tue, 13 Feb 2024 23:55:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ukudvr1a; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707868521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7lYndZ54iAip9ue1kfzMMJiei98FQfeXzYAkwe/hBTc=; b=xVj9T9p2vRSbCHdmKSqie8fjLHWuRbPe4f2dDX3+L+8nknA3BYgMV0BhvFnLc12j98Zyar 0+NgOtddngl5DpmMrqqkeHKDIUdL6tiXJqdgmlnYg5oHzBLNgBPkeqpyTlb214yPpR6qr4 rjBAcAQS63F7a9E27b4BPy7mWKCFpD8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ukudvr1a; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf11.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707868521; a=rsa-sha256; cv=none; b=G9MX7OHX3PprHLY+EBSUIjHKfr+eiqTAF524HOEbj5KJXtLm+Ao2sG8ri9iSeJirA7dHyW +fKTQ/ntKwnEJlfGyN+v5NwAFMD2hABB8ahHXbAbsl8Jf5T0yWjtZmuRIwoCC4TQOVqTL3 3fvac0WSJL2kcVQEogCsepXfJRMu9UA= Date: Tue, 13 Feb 2024 18:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1707868518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7lYndZ54iAip9ue1kfzMMJiei98FQfeXzYAkwe/hBTc=; b=ukudvr1aCEFWsRD5Qc+t69T82wSLiWNggDNNSaihs/+5HsdVi3IiDww/W4Hjipu7Ldjze6 fAlCdelItrMUUTcWWDaTYUW6HpXNtgsbiiEPWXxlSH+7ReEIr0ot/QCNg/6qEL8BJBc7Zy DmTXmD+wnOiL++TyCVx4b0U5F/8chrk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andy Shevchenko Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , Noralf =?utf-8?Q?Tr=C3=B8nnes?= Subject: Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size() Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 74AB940013 X-Stat-Signature: 7hwd4a93t9keo3ncr5y4pn8qxoih9yii X-HE-Tag: 1707868521-521356 X-HE-Meta: U2FsdGVkX19NiSwOzeXp6ZzMgTpnwevMtwxJXCAl83qNICygWW8SCNbNeCl3ipWEr8OpUjm3gAzKp8HPLku3DQ2JdU1AR3tGRSbNFt9zDYinL0D61va6p3F2wxy97xR9dJKUERg4M21sizTfP2HrWpU/Jg4h12C9eq+/HvsMuCCTvPvmNCUnWamj1V8x0/ZJD600+CjI8QawMiiSCSvg7Z0dopebutVJOs6ZH5OPEihmV1y0sGvUrXm5oHSv9yeJMSfMknGv5pE6XlLXo3NOEalYTZYbB29aqShN+/c3gAGQnGDa95RU1r7iMtlS0pAMXiINI70ABew1HX7kp/aP6tm8cM5Yg9gBJqq1TLll2yiUTSjz8nioOlgYooQkBovW2FEPCCFvzju8DDkYcx29lOxrJaWqhy5rvrHIU4QXyKAbcP9jqiL76H4T+V93IdLl/0pitk1aw+LWzqw4K/h817Fy+zb1iBbU5MUrir6TF7lS0ozciThTHGtaAN8lnwgtNz3UMlFfWSKmBvg57lq9VQiRVyBiJJryC9MP6256AQTSfuv5bIUTBCC92f+Z4gs5Rm6c4A7ROHXu+OrUhBFPGxkt86wya12sbyo96opWIAoMRE7Bs4Pz8xnTTnuo9zbCHSqL301N6kPlhIWsBo2Q8X5n9+AHE7XmIbahpbkf4cJPrqFgetgP/nP4B77WuRTb2ubW6YbxE2tT1kCnkqYTif5e7qUFLiOw+0MOebKXuVIw4Bnb0BBnp7PGVrXZF9B+h4sl5xP0UnaoV9if8cA1SmJylhXjQktFtBkt2r/8zq/p8ap0feEsiKFY/r8eVddMK1ILVe58rrBq1oVZuawgWHxPzitYEm3t30J2me+xBYFXBN7FXhBUWQN1CI5tUpmE4+1nujlBG2yHNrUgf12Ghq4FFhXBxBBR/rYN6a7tx5FND8mzRtpKg4HUBMLOhMvywUpz3EhWDuRDiNjlQb9 uaYRA8H0 QlxA1yKenQRMM4mTZlwcXUGjkkSiOqGSOc3TEwh+PreSK/yUrelPfC7zpq09zsHa3nVhxBMUdL3xL50aCdZouMaN2HrCoA4FoLJdtLnIRi0Bilv91Gl1lSSwvv2JUUGLlfkDmoH8jtwNEJ90myefHOu47FZbJPswQ08pIEZPn67oo6+OMNukEJ3AZm2z3pHMzKmhA4/fFrmVZMSk+9uSXc6/t+OM/0fkIR5h0ki+XNW0CHbf68yf0DlaMPeD1gm/scEvNWL5+rsODAW+9ueXwFeY23A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:29:34AM +0200, Andy Shevchenko wrote: > On Tue, Feb 13, 2024 at 10:26 AM Andy Shevchenko > wrote: > > > > On Mon, Feb 12, 2024 at 11:39 PM Suren Baghdasaryan wrote: > > > > > > From: Kent Overstreet > > > > > > The new flags parameter allows controlling > > > - Whether or not the units suffix is separated by a space, for > > > compatibility with sort -h > > > - Whether or not to append a B suffix - we're not always printing > > > bytes. > > And you effectively missed to _add_ the test cases for the modified code. > Formal NAK for this, the rest is discussable, the absence of tests is not. Eh? The core algorihtm for printing out a number in human readable units; that's definitely worth a test, and I assume there already is one - I didn't touch that. But whether or not the units suffix has a space, or a B suffix? That's not going to break in subtle ways; that either works or it doesn't.