From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC67E75459 for ; Tue, 3 Oct 2023 18:22:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14BDA8D0081; Tue, 3 Oct 2023 14:22:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FB458D0003; Tue, 3 Oct 2023 14:22:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2BAF8D0081; Tue, 3 Oct 2023 14:22:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E48DC8D0003 for ; Tue, 3 Oct 2023 14:22:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B40641C9FCE for ; Tue, 3 Oct 2023 18:22:53 +0000 (UTC) X-FDA: 81304971426.09.C72C5C7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf24.hostedemail.com (Postfix) with ESMTP id CA608180008 for ; Tue, 3 Oct 2023 18:22:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=FbmB+coq; spf=pass (imf24.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696357372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=snq5RhSGYHBHi8BPd1bP7iYx3B/gYWxBD5InsOqzHAc=; b=pgi/EN8wi7m8ovEnKe4fa4kHFCYrnypZE58aFUq6pVTKcORBUrcCijJGRY+6fD9/rYLNNV imptv4O4grKSJeTdF6h44h38bFPuC29brFgf5zpuoXY2fLRpHIWCsLiadlA/EXWJvlC87m TKZYXVhRBp2tdKEL1eFxMYMhZQVchvU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696357372; a=rsa-sha256; cv=none; b=WnuVMqtcjhSxSbs5Y8msfp3ncYBGkvyn3mcGCzgpvFnB2Fc65zldA1L/gutF0lvDrVlbB+ PPUsdLVu5eLSKcj7Qzk0V2eMmZjsemASOdCGXAPFQLS64HO6oRIIggTzITqFbBZxFy1vWI ECQEYDhr0XmpqyeQ2qSCnXpxKkO3Iuc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=FbmB+coq; spf=pass (imf24.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13BB021850; Tue, 3 Oct 2023 18:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1696357370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=snq5RhSGYHBHi8BPd1bP7iYx3B/gYWxBD5InsOqzHAc=; b=FbmB+coq881p/BKfyHH0tppRCI9xdBQvqZTf6VUI5qSAATOdlfsaAvPJZvUso32TKwph7M zMw+zZX3DdgxU0FUsYow8ISINzOevV5RYZH+ZdchhBSev1UEGLWUMhekrjeCe47dQXSEQq XsqsCZVz6N23A8SAD6BJ6RUAkt4yRIs= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D95A7139F9; Tue, 3 Oct 2023 18:22:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bMxMNPlbHGWvOwAAMHmgww (envelope-from ); Tue, 03 Oct 2023 18:22:49 +0000 Date: Tue, 3 Oct 2023 20:22:48 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Andrew Morton , Shakeel Butt , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] mm: memcg: normalize the value passed into memcg_rstat_updated() Message-ID: References: <20230922175741.635002-1-yosryahmed@google.com> <20230922175741.635002-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xld3q657sg75bexy" Content-Disposition: inline In-Reply-To: <20230922175741.635002-3-yosryahmed@google.com> X-Rspamd-Queue-Id: CA608180008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tgew5j1xmauktox5dj37rytnjsz1oa98 X-HE-Tag: 1696357371-750988 X-HE-Meta: U2FsdGVkX1/K5bN/LvAHwAshrdEjiyRnBXFmCVJlNhBLz2ecqSzRxGB9cKiRCmLeqQ7U1vk7AFrc15BvZlZukPOu3jMyAGBD+HtD7xUjgFNffAHVb+aNxdCVwiY60baYxviUJsKSt2i2xUF+G7VH3ZU8NyQga8dHimtbxqAWbtN5KZT3oQGWhcksNI9GIP3exggjB/WF2jwfU+PSRicSehQWoB0mBfg1eWRRzC9F1CFxL3t86NI7vpPSzgPz4KuScSjJ65rRQ3XUEq5MgpxSqUdF5lr8scvSBLi+morDeI43eGsjKfeC05anDRSC+hzOl57woPsgtnMUNrLdNmLXahy/jhocKPS9d5p+QOpg9NwdRHDxNo5uKiVh3i4BsKD20iZYpXmhS4abzorwDM1QPrUUsSNqldyTnOUiPSEb+2KwPHbFB+h5HAt4FECDCn6x/M3C7ZDKysjmp2OSuigJ4BTJXYDXuLLtnk5M6OehH0oqcgf6HaqOdbNaXkIvM/3b8TNG3WsgNJN6pIkeJx7Htd2DWGPQbCZrFmAmlTnfZFA3t9a9JlRlNBOQNoajYLj6KFg4NGMyvgZmA8QtgC2wz/pgl/EAO9OCLls0I+4s3dzOdb16GooY/lzWQkNMHTmPeK4o6HX+qk7DblmQS0MNjObVZU6NmES8tpnffh0pUu05m23r1VL7+4NNyEzxwzIe0NkY/KeWlQms61KhbG94TSzj7a5eAPExl8r8zdGV4+LP+iwJOOplU0a812RbHvaVfF445cM2LzzPBJM6hKuUeSgo+mT58s5KqSgun9mOWNyH71i7O3uP2Kx6x6ccokgHVV/ICWGqiZC+NzNItzn9zXzMPBCaFhMJyKkc1rReW/tfvVTOZL0GJHRszwxMHd3f8+KBoD/ix9Zy7aEBJMDVOWr7B+xOKRHAE/kJJAvmK9NoWonQJLparsBnubrvtOIWRTqcQfAQYVmHc5qG2ZZ Q5VAR9yy F0d0PI9aelHHZF5dvVwUrCMgzQNd+0K/b5AxJ1p3eNQzWPIza/AgbBo3Fgj3ZPJQIyMA9hRrjglefxWVT9p8LMLPJanna3nyCamkATHjgavPAEnAnLEADX7dAr6o1hNgSj7qPQ9ZBeURWxl259akZ7yGCcgFQdq6tr94shHwgQtan97Cr0GVZXnQtbZA6aTGpLjcM56S4bRUKyQNi67AD2AGzUP6CHhaLcviLd92Zu2uMQ3p3gActb3rlVKNwm5HNFRLiUaD7+lvs8NDwp9hTY2XbKNVGsslJz7ni5PM5LHBmRs1NZB/IkIqIbTayvQfkIeFSRe3xgfL3ZBos42E1SfWrgMC+taQgFvTb0OwVYiMcVKz2PRBd0y6iwQsjMteP/9Od X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xld3q657sg75bexy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 22, 2023 at 05:57:40PM +0000, Yosry Ahmed wrote: > memcg_rstat_updated() uses the value of the state update to keep track > of the magnitude of pending updates, so that we only do a stats flush > when it's worth the work. Most values passed into memcg_rstat_updated() > are in pages, however, a few of them are actually in bytes or KBs. >=20 > To put this into perspective, a 512 byte slab allocation today would > look the same as allocating 512 pages. This may result in premature > flushes, which means unnecessary work and latency. >=20 > Normalize all the state values passed into memcg_rstat_updated() to > pages. I've dreamed about such normalization since error estimates were introduced :-) (As touched in the previous patch) it makes me wonder whether it makes sense to add up state and event counters (apples and oranges). Shouldn't with this approach events: a) have a separate counter, b) wight with zero and rely on time-based flushing only? Thanks, Michal --xld3q657sg75bexy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZRxb9AAKCRAGvrMr/1gc jo8EAQCHso22KOo01FrMO5y8vuJbtEnROzr9y7VGM8DBcnx6QwD6AmbPbTKOMvE4 9AN5W+sZ+Ge4/lZ/E+DTn6TCAA+2KQc= =UQA2 -----END PGP SIGNATURE----- --xld3q657sg75bexy--