linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc: tamird@gmail.com, akpm@linux-foundation.org,
	christophe.leroy@csgroup.eu, geert@linux-m68k.org,
	justinstitt@google.com, linux-kernel@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
	llvm@lists.linux.dev, maddy@linux.ibm.com, morbo@google.com,
	mpe@ellerman.id.au, nathan@kernel.org, naveen@kernel.org,
	ndesaulniers@google.com, npiggin@gmail.com,
	Matthew Wilcox <willy@infradead.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH] xarray: port tests to kunit
Date: Wed, 29 Jan 2025 16:26:06 -0500	[thread overview]
Message-ID: <qdq4k6323orqifgzo7pbg5vakezr3gptfdehghxsyfrhc4kwvb@d4fxbwcl4gjm> (raw)
In-Reply-To: <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com>

* Sidhartha Kumar <sidhartha.kumar@oracle.com> [250129 16:02]:
> + Liam, Matthew

+ linux-mm

Thank you Sid.

> 
> Hello,
> 
> I believe this patch needs to be reverted for now as it breaks the
> user-space build of /tools/testing/radix-tree with:
> 
> In file included from xarray.c:11:
> ../../../lib/test_xarray.c:9:10: fatal error: kunit/test.h: No such file
> or directory
>      9 | #include <kunit/test.h>
>        |          ^~~~~~~~~~~~~~
> compilation terminated.
> make: *** [<builtin>: xarray.o] Error 1
> make: *** Waiting for unfinished jobs....
> 
> this then prevents the maple tree test suite from building.

How are grammar corrections going to the right person (but not the
mailing list) while an entire conversion to kunit is not [1]?

Does the patch really need to drop the module testing too?

What exactly is the point of converting one testing system to another
besides disruption of actual work?  Who asked for this?  What is the
point?

Is anyone doing work on the xarray running the kunit tests?

This should be reverted as it should never have been merged.

Regards,
Liam

[1]. https://lore.kernel.org/all/20241009193602.41797-2-tamird@gmail.com/


       reply	other threads:[~2025-01-29 21:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241205-xarray-kunit-port-v1-1-ee44bc7aa201@gmail.com>
     [not found] ` <07cf896e-adf8-414f-a629-a808fc26014a@oracle.com>
2025-01-29 21:26   ` Liam R. Howlett [this message]
2025-01-29 21:28     ` Tamir Duberstein
2025-01-29 22:26       ` Liam R. Howlett
2025-01-29 22:33         ` Tamir Duberstein
2025-01-29 23:02           ` Matthew Wilcox
2025-01-29 23:08             ` Tamir Duberstein
2025-01-29 23:11               ` Matthew Wilcox
2025-01-29 23:17                 ` Tamir Duberstein
2025-01-30  8:21         ` Geert Uytterhoeven
2025-01-30 12:51           ` Liam R. Howlett
2025-01-30 13:25             ` Geert Uytterhoeven
2025-01-30 14:05               ` Liam R. Howlett
2025-01-30 14:24                 ` Geert Uytterhoeven
2025-01-30 15:16                   ` Liam R. Howlett
2025-01-31  7:39                     ` Geert Uytterhoeven
2025-01-30 14:09               ` Lorenzo Stoakes
2025-01-30 14:38                 ` Geert Uytterhoeven
2025-01-30 14:49                   ` Lorenzo Stoakes
2025-01-30 14:22           ` Matthew Wilcox
2025-01-31  0:22       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=qdq4k6323orqifgzo7pbg5vakezr3gptfdehghxsyfrhc4kwvb@d4fxbwcl4gjm \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=geert@linux-m68k.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=llvm@lists.linux.dev \
    --cc=maddy@linux.ibm.com \
    --cc=morbo@google.com \
    --cc=mpe@ellerman.id.au \
    --cc=nathan@kernel.org \
    --cc=naveen@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=npiggin@gmail.com \
    --cc=sidhartha.kumar@oracle.com \
    --cc=tamird@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox