linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Jinliang Zheng <alexjlzheng@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Jinliang Zheng <alexjlzheng@tencent.com>
Subject: Re: [PATCH] mm: fix outdated incorrect code comments for handle_mm_fault()
Date: Fri, 13 Dec 2024 10:24:00 -0500	[thread overview]
Message-ID: <qby7q5ghatldakzgayxr573g247pgoyuz2jkytbcnvwhas3mla@nvc4whogmnut> (raw)
In-Reply-To: <20241213031820.778342-1-alexjlzheng@tencent.com>

* Jinliang Zheng <alexjlzheng@gmail.com> [241212 22:18]:
> Signed-off-by: Jinliang Zheng <alexjlzheng@tencent.com>
> ---
>  mm/memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index d9af83dd86bb..d7342a726845 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -6159,7 +6159,8 @@ static vm_fault_t sanitize_fault_flags(struct vm_area_struct *vma,
>  }
>  
>  /*
> - * By the time we get here, we already hold the mm semaphore
> + * By the time we get here, we already hold either the VMA lock or the
> + * mmap_Lock (FAULT_FLAG_VMA_LOCK tells you which).
           ^ lower case here please, otherwise looking for mmap_lock
	   could fail. ie: grep mmap_lock..
>   *
>   * The mmap_lock may have been released depending on flags and our
>   * return value.  See filemap_fault() and __folio_lock_or_retry().
> -- 
> 2.41.1
> 
> 


  reply	other threads:[~2024-12-13 15:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13  3:18 Jinliang Zheng
2024-12-13 15:24 ` Liam R. Howlett [this message]
2024-12-14  2:53   ` Jinliang Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=qby7q5ghatldakzgayxr573g247pgoyuz2jkytbcnvwhas3mla@nvc4whogmnut \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexjlzheng@gmail.com \
    --cc=alexjlzheng@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox