From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516FAC27C44 for ; Sat, 1 Jun 2024 06:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C74896B009A; Sat, 1 Jun 2024 02:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C24A36B009E; Sat, 1 Jun 2024 02:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B13346B00A1; Sat, 1 Jun 2024 02:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94C416B009A for ; Sat, 1 Jun 2024 02:33:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 201301C151D for ; Sat, 1 Jun 2024 06:33:56 +0000 (UTC) X-FDA: 82181354472.03.58AAE50 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf02.hostedemail.com (Postfix) with ESMTP id D88D880003 for ; Sat, 1 Jun 2024 06:33:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ll8GEtyK; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717223634; a=rsa-sha256; cv=none; b=KbrFJ9qZcmWi/niWb5A7gPNFqcfJEIKTmJPxN7ifCoQxOpJoTecO/RzdCeGRU0Q1AYYT1v b7kQCttWXlMWh+0bS9vHNW5YB9r3ecUw6cyd207o+ON15/1vup1vcU42IMV1P9sdg16n3T 4AEKsWMCH0hYQ9RleLlwr0zCletF4D8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ll8GEtyK; spf=pass (imf02.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717223634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EsG6D93BOxWJChAFk9t6t87YMq7GqVbu/s/KkXeOw6w=; b=2Q+pB0LRDFO0Knq0zpHq34IoCSlOaabgEZL2RZW6KXtInAXmFIR/oHsnaNADyILhvsWvpW 74FvmM7GPNB0Jxv/SbdIWmbUGc0AH8IGa6dEuV7sz1ITHXBuO6uv5IROc63FZkUTYDH/yb NYZfVPDV4L1l5Uo8t0BMbJLWdM/DaoY= X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717223631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EsG6D93BOxWJChAFk9t6t87YMq7GqVbu/s/KkXeOw6w=; b=ll8GEtyK/oRSIyPppRwO1dXJnpsrjRl+DuOu446eDo1KWJIn0df3nhUQKRnZDfTGOnwrkK fV5OEvdQzGHb9jTFv0j3DY1Q3yg7qLBMQ3fS5SAFzvNITLxmCYlm4otGFiRssOiMnB5YzR 7QVxtcxg/5zfgAs2EAmYGyEorrqkfTk= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Fri, 31 May 2024 23:33:46 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 06/14] mm: memcg: move legacy memcg event code into memcontrol-v1.c Message-ID: References: <20240528202101.3099300-1-roman.gushchin@linux.dev> <20240528202101.3099300-7-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528202101.3099300-7-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D88D880003 X-Stat-Signature: 5whu7u4fn6wiy4ds5wgisr97peujadp4 X-HE-Tag: 1717223633-52890 X-HE-Meta: U2FsdGVkX1/44XGU915BzH9q6LleVwLtvTc4zQdVIouNvjaksHj+LMAWCbo4r+cjAsL+lxklVf6OC9BbcQdVXtIkEYq1eKQbelWNaqE9LDgyFESFDpf6uiLavnY9HkExWRfOLZdZ2vP569coCAZGCCxGAjLlQXwVcBtWiH2cwDctDKioj/cNGZMCH1bCR+qwXNwDkBx9gdPOBGgB+Yo2bAlSNNLbsGPaQG/L6paVxCs5uYylsuczPOX8//w0h98+6cxOsZg1zSUHm0jmR8GGaQZXnijkj/z8EWsB0++pjCZlStmjHqbQmPOY2lCkcZk2wE9Cg+ZF/9OHdF06mu/1BLRgNgXrg6FeKXrk/UL6xylXN542vK8wlIxdeuWW2kku69wg4Vbo4IS0Xppc2X8TSqaUl7qyQxKaWVWz+/ktwdVFfaGLtZdGjCGZWVWy+sy1M6gH9z45JmcUgZ3GLaKb/7xea489fXO6Bo/D77a8thy1hRnWpdQA8Vwbsbc9DJ7Bd6k8GTaqvJ7JauttEnyUPI0VP9kejR9rAdPIswMOXu/BIEt0d8wUcmV581nnHoP4B0+FCt5EKvfhxm3BuJgWWSixgq3j7NjXqkCdy3SLu87XnsuRbS2nmkObsLWpmkDvvXViB7jK30mE/6bpD7whZFSN5JrJ4ftNjpbzQloY3Slb+3xKqaWv81JdNWZf+8n6+I41Dzbam2UFK+nIT2Kfq4NKnCCcT8Ur40NSgBIhb+Ng5GVGSdeHUl9LJcvMQ16wA1mEX/PdM07bO+aNcz4k48IY0+P06gvAeO86d5lhbTcAkd383koNIFn1OqmO3HlmWWWMOix5BmygWc1Bo/htWqMe7AT2mz1AXtSkqEqDbPnmFFKVDW1T+ZtKXhkTLZli+pliZmPjtX56C/wDghUN/8bYAk7jic0JuZW5XbtOWo0+hmiuIbyM69nww/6PkjRslvWm8MVF1KYu6ZfzhMm /70/ooC0 2Eg3nqRiXqugpRYlD4ZIMw8e31UNrWLTcMZjKK4gOsKcjGSBLYFoyWVGDzvNMnYjMIc9jUtwJzIHxOoldxc1NUmvN5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 01:20:58PM GMT, Roman Gushchin wrote: > Cgroup v1's memory controller contains a pretty complicated > event notifications mechanism which is not used on cgroup v2. > Let's move the corresponding code into memcontrol-v1.c. > > Please, note, that mem_cgroup_event_ratelimit() remains in > memcontrol.c, otherwise it would require exporting too many > details on memcg stats outside of memcontrol.c. In the followup work, we should decouple v1 only fields from v2 fields and then we should be able to move mem_cgroup_event_ratelimit() to the memcontrol-v1.c file.