From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 974AEC25B7C for ; Tue, 28 May 2024 09:06:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EBF06B008A; Tue, 28 May 2024 05:06:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 273E26B0092; Tue, 28 May 2024 05:06:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 114F86B009A; Tue, 28 May 2024 05:06:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E37C06B008A for ; Tue, 28 May 2024 05:06:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 775B51C0200 for ; Tue, 28 May 2024 09:06:06 +0000 (UTC) X-FDA: 82167222732.16.C395823 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf16.hostedemail.com (Postfix) with ESMTP id 7FE34180002 for ; Tue, 28 May 2024 09:06:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LF5amPYU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716887164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h9GBjGS9fFbW/fU1vLeGXiJute0gIkIeWTpDiyJ3yp4=; b=3j+RMwJoOA58vRcifYEF3MrvbKQKfmFNUJH1YUBG8swGdg1VnEbrJUaFGajL9ewJ000lrB cPrsyXHwn750GBjSwbo06WvN9Y5TrWM1MIM2tpMGKR6aQ/vYMtoG31disvcAmcNRO4Zvwt A6QelQ6KTVWyFZj3pfundt2XoRZAzLM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LF5amPYU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716887164; a=rsa-sha256; cv=none; b=222OWuPD1HmesuYIW6j0nIde665G19Ix4PeFAK9Gt8iQ9DIPi2ly3dsNtdErrgfFCDQDLu zFRWlqRLvFqsHEbuUl1ha5A1N/BGF1BkpCqXZaY2sUoNk+uj/hcOqtAthJAHG5oUL9aaWQ KESo1ZwpMgvI2rNAiYSQsVGQq4QZxik= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2e73359b8fbso5886061fa.2 for ; Tue, 28 May 2024 02:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716887163; x=1717491963; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=h9GBjGS9fFbW/fU1vLeGXiJute0gIkIeWTpDiyJ3yp4=; b=LF5amPYUQm5MD2UxrWCfiFJJbbEM0wfyn3hnQZoFldfu1yal6FxgvokNP/+tuT6/Fk 6YsGTMdrp8CZyVf5uC4TwGIjxVA8AIEXfymv+J3ZhUYGNnjcDJ1BYPFGbMl9nCgSYa9J W147A/wYyZ3ZpaEqPmp7o6fWjKnHvAE5nnrU06RFtURPAX4H0tyQu5DVzKEdnpsIPlV/ X+ANuWPnP0iHqEXYq4pD2ay7hnd+yb/i7evWGqf2vc3JxmlPIJ4f5ZjzyhIUw34DQXyR fRTvllxdsZUNfx9DtBIQXalDkL5m2VVQsyJKgUieLAsFT0QC3IavBR02b+D7qeVQutvj zFEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716887163; x=1717491963; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h9GBjGS9fFbW/fU1vLeGXiJute0gIkIeWTpDiyJ3yp4=; b=SwylvcVQbbjJH2CE16vE1oZbMzA3vVTKcckOsKUFnEdCbkLIgmPol31Jl5qjRegzcj 1AsphDwaNF0XyGw9B2+6iV77V7/DaHbeovGNxfXrPeDjHL1K1pSXM+D1dhIhWWuxjmSP 9t52b+XwaMHrrRQC/6IGbWJ/Yl3zIrpHNkuXdOTWQQvBYxBWctOMk8K2X7NZWp4SFZtQ +ZKfUc0BJSZkfjUKZWa2cbxXeO9pVFFVDTklSCN2wQd5n2eGaKq7DZ/+UFqEz03SEZum W8UUkFb/0pyY6cYKJP/D0CS1gaT94f0R1zH8LoBBl6QXiqAYKzE6lnWzd+KHVRLrfNDu fOVw== X-Forwarded-Encrypted: i=1; AJvYcCWHWERasNK3VD/z1TGRsFntaoZ9AbvEBKDJGTIdmCBBcPYCsBACCKkLHCQPdCYVc2pMdJ5BGauu7Hw1xJ5frhQ6q9U= X-Gm-Message-State: AOJu0YyyYs/jgwj0YAR5N1mejXn5uEly/kn7X6tYUrtr7LcVRD8ze2pQ LOwBSN9nele+xHMzgJC6I8ebqATfViQ7rV7JCpo7Dk9JALxTcOQx X-Google-Smtp-Source: AGHT+IG7IJ8KKtLK3X6nQm3e0XhIyT4vFHu2mAvltAVPSuRSDVnJteTvWHRuSuhAbrSXJaGOw8GA5Q== X-Received: by 2002:a2e:9c94:0:b0:2e2:a85f:f222 with SMTP id 38308e7fff4ca-2e95b042c1dmr111346181fa.10.1716887162532; Tue, 28 May 2024 02:06:02 -0700 (PDT) Received: from f (cst-prg-92-138.cust.vodafone.cz. [46.135.92.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3557dcf06dcsm11212668f8f.106.2024.05.28.02.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 02:06:01 -0700 (PDT) Date: Tue, 28 May 2024 11:05:54 +0200 From: Mateusz Guzik To: Dennis Zhou Cc: oe-lkp@lists.linux.dev, lkp@intel.com, Vlastimil Babka , linux-mm@kvack.org, ltp@lists.linux.it Subject: Re: [dennis-percpu:for-6.11] [percpu_counter] 05dbad003f: ltp.getrusage03.fail Message-ID: References: <202405281421.127ddddf-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202405281421.127ddddf-oliver.sang@intel.com> X-Rspamd-Queue-Id: 7FE34180002 X-Stat-Signature: htkkhu63ghewpfdsu4obsy111ngqw5gt X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716887164-779537 X-HE-Meta: U2FsdGVkX1+UISIXWh+JKlCe+MShXyEzJWJB9AqyV4JThcAmFUQn4Qk014l33u+hDxBaINlFvXQq2MnG60iNWrDBqb7NIfVcMHemfPsJ9zsR9rzfeL5myHiZDWdv7fTrEZjfams6Kdmk1fGZY99+KLnBTA9AKrxr+Rl/Pe4Y4KvNfHshTbHdOHKbPO4M3kINMeL9iVJz2WxradSGN78BUhNPiR4ejrspcrNT942nt0ckDXMtXmm7MZpkbMSuPHbkxWwC/9Dp84q2dzLmvSILzKP5TrzF1fgFr2qVvrM6V73Gaj14Ee+Ch0y1IKm70jq8dWAdb0O/JEEKBCr/Cc17P0/P0xjJhugJgdb6UtjsC1p4RHPcfNYe0TudPssGX5fOqR4ISIv9qCTPejzhpPKI+nGpgM9Q5rg/L7xyGHU1x2y8XExhCB5Axl/8+9TyqX2D6QlSI02ATg18qbSmJBR7fpNQZXCYuktfsaU/4ARVvttshL1RRtIO7JwdqqjaI4wvPa0phG+6F7BZnQHT3veV4Umq3qF1EZuoUdRUNf/STdk8cFi9+ojqVlO0NAQRr/k5Agz4g5pBU/GGPKtnNiIvzJd0voyk/NS9P8YFIBWyyb1SVr+E5tHJBCUg4Mc9S8nq9jwbrOY8frZuIzUEzf5It9/Hv9eZG9wuxakrCCuiJFT94EFpNfvdaRqyzX/wCe9slC2EEaHp6Muo7xpXRBY6R+3GNiGO2UsFBdM7zYbxqCFEb5HPCUkwAjxohy4CRg/a8ui5raXxQ+zcSDDATr3yPP39b47lajDMUA7S3fMMLzJLqJIBy8de25nDX2fD7NDhn55hL5sbqiwfYcnk16q132m0O9ZkeqyUW+KqfIPISeoibTR449tDEYzIzmXUmBOL73NfFf7obel4vNWZE8XprZ7BlWTCK4jl2MElVUfQkZehcOA2kWwD18KCw2xH2ZiXwWqcuh8ZI1PxPsecEAl aJ4V22n0 m/L4UAMvX458V65gJnXAkOgag07N8z0dWsPo7kJaXLNgqvYenbZQfeP48D9JXR8NRfyAddz6w57tQ0OI4IUeHesm3lpqG+u6OJbXsYD9iLf6JSK029UvhUpwd+PN7FrQeUTrkRRqfEa9Y8rVJXQuQVUIr3Bcx8Im6WNmQncMhPmTwT7vCfVnfWNgB5x/ObSYCnpIwatRs2lIHuYjfZmLmyyvBib1uMQ6A4ixtb9vwFZh5KcD4FDcNpSTDRjseLd0vrDyW1ovGe7YauWfDySz6/hH+OkunJsqH75IewCprdANKOhpVHe5YxmWQDrL1Wn6s9RZxGlQcuiMpGXLQygcG+sJeprTUZGBgSmSMMK1faN1Uq58pmU6yQTE6QJKO6jqRg7MRpbAxNvhWQE0Bvn655CID2kXfNHsU6bJfhGQ4aeFYNnaNGUxa89+wBHlXrc0WH9ohcgS7IbYCu/hZR21Kj9kfUGXYj08tCQNcPVhblZlvg62juI+DmixOAf8Cd79JoPCMZHl3rPgPt0qMLsTWiR2KwXTtJ7Zvl+bt5bBdpHxKk/ZBfSf+O/z02A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 02:45:35PM +0800, kernel test robot wrote: > Hello, > > kernel test robot noticed "ltp.getrusage03.fail" on: > > commit: 05dbad003f2b2ececb1cc7428bfa8f470cc34b95 ("percpu_counter: add a cmpxchg-based _add_batch variant") > https://git.kernel.org/cgit/linux/kernel/git/dennis/percpu.git for-6.11 > > in testcase: ltp > version: ltp-x86_64-14c1f76-1_20240525 > with following parameters: > > disk: 1HDD > fs: xfs > test: syscalls-03/getrusage03 > > > > Running tests....... > <<>> > tag=getrusage03 stime=1716734654 > cmdline="getrusage03" > contacts="" > analysis=exit > <<>> > tst_test.c:1733: TINFO: LTP version: 20240524-4-g22004c7db > tst_test.c:1617: TINFO: Timeout per run is 0h 02m 30s > getrusage03.c:43: TPASS: initial.self ~= child.self > getrusage03.c:59: TFAIL: initial.children = 0, expected 102400 > getrusage03.c:66: TPASS: child.children == 0 > getrusage03.c:86: TFAIL: child.children = 0, expected 307200 > getrusage03.c:104: TPASS: initial.children ~= pre_wait.children > getrusage03.c:114: TFAIL: post_wait.children = 0, expected 409600 > getrusage03.c:133: TPASS: initial.children ~= after_zombie.children > getrusage03_child.c:57: TPASS: initial.self ~= exec.self > getrusage03_child.c:62: TPASS: initial.children ~= exec.children > I confirm this patch broke things, thanks for the report. Make sure to sit before you take a look at the fix: commit 6e8b4caf667fb6fad1c63b061e303faab6d917ef Author: Mateusz Guzik Date: Tue May 28 04:52:10 2024 -0400 lol diff --git a/lib/percpu_counter.c b/lib/percpu_counter.c index c3140276bb36..51bc5246986d 100644 --- a/lib/percpu_counter.c +++ b/lib/percpu_counter.c @@ -97,7 +97,7 @@ void percpu_counter_add_batch(struct percpu_counter *fbc, s64 amount, s32 batch) count = this_cpu_read(*fbc->counters); do { - if (unlikely(abs(count + amount)) >= batch) { + if (unlikely(abs(count + amount) >= batch)) { raw_spin_lock_irqsave(&fbc->lock, flags); /* * Note: by now we might have migrated to another CPU Dennis, do I need to submit a v4? Given that this is a trivial one line fixup perhaps it would be handier if you massaged the stuff on your branch. I'm fine either way. That said this really should have been reported by something.