From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B78EC3ABDA for ; Wed, 14 May 2025 08:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFF096B0101; Wed, 14 May 2025 04:51:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A88246B0103; Wed, 14 May 2025 04:51:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92A386B0104; Wed, 14 May 2025 04:51:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 704476B0101 for ; Wed, 14 May 2025 04:51:05 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 06AFFE1AA5 for ; Wed, 14 May 2025 08:51:06 +0000 (UTC) X-FDA: 83440893732.24.950ED41 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf01.hostedemail.com (Postfix) with ESMTP id C68164000E for ; Wed, 14 May 2025 08:51:03 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=u2ECZjR3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/l6f7NQ+"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=u2ECZjR3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/l6f7NQ+"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747212664; a=rsa-sha256; cv=none; b=QmDupgcmw2pg/6m7+SUUX36quYbkwqP1IuasesGAJYPM2HYX0aTzaOvzKLVNR58Tlg5N39 5J1TrpUeqZX86qws76SwTE02Qps+rzEJxxBsrKO5J3G4csyOC05UjlkZdd1lRErF0lUXom X6X8ruBJaOjOi8TtRNE0gmwNJCjfyUo= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=u2ECZjR3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/l6f7NQ+"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=u2ECZjR3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="/l6f7NQ+"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf01.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747212664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1U2ujuZD1jkB0o1rfSCE6ebNEMGjdZEJaT7dHDxjfSc=; b=hIhOf+nTRThW1clUsXqMJWAfAzZqwn82IJfAhHecE6FdDZWCtM8swzM7hrK6OZ+Mg2QnbI BVsXx48TMzJXuZlL+N99333INpSkPYiB2aCH5xBkRsr+7UmKhZQjSaXqyCJ2LWsohXSBNs 3WIr87XWIbiriqXh2UCAgeuzv08jT2Y= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 24EE021201; Wed, 14 May 2025 08:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747212662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1U2ujuZD1jkB0o1rfSCE6ebNEMGjdZEJaT7dHDxjfSc=; b=u2ECZjR3e1UIcJ1Cl9Ch3q93M8Kx/H21EsXRySOh8CWj2ha8JXy5U7SnYYD0MZMeyR+K6w cbuPP+vVecZKcD+pK9fzOupcrXTUXfordU3SSI1c8b2rgkbN5Jx6uoU2Z8jFZDmVa2XIF8 3Tv8oOQqylZkteqzE122GA7qUtFhV2o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747212662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1U2ujuZD1jkB0o1rfSCE6ebNEMGjdZEJaT7dHDxjfSc=; b=/l6f7NQ+h5DrDRwc8EAJztzyphVOW4AYnVxcluu0qZsoeBsj6D+fyATUejRNJKT8qgF4l1 /9DsX0OFaPZkJnAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747212662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1U2ujuZD1jkB0o1rfSCE6ebNEMGjdZEJaT7dHDxjfSc=; b=u2ECZjR3e1UIcJ1Cl9Ch3q93M8Kx/H21EsXRySOh8CWj2ha8JXy5U7SnYYD0MZMeyR+K6w cbuPP+vVecZKcD+pK9fzOupcrXTUXfordU3SSI1c8b2rgkbN5Jx6uoU2Z8jFZDmVa2XIF8 3Tv8oOQqylZkteqzE122GA7qUtFhV2o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747212662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1U2ujuZD1jkB0o1rfSCE6ebNEMGjdZEJaT7dHDxjfSc=; b=/l6f7NQ+h5DrDRwc8EAJztzyphVOW4AYnVxcluu0qZsoeBsj6D+fyATUejRNJKT8qgF4l1 /9DsX0OFaPZkJnAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 310D8137E8; Wed, 14 May 2025 08:51:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id G6TeCHVZJGimHAAAD6G6ig (envelope-from ); Wed, 14 May 2025 08:51:01 +0000 Date: Wed, 14 May 2025 09:50:55 +0100 From: Pedro Falcato To: Vlastimil Babka Cc: Lorenzo Stoakes , Andrew Morton , David Hildenbrand , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox Subject: Re: [PATCH] mm: remove WARN_ON_ONCE() in file_has_valid_mmap_hooks() Message-ID: References: <20250514084024.29148-1-lorenzo.stoakes@oracle.com> <9b5d232e-7579-42a9-bcbe-a4674bf76fe4@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b5d232e-7579-42a9-bcbe-a4674bf76fe4@suse.cz> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C68164000E X-Rspam-User: X-Stat-Signature: ntgmb7gytfwbjusgoue6jsmzjh49aqpo X-HE-Tag: 1747212663-406204 X-HE-Meta: U2FsdGVkX1/9z0MFJpyTEbHg4zRlnmCDIvnDI9pzHpVb6DDFmIEd+PdiqsKbhfQE4CQdlXBvQ1lZs7+up+7o97BwfoR2F8j3H0B/M7wO+gL6bUaLc8h7OQUGz43wI0SV5HJaXKExb8cOEETTtBgMc7rAKnof9d0fBg0rIC4slyu8FKVMwoYXnkK7ovfJnGIDzTvnnSRigWfMIWo0okSQR4QnSd6wm7ZkBg8OcZPpXvNBDExKyLN1+OWiRuSEIUbANbiGvNrokLVMoD+mHsBZ26wrcv6UaHTvCVMe412Aa7iiey9ljDw1kua3/xb3whyABCMQNEr5PgubLc4VZyZk5lwPqjbIecpHF7N4pVRd/zlo4GwnzsrL4PmHXzu8Qq3tBAx6oIOYGTGeSGUcz1sK6SMiu7wemjRJkvYND/aOq3bUmu+i/ILRa3va3lW0/36bBx6c4PoyRoM1LDNJ62/A6bjgaeSzkn3TBq7tHDR+CkKZ1S3jMqz317JJzw1tp2/2p25eH+ygGq589415DU2YUiAA2N8YOKqM0X/GIMQI4mglPdNBWO+RpM4esaqGZ9GZBMHQ08ZNHNQQwXmn+UTBtXVJO4XvV50pI3D/lVnsn3ARYOIh0SjHUoIu3T/FAEPjwWpE80LwZnqp7Ff+y9B8yUOSpDwcl4pzfIYGWZCz0ielq/vemmbub+QgD8b24VgsBkp/IZYoOcOjW7qZNFMhUL7wTOcPKNOQJc08yiASKSkmPBmRnun5t9/vGtdXnnQRiEGSB8WUj/r0vunEO0miuSjZmspHryKCk/oTzLCAvuuzoBo3vAEpqDCohApZikpxHhfB6OWWbBYnAYsfrTTxIBxQDpwmNaQqjauFVHS238e81kVyDgofLrrsSlY+WkgrVxXS502omlgnVWZ0H7/DUG7YtagbLLA3QeRbslL1I0mkRr3pWrM+q9ITAiGBUQCJyCUD6XsSVxMdhKZekNL Q0fi8O9e DSRfG3P5dV7vACwFTuSaZH5IIQ+URIJ7PaiRltqrGPHjy484Mc13GJ3yvZQ7RLT5QeSXE9Iw++Laa3jDvKm4A0axIDTCsqnSpc7c1dFFea8nx/uk3kuXATdXZFbEH8MrgCMK5kARAAT7FYYTj+Eq6Vo5plNg8SJUBIIqRSYYqcVbpnFzpx1CgJssYSrO+C393Tg7VucbEq9Ts8b7JyhK5nUIPvfaiHWTk35tCj9daykH5DIJ6SrvBlsLPUlJeUiks0V972BUeQz0XRKnul+DV7Z6yIEQRmwW8PduW4Vjchl7GD5Sg0QvAAk2YQziWk2Z3woobMxFC+9uxwqV/qNwQKITnZqAPc3PSXqM1Pubh38KutfQWnjTMGn2QXdPZfRAiqOShJgWXirdJoB/5sQlmXmaDBkx+RcQqUAnjUsGSR3WovCI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 14, 2025 at 10:42:53AM +0200, Vlastimil Babka wrote: > On 5/14/25 10:40, Lorenzo Stoakes wrote: > > Having encountered a trinity report in linux-next (Linked in the 'Closes' > > tag) it appears that there are legitimate situations where a file-backed > > mapping can be acquired but no file->f_op->mmap or file->f_op->mmap_prepare > > is set, at which point do_mmap() should simply error out with -ENODEV. > > > > Since previously we did not warn in this scenario and it appears we rely > > upon this, restore this situation, while retaining a WARN_ON_ONCE() for the > > case where both are set, which is absolutely incorrect and must be > > addressed and thus always requires a warning. > > > > If further work is required to chase down precisely what is causing this, > > then we can later restore this, but it makes no sense to hold up this > > series to do so, as this is existing and apparently expected behaviour. > > > > Reported-by: kernel test robot > > Closes: https://lore.kernel.org/oe-lkp/202505141434.96ce5e5d-lkp@intel.com > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Vlastimil Babka Reviewed-by: Pedro Falcato -- Pedro