From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF30C369B1 for ; Wed, 16 Apr 2025 09:26:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 287552800DF; Wed, 16 Apr 2025 05:26:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2353F280001; Wed, 16 Apr 2025 05:26:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0607A2800DF; Wed, 16 Apr 2025 05:26:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 333B0280001 for ; Wed, 16 Apr 2025 05:26:04 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A17B6803A5 for ; Wed, 16 Apr 2025 09:26:04 +0000 (UTC) X-FDA: 83339375448.19.D16A737 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf15.hostedemail.com (Postfix) with ESMTP id A2A80A0004 for ; Wed, 16 Apr 2025 09:26:02 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ViYG0Ntq; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744795562; a=rsa-sha256; cv=none; b=kgurVb6DOzojwzF3FDH7gcVqxIQd8zlSKDt6J+E9OyE+2rW1vtayH4GDpJaMv+b829hiep 4fQapEo8EPl7p7Iig4e4/Czhk/mdAqROlPeT2Y4ZvUwJ1u1TiVU0V+DZqthB+KWSwryFU7 UjasOFI4cQ3YVBKXq7lDIchM9lMxis8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=ViYG0Ntq; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744795562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8ri2FPsioeyOMpww0lEYWXKz/xcfTIJFn+R/QcNtid0=; b=mBaakU/QFlihpzddJb875AZ+zHYHjp4lGR9Nm+Wul+OOfMC13P489DRH+mi3aBtQI641yb etqfdn2FLXRx4MlNZrgCUY7g5WtFkEDz1eI9HVQj5MINOjPx42NXX9jDTVbv7915XwHuL/ iHvhAfslMBW9lgvFHclFrdS0wbl4laA= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3912d2c89ecso6168764f8f.2 for ; Wed, 16 Apr 2025 02:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744795561; x=1745400361; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8ri2FPsioeyOMpww0lEYWXKz/xcfTIJFn+R/QcNtid0=; b=ViYG0NtqClXzHGQOyyT+PTTAJKI33Uew7ivkKOmW6BSBsGqQiucKh/ijpGBb1YSgDY SEqPdxPI4E84ddBxQMJ7jbD+JToPZcdPnAWxCS58shFYyEjUDW66OujAlLS8oC6kYf01 /mDG4eQVzHWSFxP3YFJXpZEJ5NZxhHHgF9PvQAxWurgCWceXOuMTRcGtTXEZWxvP70+/ mXqLOAOfJGMBzL/h/dmtw9HfSzdwJ1VWJwKsQJT558NUdJ52WUhY7LDSgi6ADp/s+vkI UwYHmmKL22peEOz/+4iRFwikGmFxiXlXa/R75Cds+dmEqtoeZd6ArhBYCj6GlSyO9BAo M4aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744795561; x=1745400361; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8ri2FPsioeyOMpww0lEYWXKz/xcfTIJFn+R/QcNtid0=; b=m4pxsIZOkXq2DC+tI6fl5+lK0SZjHX4n5AOotH068kgC08vzOkVIRg1kNOuG5S1T6G 1sZ3xwAidoqqwcntEK6SrHamXFYjCcAAQXysX1Bn3KORbYthFSa9gF3T82i6OkwX6n+A MuxL/+W2fg2r/mLq/6OZwSdY9/nhRVPJLErZWRPQt3cz//zcGFtIQEr5SAiSHoPwkLgy kS+mriczGuCg3QrlcF/8vLdL6akA4+iZ7ekI/fAw+I+yw3KjrpZ0WHqCNvPbUMlw4NG1 BMXSWkATR5eXW1LXts9wa60Wt5KhVwiTcTzwaMGOX5LQHqfaR4YQoBBBykK5sh8So9ee 3wqw== X-Forwarded-Encrypted: i=1; AJvYcCWUmc2OpmjyDKdkVSH9Arh2riuHYZ2TuWWCWTlt3SOs2uzo8znmV47GVHJEBcbfeAupvdBvjIXi6g==@kvack.org X-Gm-Message-State: AOJu0Yz/De1WafmaoT9CcBR7x4f9jQS1fTLzLGD4RcnWxinh8YCnQB1A Owf18iq/9Z5OauVCzORGp13iryU1U4iVmonK2CWok8OhLJQMxihd4IHF7RH+WI0= X-Gm-Gg: ASbGncsrEpjAUY3UqHUKzMg/XAskqSVg9ol0Xje8+kcK5GR2gcQ2L9Hrtrspt448zvx wdNl+RZ0/XUQL9sOU9QAaLUIAnjV7qJPjqRFlSpkWF+0YJybdtYhqUaSrGJwuLhZITj6DIP3bp2 Rw3pV3lprRtpDBCtX6kmC0gf9BtSrXnDy8d6MT7h/50peZ7V3NRDV5vC9+OJoY4KPuqWwBu/d8B SQgr/xxHJ6xHSK7lDRngnJfq8TllDC/UGpuMF6UJWWJOEupkIdwrSRsU562GyEjzaeiuTyCEmal a3Wr62plaeMLRX3NAOvYQidJHqnEwi9LlskKeJc64n8= X-Google-Smtp-Source: AGHT+IG+DNt53Y1tj1r/NgZyeW/D6nAONrAJfUbDPzr4B6m4A9eSNWJlFy6wubzxu2mVoR+YMUc51A== X-Received: by 2002:a5d:6dac:0:b0:39c:268e:ae04 with SMTP id ffacd0b85a97d-39ee5add7admr1016490f8f.0.1744795560990; Wed, 16 Apr 2025 02:26:00 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43cf42sm16763741f8f.64.2025.04.16.02.26.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 02:26:00 -0700 (PDT) Date: Wed, 16 Apr 2025 11:25:58 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v7 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on Message-ID: References: <20250415210415.13414-1-longman@redhat.com> <20250415210415.13414-2-longman@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="w3npzfkwfjuaenbx" Content-Disposition: inline In-Reply-To: <20250415210415.13414-2-longman@redhat.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A2A80A0004 X-Stat-Signature: mzyuo5z1bgjxaoyxrsn1fjf5wizau3ir X-Rspam-User: X-HE-Tag: 1744795562-250451 X-HE-Meta: U2FsdGVkX19E8KGNLeoqmkKJ4rqqk1LifdY0wf3fzN9k5FRdpy02pFjWQ58HTOxFtTbbRflVtmtwaXDr457sfkjCVtDIiC503K3LytpWRncFkdNlB/2D+EHtxUGylCT5/BdPsKnnGLGh6GXyBbdLjp1Uz9NYE7FT4tnN1zRbX4zsH7bI0+rbCUqQqACNEzxvQKUZK4wi8Fb9pU2bw/Bm80dE8f3/NnpB2CTjqs+CSzOfIHADEbOu59yQhChnD7ByJul66GxcsHRm4NNXGykYBQELSDbct4Td722IJ1TU/VvIOvdcs0UxzsfUdMnqKSlv1qNsLaVixFOMu03Juqldlq0+hH5w+sJtNKkyQN/IyFuoMpj2UmKmNuA8+vk05EqkETxoefFC/yECbqwcRXCo+cXemf1g1KXFxTB4MuexxZ9sJlb/LkTxAKF5zbG2vccA4vLuHEMzJRIwK8NPGB4ZwfNxZuNaoMm72lYhyadv6mU9GqWr6nAI7T57xLIB9JlMuwvX2unv4LcK8z1uLLugqQE/mJV/rjwT73vZ3JQwDHfIuqQl5m2sL7i5R8dg+xQqovgLxYycPU40eWkSlsvtdMxGyCckwk0LfQqrvZP/LM82QXTpiOt3jG8Dul7Gg6tJOVQ8RL94jLEoNDTWA9E0TcVK956PQlD7sVzpfCxF1DxZ3cWyNngej2hwqvl0vGH2YEriBwHiaDJWL7+Sedpoat/3NISRoJMPggMjBKlipkt2rFopTSZolVPrs4icEijhFO+JUhFSaxm209i0rpndReTOmanOcnnVdIOtRyPiefGFUxbJQlz3/Kb4AyJjDvGLm3x+UZaeE0rclh2a7yasoK8sDiA/KRUGaG3WcdYi+jY25kpZFai7jrDD8yTaj864PIVJHm1492/qmdvO3t7cPZ8cnwIEgcjDi9gZT5SItl/rtBo54oGMAaINVfOXsBLhlKOfMnFg5NveHU8aCHO M0Q5NOwv BoMiUB+/EVSsEMPUQWQW3wOfT7zIsdESzBPKdscBDaRW1vR1qOnd/ZPx+ElixGyjsgHkPbwhfzigiitSuddJTxDn3uL5Ro9+uiPqANHQ1eQr6XfWkLa1ZwXBu1Upfu7WLvLgYUCf/A0dVVY0kcKWflrHs6K9+Jvtqo0u/1oIh10cT4FkdKEqH+EAdjvRKxw8USn+gbPFntg0LDFfs7oWEQtg1J7dnEjDmWGs+eZOSPDcoLWIaYch0PvgPVaG/rcWBjQKOzATN0hubKr1EyNYPbubQycicJ3JaClH0u3/njfeVP/dO6wVAqaGagOexFhInrNxy1lR+64l7p+ZEMxRLvqwL7E71NZS8o+SWuzrYuATdyrOpHrFItbkkKoIuvitpJZWZ0gGrBK2PlFoUHFn4bqvppTzs7BCLdv673lH5olrzgAwQ2KG9M+7cJY/KqqZGCsQeggOWAZOkfJhc4H1fbifExCq6ffYrjt+LyLmOnB8+eOxn7mn21wFi37/f7HP+bbt5ePk894nOD3mYvQOxQ7khlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --w3npzfkwfjuaenbx Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v7 1/2] selftests: memcg: Allow low event with no memory.low and memory_recursiveprot on MIME-Version: 1.0 On Tue, Apr 15, 2025 at 05:04:14PM -0400, Waiman Long = wrote: > + /* > + * Child 2 has memory.low=3D0, but some low protection is still being > + * distributed down from its parent with memory.low=3D50M if cgroup2 > + * memory_recursiveprot mount option is enabled. So the low event > + * count will be non-zero in this case. I say: Child 2 should have zero effective low value in this test case. Johannes says (IIUC): One cannot argue whether there is or isn't effective low for Child 2, it depends on siblings. (I also say that low events should only be counted for nominal low breaches but that's not so important here.) But together this means no value of memory.events:low is valid or invalid in this testcase. Hence I suggested ignoring Child 2's value in checks. > + */ > for (i =3D 0; i < ARRAY_SIZE(children); i++) { > - int no_low_events_index =3D 1; > + int no_low_events_index =3D has_recursiveprot ? 2 : 1; > long low, oom; > =20 > oom =3D cg_read_key_long(children[i], "memory.events", "oom "); But this is not what I Suggested-by: [1] Michal [1] https://lore.kernel.org/r/awgbdn6gwnj4kfaezsorvopgsdyoty3yahdeanqvoxstz= 2w2ke@xc3sv43elkz5 --w3npzfkwfjuaenbx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/93nQAKCRAt3Wney77B SVIuAP96NW0fIlvRAMGyp434RzkvtOGnIESFYbQyryMjDaf0FAD/SnK/QY73TkA1 aZVm14O+UjCgolPl/9j9t4ba0I+3fgM= =2iXD -----END PGP SIGNATURE----- --w3npzfkwfjuaenbx--