From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C268C3271E for ; Fri, 5 Jul 2024 20:31:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E8736B0095; Fri, 5 Jul 2024 16:31:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 998E16B009A; Fri, 5 Jul 2024 16:31:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C3CF6B009B; Fri, 5 Jul 2024 16:31:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5A5036B0095 for ; Fri, 5 Jul 2024 16:31:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD0ED1C0983 for ; Fri, 5 Jul 2024 20:31:03 +0000 (UTC) X-FDA: 82306843206.26.507711E Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf06.hostedemail.com (Postfix) with ESMTP id 5DF3A180007 for ; Fri, 5 Jul 2024 20:31:00 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=e3+wwjKu; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=NdNc+ANQ; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1720211438; a=rsa-sha256; cv=pass; b=c7w3ZYtuq9KSYc3rg/gqhHj6KsvSQM0naYcIb5k1tSSt8lafO8RNxLCfn2C12ob+B9Y1ix brmR5odAi4otOwnU7wsFL103P8BxWBeBE/b8r9jy9XQmBi88Bw8sP1V/FszpbH2/ZFAzio PcMtfR9wk6P1RAtsvR8DowPyM22cpKA= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=e3+wwjKu; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=NdNc+ANQ; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720211438; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jyug9s2LVPFHesaOgzNPwXS0MQGmRa/V5lfG2/DM5TM=; b=2y7LY8ne130YnvQG1TFTgURNa8xaZcqaBRZ1FusrkHDOimd1ZXVyIySEWYKspJmm8ADfNW 6SiXHPF74pffI+EGFSmVhYs5at/ljGi2Mt2oNEU5NoyMMtCSzwR32ukn980Ss6ZOH16l0U hTFmxHRsojeq+dbcY6uGOL/9UsRNMmo= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 465K7Zbd030301; Fri, 5 Jul 2024 20:30:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=Jyug9s2LVPFHesa OgzNPwXS0MQGmRa/V5lfG2/DM5TM=; b=e3+wwjKuy/A/4HdtWXoBH2Fkh+tlP0i wvd+GCYwdV9G00mYMb11xzYwboeRronZ5AOupoz7O7zIXS+RKGwVfSrDVhiEsEL7 Z/wlj3h28xZWrdZhyJd5BplUT9Hsl8s3Ol/F9H3WuKF5wGdd9MfwzBKQr1uqKBTC sws/WUuxlMrVOQzq7mM3BNzzS7OwGuEXAiLZHMZgkdna9+EGsTHDA487NHcpoFJv DzAi4LZUmy19r4fBRYjsTEk+aO0lC/56j53Ga1RY2mb8DLjqKeczrXTt75EOYstp PcR0Dv0FLcmtDis1kbdWVUPVPdlm6V03jxYPmtU6hPu/v6CL5VnqtVg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4029vsvd2v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jul 2024 20:30:51 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 465K0m6G021527; Fri, 5 Jul 2024 20:30:51 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2041.outbound.protection.outlook.com [104.47.70.41]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4028qhsp31-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Jul 2024 20:30:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aOuFZ2LTyWXN/yCObM2ORpNrFIwo3Ut4zOHRWfEnhkgYr+unP+36bm9TgUOCXrkqe5Clvom/+DvieNb/SE0vTnPAI6Jr3aJsgWshut4vQhYvXUZ5V6UJQEum0xA6zDonzg74gFHrbaINXwFmDNSuqB7oxiuclAL8rFQ+fDN5xAdPsgYghhURbrW7/zV9V6wwugXFnNuFZMoOzwAVbQSFlttBBAl6NxANBv1/8z/dd4oBg+Kmx1sLYsM/bHV8oSmgUEuamBVlpDtm3UoJSC2Emd5ZVXTaPgjFBwtuxorpzqpOyvglCqTLyfygFzc8MhpmCr6dvcI6F86PU0qNl/Plew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jyug9s2LVPFHesaOgzNPwXS0MQGmRa/V5lfG2/DM5TM=; b=e3DBnFV9O2I+yIW5HDDvmiGXsFQ9NYRVyDmQJPkFaqEt9X2JpX0NIoa71g8KwEUTdvztf47LpoZZ1lWNB1Qp+pLvr6ff8bt2xW4sulpnUJOpMxzFkIogYj8MZuEDNWBCceQ4bgTghUwtNrId9mr9XKegP+V86eFTNkxOPdVWo3VWsaLGNDeo9huJlYZjx+5vgX0MyFRI0O3222y4+LssUypiMKPvwspT7vTQdzHbHZ/IpqmKBHqKlQGnGQu9vlLzKbI8mFFx11uZAKKoWePOKwm4hii5YcY737WWQ5LIA14VWG+TrGhtNLc1bicmhX6/u2y4wJvDSrj0wyXINWPMkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jyug9s2LVPFHesaOgzNPwXS0MQGmRa/V5lfG2/DM5TM=; b=NdNc+ANQqEujHZtfQ1SleJuU240zCLa5ctdzDbyZybLN41ZDtPUfZPrfXLWUI89UKtd6g+SvcEmSqdfe+zXdcT6eDD/bZcNft2P+Es88DjWVIPl09Ztg5D1HpNw3z9x7v8uw47cb+KOc6vRZ3+xt6DOC/kBZAH2DMkLMYMFpAj4= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CH0PR10MB7412.namprd10.prod.outlook.com (2603:10b6:610:184::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Fri, 5 Jul 2024 20:30:49 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%5]) with mapi id 15.20.7741.027; Fri, 5 Jul 2024 20:30:49 +0000 Date: Fri, 5 Jul 2024 16:30:46 -0400 From: "Liam R. Howlett" To: Lorenzo Stoakes Cc: linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH v3 09/16] mm/mmap: Expand mmap_region() munmap call Message-ID: Mail-Followup-To: "Liam R. Howlett" , Lorenzo Stoakes , linux-mm@kvack.org, Andrew Morton , Suren Baghdasaryan , Vlastimil Babka , Matthew Wilcox , sidhartha.kumar@oracle.com, "Paul E . McKenney" , Bert Karwatzki , Jiri Olsa , linux-kernel@vger.kernel.org, Kees Cook References: <20240704182718.2653918-1-Liam.Howlett@oracle.com> <20240704182718.2653918-10-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20231103 X-ClientProxiedBy: YT4P288CA0090.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d0::23) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CH0PR10MB7412:EE_ X-MS-Office365-Filtering-Correlation-Id: d7b9b06e-87dd-43c5-d8e8-08dc9d315b45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?EVJgsSYHnGZ+pQvlJz5JNKqnCIrRZ8elXwjHoeKGw84D/AVPHKygtMWNqrgb?= =?us-ascii?Q?g/nC/LhBx9RDFzG7aO7txCwOmBkJu+0H8y18gWrggiL/buwBLFgMdbb/AeRg?= =?us-ascii?Q?2i6EucVA7f//Zb1Bg35P74GMbDB4q/QQbTqunJUorGdreNr9Q3MLfjxuxpyy?= =?us-ascii?Q?VHsWSVJEdUK1HYEVH2dSefQCmGQp/AfsJgBd4ac7ylh0Iq2qLslv3x8usAEl?= =?us-ascii?Q?Mub7j6ip0MTKhXZUxpM+x0nXF1mjWcpBPrI7bZLLx/otp6oxtyqrMKi4Ylw4?= =?us-ascii?Q?J8TayXw+0KJ0buCyxza95D2WJKyzzqTVn7uc1X1yohZ/64L9t7MBqDacCGcY?= =?us-ascii?Q?+55J5NuxG0ta1dJgzJQNce2DimSRObUfg3j1vJHk+PhQgKNtVSPj0RJdCiJi?= =?us-ascii?Q?CYxyrkVAAgwgMbz/6VoVHI8kCLQBa6jl42Ew7tCz92wKzQcoXU6b7EFZiQ2/?= =?us-ascii?Q?thr8m4VCteZM1xif7jC2epEto85Vg+Px33C/WWm/07ZUcamDS/b8jORN6+6W?= =?us-ascii?Q?0wsNXAP6CmDfgYX893sHlQ4oHNbCtZ925qUaeV30+E1VQeO+J6YuqiUX/+0z?= =?us-ascii?Q?LBdAi5nqTtzQr7WC0DUOMqAHMCAEFQknYGhJrGdfcJWCVOF5Q6nTJBCScUlA?= =?us-ascii?Q?sLstvBq0DF5YLI7CcHAvbVacsaCo43i2Mb248D4b52hcTQ6y+CmeoqFYOUC0?= =?us-ascii?Q?B4RM8crxRwlDivwAWCg2JxNPWSx95NG87eSQsRbwuyKKOCi3ZyqGI0Zlu0MH?= =?us-ascii?Q?4kPiAZbNi1h/TPxskU5I66ukWd88ZtncbZ6nZXyMMOwinQGuZlFY4HKGmPJc?= =?us-ascii?Q?Lo7vSicvdmYHkKejpoiMTxN5WcngSbzjA+3N/on8FoZDjMvcYBjYmotqlQrt?= =?us-ascii?Q?yUodo5GTtaUqDsFcroZaApyMOMu0Sb9xzLRPoNXmjT4uaFW2Nm+L0xA0vPqD?= =?us-ascii?Q?t3oa8Z731cUntKsmeOa4UiQuSDeumx2zXosg3zc+dXsvd5nlYR3tZ3i8lmcl?= =?us-ascii?Q?bPpUJGB2pyJBpPt6hfsMy/kLrJ5iPdoTh2oONUVlE1bsailc6kGdNGlZB6rK?= =?us-ascii?Q?QYUExmcr9JtsX8p8VsWIR1wUhVQVn7aDj9FdFeMWkoOZOd5/e5R2m2HFdxJL?= =?us-ascii?Q?5pg+Ro2KfVB5F4O3h1NqnAQzxyK7WnXcDIJpVGKCpS6ffHiIFNdC4KmamnSp?= =?us-ascii?Q?G7wMez1hx7tUgcA0wwvND3gOxg6SHjSh31WSVFCPbcVv4eBQjloXP7wDl3v0?= =?us-ascii?Q?6/Y3soYeBk+jMyzjb0toLS35is16IuzYQmz4qF/q3j1dtTlLXFuhBICA0E1i?= =?us-ascii?Q?sgUsE46/vT2bvi/O8+m8zNLJpNrsyKw7mjUGIexOnISszA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wxmnu/rFh99xSVSq/tkltqDE0uMyYsACSYIfwyg9PdRHa2/DBc8GSvA1i7kw?= =?us-ascii?Q?Xz7/Fakz+5Iz7r5YDLLAVFEa2e1nzhaZYuMCuqTIoyM6RaupQFuGpUbfQwiI?= =?us-ascii?Q?vB2zknez5UUcHaUZbmMz/YLotwyMxutJzwx6RtpVYMJFHq9gfEUsAg/z59/p?= =?us-ascii?Q?r5gPgGRCcyF3VrHLZnrr0D1gAuikLzOrI5xWtWPtY4+6E3Ef7ftuDnjvlFlp?= =?us-ascii?Q?hWtGMnzY8hdBPev7Lr14J70qm7CyEzkF0UO4nSGeBXZLQ2dOJfbJyY4soW6o?= =?us-ascii?Q?qULWyBRDNgrjZWw1O0Lvsm01YlRe1oQMyGpSQPWKO9vROH5hfAcZEjbDrnOe?= =?us-ascii?Q?BGEpCK72pyDr79hlLe/eM9K75Ojn1UQAbj9T24jbLTBgfE5GZPFm0HhvZabr?= =?us-ascii?Q?PDMuP3RnxpN0KZywJnkyuNUs049aK+f0xYy2Th3u+qYLQNUgbMnt8WOYiu5T?= =?us-ascii?Q?51akaaaIfrgAhe3PUAhS+nV8pyXbsfICO4VuvyX5s3xzeJklfph+x6UoyJhC?= =?us-ascii?Q?yHAvkhEzudgRt0nzx5ynwpyuD5+NcxfbzCTJzpQziqJYDJnQ9lvVjoD5CnuC?= =?us-ascii?Q?7x/vlrTB9wyo3wXGmf5eFjWjW/OYXYHM/7yo/6dvkzJB1vCsol1iJo2nvxHp?= =?us-ascii?Q?79M3rOZnfPfTsUFqgVVXE4KJzHiEmtBEyB27AVc7DSRx2Kjl3vqbk/RV2XSj?= =?us-ascii?Q?G040vbW5CS7JLwA1fm1zej12Q5qNGaG4dA3TGzuCKHGirRkGWUljXEtd3GUY?= =?us-ascii?Q?ZVKSXna+2G9v+2AD4ajcDcSBXEQb3RRbVRIBLLzEHawWmouWAXA0JMYpjUji?= =?us-ascii?Q?i2CB3nyoLuE3L1fh7T+PJM+usCjG8ZbdjDAFA290d1QG0yfYYCYPVX5ovGMP?= =?us-ascii?Q?/5XyHPEjWzM7sjZG8iK1CkxeLRAuL5x7mPwUY7hHX/++SnSA8WzMzTNj9ebt?= =?us-ascii?Q?z8uz2pSGXUajRnyS71dbvZ/rpOwI17JytEuJOkgOz4ZVzhSLkgSNibW9zosn?= =?us-ascii?Q?foNVvC1WQsad8+0EQ7qyf/ggzdSK3qW4Wg2psA7TrRla1dAumcj8vK0Fp9C9?= =?us-ascii?Q?hIvYv+bTPB6garJTI1B8EgJOkvM4qfaXzmgJpSmeTJmkOdCrklupqymn2c/6?= =?us-ascii?Q?bP2hhs2DlvmdqOmXFSofUnIVazvw6Yetb6dPGpX4ypYlbS1x6Sdg+dyCPI11?= =?us-ascii?Q?1KQL6jCEfXyX6b3je1Ie2N5WPkXSvSjbFAj/TKQR0ddgvsIQrH0N6Wk6dM5X?= =?us-ascii?Q?KiGnw07jMl+AjDv8iV8IoRLiXiGfvjZeyL0EtCV+akUCOpxNP/zjEyqco9lr?= =?us-ascii?Q?hv1WEltygrpOLefDdFGRzE2KHamu0nJvfxH1pPksAsLXDYBHMojcmuuETNQs?= =?us-ascii?Q?VDbFWM1XdOpT+BUwKDcLnvxOthtKP+aw1mZGRpaO2Rs2p/QvvRHkeHtx57uy?= =?us-ascii?Q?B/T+kiRlfzdNx2ewnO1t10VH58qC7f/Vq7A8SNI7WElQtW/2hybRy1QjrvQC?= =?us-ascii?Q?YiwDrmeWtfKA1id7EAuyWo323cu9tLBDAAWVu3ngdWYA8xjNjpH3YNi0qozS?= =?us-ascii?Q?m0aWFZYmuUO86XIt+HcBmNKIqqUpPzDBePCQhLlD?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1oFhJQIBbBmF8HLYuvKe93G26ZjTI/LKlQQsH36LO9YAk6eskRvo5DOE/NgqAqJNkiuWhhZ+7yQp6mR6mKuGjn/6/fG88aJgkwoc6xdZkJyeuWlkB79V/CBl2mgI/O7wg+YgylhPw+70NoAm/2YwqMZyFQQ7RHLvIcx63H99Vae2yI2iXbltOryTZqTL/nYDqAarmkgrZDRNe3wy7Pd76YA47JXyeyY9nlgphC3GNFtUTFX+KXm/xWPSXw1N+zS2JSO30NN2GSG68QpNAlsWfcMa2/K6P2tHtaXVyWqUKd+0Dx3y40r1p/6nCNxpzJZ+uV5yvGE+pHNzoqHyP6Op/J3f7wad75NNZkzCDYdVBJXRH6KZ680PyAK2yN1rOYSObojVPLf5l/zhmd01dGo7F1ZH2CSyGB7yrbLkkT1WTPwKUArWUwa5uu9k16wsQhUf2x7PRJuMrSckMkF1rC7dUwIZme4bNW8sb2f5wMYRhbtLGyLn5Gh5go7sIggSp6uyX0i9SpPylkj+jk+rPJB7FxUxgQYXb6TA1ppmVc0ngq/NPsNdSs62+4/Gn9cRic5mRE37LgLr0A2kHe9MZwAXWGK2BKuzg1DV5nzNNPCefBg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7b9b06e-87dd-43c5-d8e8-08dc9d315b45 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2024 20:30:49.1121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LDtWT3jnvaP13S/xMR9aVgWOvyy832Zmi9s2ZlZZjbz3givNm7Rsz/sTVndsprg7oP7IUQUzNoESnwEZRFlrEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7412 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-05_15,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2406180000 definitions=main-2407050150 X-Proofpoint-GUID: 0Jt6Q6hY6d6gqUL494oEEWkIXMxdyQUI X-Proofpoint-ORIG-GUID: 0Jt6Q6hY6d6gqUL494oEEWkIXMxdyQUI X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5DF3A180007 X-Stat-Signature: 83whozqh3ohjymwk948wdt4fbq3jpaoj X-Rspam-User: X-HE-Tag: 1720211460-11694 X-HE-Meta: U2FsdGVkX1+s5M35/umeDLr5rhUuwTbVRXYYnbUmuGxkKnpbjEF6leqyVAP/8vx9cOayfYvifXU4hm/CvDjdbSKpGBwz+HGeENqnXYjQaulaWfnoOLRN5Nkm5RNwc/MZb4/Bikqs/N81cpIjXUem/VuWQPp2g63+DWpgkYZfjMCBTmTsJcudOkaMslTKvoJd6Tgj2LYKERyz2KuJHte8gThljNjZzMpZBZA/+6M181k193SSyR21OMd5ItrMry/VgF32+fXUtfws2dmC+eftmaP6V+dqFF8VZTdNkxvsSQKHJDyZA9+H4uGK5dKM/WC3sjAJamxYPJqNS0o/foi4UZ9hdGmDaVRWz6R3sF7NpOK+fKtufP2uSd4Pb24wH7t28mObxxEC0kV+btQ4P8PEFAzg3UZiD2QZXUT6fs1qVucvizomlPeRpiBrV3YTmcbvP1wY6CdB9tuk5qwlCqdh1NimCMT/H3Ep8G24obZZBOIhPeEqC3P+j+nkvRFbW055SvFGMqu5sl6A3xU/iFqTWSc+tctjMPE/zNDGO9pvhxn2cmuShJIfzK4NfQKraiPRk1lu0+AmSygnQF6kA1yir3hsVlMrJ0dJrjWNElxy5WixiosqdbgjkpRzIHPDFqK7jCgiGCyxTa4IuImOy7ebjhc8Ae8t54OFDT+rlJmMQBwPtG4mPTAKw7Y1KSe4/WUSjJpUg3sCe3yLNAymZ6cRhU1S0emFB3DG5TxGik8q3eSAKTCzwRumxTQm/LMXU7ipcT1SmFMOAgoD0ltB/aAabepXAG2tcXHmmvPP9C8VfkQ+oBEiKlyjN16Sif1i2k0SkaMzlB2Hc+TyehFnHSvpK5ibMZQDUYpD4DT8rIzlaTUZMavKfy2HVAZdEqp6fDhlVj6rIJAxXcblgeJnMrPJdwWp//5iG2b9Z1ii0zSBZyhOMO16wMiHpfYbNoHlgmi0LDPCeVun28a4iF62N2O 6CsIacCt ePJVl44wav+V2WtXyI9N8UNVnpBpbXn7E4erGcbe1zpyhH1zqdnXxSrtRO8rkaujU2rRntYg7fTDIrBjRiRqeyY2Uf+ioq+UB2cjLrKHQ8h+LuCczA6CrV+18pVgjZOwAwdeNlDnrQO/jGL9jR9ryt43gtemTrOJvqS1ltQhipBsJhryopTmQP6wNq5aBh0mQgr0GsG68phlh6n5vsX8hdG7bQClikrv5CcwR9yGHScDHJaX85Wm9QBaw/rTC5Uw+ExzriuWY37svB1DWp/ZsqEU4RcOU71yEVJYFgOnFKgRXEcJPOK2BJmFqOH+MwCKCwgMcAidnj35CddzOVa/ppnwFkme0uAYQk3EkpE4oRSHysR48ev1e3ajeh8Xx9NHwUGbNHyBzM1agOdZoWj+yX+Y59NEzqpATRwKGCIH35mAEqTYDnLB9kuC67tcpfhgdbcrO1aYvWbXcLxC6fWjrRwcu9+SapHDYA3dTu3FARUtG7W13JE37z+ZK5P7buWUdrK9w X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Lorenzo Stoakes [240705 16:06]: > On Thu, Jul 04, 2024 at 02:27:11PM GMT, Liam R. Howlett wrote: > > From: "Liam R. Howlett" > > > > Open code the do_vmi_align_munmap() call so that it can be broken up > > later in the series. > > > > Signed-off-by: Liam R. Howlett > > --- > > mm/mmap.c | 22 +++++++++++++++++++--- > > 1 file changed, 19 insertions(+), 3 deletions(-) > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index e9858ca8bbd4..f5b33de4e717 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -2915,6 +2915,9 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > struct vm_area_struct *next, *prev, *merge; > > pgoff_t pglen = len >> PAGE_SHIFT; > > unsigned long charged = 0; > > + struct vma_munmap_struct vms; > > + struct ma_state mas_detach; > > + struct maple_tree mt_detach; > > unsigned long end = addr + len; > > unsigned long merge_start = addr, merge_end = end; > > bool writable_file_mapping = false; > > @@ -2947,9 +2950,24 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > /* Find the first overlapping VMA */ > > vma = vma_find(&vmi, end); > > if (vma) { > > - if (do_vmi_align_munmap(&vmi, vma, mm, addr, end, uf, false)) > > + mt_init_flags(&mt_detach, vmi.mas.tree->ma_flags & MT_FLAGS_LOCK_MASK); > > + mt_on_stack(mt_detach); > > + mas_init(&mas_detach, &mt_detach, /* addr = */ 0); > > I'm guessing this is exactly equivalent (or equivalent enough for our purposes > here) to the MA_STATE() call in do_vmi_align_munmap()? Yes, what we are doing is inlining the function call so that it can be split to parts. So for reviewing, I just made it in-line. > > Checking the two against each other it seems that it is indeed. > > > + init_vma_munmap(&vms, &vmi, vma, addr, end, uf, /* unlock = */ false); > > + if (vms_gather_munmap_vmas(&vms, &mas_detach)) > > + return -ENOMEM; > > In do_vmi_align_munmap() we also invoke vmalidate_mm(), why aren't we doing that > here? I don't see the validate_mm() call in do_vmi_align_munmap, it is called in the vms_complete_munmap_vmas() function though. > > > + > > + if (vma_iter_clear_gfp(&vmi, addr, end, GFP_KERNEL)) > > return -ENOMEM; > > Same here. It would fail here, our count would be wrong. > > > + > > + vms_complete_munmap_vmas(&vms, &mas_detach); > > + next = vms.next; > > + prev = vms.prev; > > + vma_prev(&vmi); > > I'm sure this is correct, but just to double-check - we want to set the VMI to > prev here right? Yes. In the current function, the vmi points to prev when we are done this dance - so I put it there. > > It might be worth adding a small cmoment saying '/* vmi now points at prev */' > or similar, I've found it can get quite hard to follow where the iterator is at > sometimes. So this is about to change.. > > > vma = NULL; > > + } else { > > + next = vma_next(&vmi); > > + prev = vma_prev(&vmi); > > But here we move forward to the next VMA and set this to next, then go back to > the _original_ one and this is prev? > > Actually I guess if vma == NULL, next gets you to the next, and prev jumps back > to prev, with nothing between, and so that makes sense. Yes, this is what I'm doing. > > > > } > > > > /* > > @@ -2962,8 +2980,6 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > > vm_flags |= VM_ACCOUNT; > > } > > > > - next = vma_next(&vmi); > > - prev = vma_prev(&vmi); > > if (vm_flags & VM_SPECIAL) { > > if (prev) > > vma_iter_next_range(&vmi); > > -- > > 2.43.0 > > > >