From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C39DE7716D for ; Thu, 5 Dec 2024 15:34:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7A286B0129; Thu, 5 Dec 2024 10:19:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 296EE6B00EA; Thu, 5 Dec 2024 10:19:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECCDA6B010C; Thu, 5 Dec 2024 10:19:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2CF876B0082 for ; Mon, 2 Dec 2024 01:02:56 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9981CA136A for ; Mon, 2 Dec 2024 06:02:55 +0000 (UTC) X-FDA: 82848974964.01.0EC998C Received: from mail02.habana.ai (habanamailrelay02.habana.ai [62.90.112.121]) by imf12.hostedemail.com (Postfix) with ESMTP id DAC0F40009 for ; Mon, 2 Dec 2024 06:02:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=fail (imf12.hostedemail.com: domain of dafna.hirschfeld@intel.com does not designate 62.90.112.121 as permitted sender) smtp.mailfrom=dafna.hirschfeld@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733119363; a=rsa-sha256; cv=none; b=p0KUGNSo3eurTsJ3JpQgJeg2h8EFOKwFy1cROPXBqkTV8szi+aZCu0US3xx7AYWhJNNQGK eOA1gaToErUkkoV6rWA6M2jmb+STQd2A9wqKfEGM3/vm0GQvDc/10UtlR0hPKm5NqKERYA 1c/revQThhES/BTHNpWFcQF3svMg2v8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=fail (imf12.hostedemail.com: domain of dafna.hirschfeld@intel.com does not designate 62.90.112.121 as permitted sender) smtp.mailfrom=dafna.hirschfeld@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733119363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jAGP8hdTyADOzyG1AQ9TjxLjJjREHfZ8I7an5Slm8vE=; b=EI/nbuUbk4ZKFae+iTdTwFRUb1IebAGeHMa416fM7411ALLwepOb3/9dYLaKqbWYqqEC3V WGAkfUdakZ0mIXwWUQ8VxbTI+hjlqRaGFeIU75caa2ZxtwoNEVmIUUoT6AL0toKyoJMPO+ oZem3kSdLEbFe3Hhu6g7FJs/wMxounc= Received: internal info suppressed Received: from dhirschfeld-vm-u22.habana-labs.com (localhost [127.0.0.1]) by dhirschfeld-vm-u22.habana-labs.com (8.15.2/8.15.2/Debian-22ubuntu3) with SMTP id 4B262XU91546023; Mon, 2 Dec 2024 08:02:34 +0200 Date: Mon, 2 Dec 2024 08:02:33 +0200 From: Dafna Hirschfeld To: Muchun Song Cc: linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org Subject: Re: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio Message-ID: References: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: X-Stat-Signature: toe8js4su6swfoinqgon8oax37ii1xtp X-Rspam-User: X-Rspamd-Queue-Id: DAC0F40009 X-Rspamd-Server: rspam08 X-HE-Tag: 1733119367-243351 X-HE-Meta: U2FsdGVkX1+sjAx4TU8lBywa293jM3rTe5HbeN+xLsSWG6SZZwzROTwHdP+mFZpKZjhdklb7F2R1MlOvY1kup4+ucbthD9gqsV7a2jkRyVNjX5uUNKXOx7HTW9A1qnU512VK/q0q+qKyf7muW9L/yMpToGCvtSTyQkrmhV9LF+pJq3kjcSwxGKxLD6egT2Tjbo90f8KJbcChL6zCDQl6HK9FuT9B/pGqEpYO5N+5Q/K3ZYcdV8wl8iLJS1zNX6lwQmGr+J6zmnJ+SpjWbLWpbzmVTJDnIWrQ8Do0g5wO0hA9DfPOeEKwB6eUB0kGU378I9sx0C64CYZKWvi4imOHehfsmp0tROJVQwbEYKkkipsC711bytMP6n1LuHqQkcBeEU0GOzYSDXTo7NAyKSI7FqQTTu+n1W4N5Y+/g/25lgqfsL4POmI2laRh3mEHFB78zbEMMcf0PFKopzqAepu++ahE8gyaBwKK+bC3HyM9XQdcjSJSL+RFaCOvn0uEL7UWC5z8XGl1dTeBkRCOkMbgyVjSTpVLn3KasYh4IPrMnMcJHKu1z7G6cyzbV2EpUaIcgIFSc2PF3nmharpRXm1UEE/LFNoYCVY49+FxDqVCsAZf8ojergUp84PsESGe2dDX20jclk78HUV23TXIHYpDo5hkCtfZjJCPcpP06mcesqMaLA5IPtjwbGsM9OEcxXKVMxGaRdTexzMN07e2YnS94GQA+6TPKwf0enMuWLytA5/20efH+TrehUoHgA8Pw+q/KcdUWYGGMWdqnjz0ruViHDEweOIRE0c6zGxSQGlYNLNOAYA3F3e73bwdMWroijx2gjhLnXZZFjv1M+OB2wkKqM5oGdBZazB/hWw3z5fBjHIajosBMm8XawNvtHJD97aD9Y/b7VAL1DcRdAQb3xcQl2Wv5AJ377nYIzddpLkrXZEsHM12L1UxbHYsAq5o1eoSjsvP1fQmbpN/H6YtljR YjhAZypp 46+/SzAivqd8hSOdwlv78heIJaqg+lL2pcrAuE69gvqTzwoh4pF2j7ufWSkKkEOF60dvvSxeYkkdffD20+YyJPIkh8WqRr3/re0R15+YvUilU3Pjpce0mpB3vf2HFIgC64zXgfYG/0GXSJ/BmmJ61xpsZNDRsa4SBT+pjVuwtJQ7ODt+uhIyemIDWilKFYvOvHCCk+ObXgTlBnVLC9REOZlvrDH/Y+tE8RbPWS+0fT/WmxtoTuiGgY43M8gLegJ4sq5zW21w/XX92WgZ7DxxCJsOItdY/HT0H8ixnyW7gaqRQUJLn4h7jlDbnNlywK/kPn0vDevkZUiLJe0kNbbkP3XmF4AGOelJ9lj6Ip7te0eh95tt4Zu8f34G6c/S2SbmXTi6K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.12.2024 11:49, Muchun Song wrote: > > >> On Dec 1, 2024, at 09:03, Dafna Hirschfeld wrote: >> >> The error ENOSPC is translated in vmf_error to VM_FAULT_SIGBUS which is >> further translated in EFAULT in i.e. pin/get_user_pages. >> But when running out of pages/hugepages we expect to see ENOMEM and >> not EFAULT. > >Hi Dafna, > >Refers to Documentation/mm/hugetlbfs_reserv.rst. I saw: > > If no huge page exists at page fault time, the task is sent > a **SIGBUS** and often dies an unhappy death. > >Seems SIGBUS is expected since it is introduced. Ok, but for functions such as pin/get_user_pages, it is translated to EFAULT, which is not clear if this is what we want. > >Thanks.