From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F86C282EC for ; Fri, 14 Mar 2025 15:25:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285AF280002; Fri, 14 Mar 2025 11:25:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 232D5280001; Fri, 14 Mar 2025 11:25:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12315280002; Fri, 14 Mar 2025 11:25:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EA45D280001 for ; Fri, 14 Mar 2025 11:25:18 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 789A0B8DA5 for ; Fri, 14 Mar 2025 15:25:19 +0000 (UTC) X-FDA: 83220530358.05.1858B4B Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) by imf04.hostedemail.com (Postfix) with ESMTP id 792C440019 for ; Fri, 14 Mar 2025 15:25:17 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NMptf53W; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741965917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxlRek5piQEOqJgTgUW73cEStZDjS6tHAoz6Zpz+OY0=; b=wFReWwds54dBF+j7/SdVWGLD2dWl+slV5+PrB4LKE3SvkU6taFPJw9yDvUEydlAAoVNhW7 4u3MSloUK5YSOXrxW+1SwPe/N8wS+8t/kAbJ4YN+Htj2evz67CrBfPtuti1YFrN73GFzG8 ylJk1GAZvidEoENbn9fm1X/3F/NXtLc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741965917; a=rsa-sha256; cv=none; b=cXpZVx4CsjbTPw9+gJySVu5WkFMaz78JftLZwQ/5DShWtfGczY35snlfbuR4NIlQpWYgzp 9XWmTv7Y7FAhxDceMs0Olqp4S2YYyvpnjXwMnW8cGWcLA0A6oPwnZ9ffLyma6H/wUBYICH VPkJns4NfrAr4hCribfn53rOGuI8WQ8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=NMptf53W; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.189 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 14 Mar 2025 08:25:09 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741965915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vxlRek5piQEOqJgTgUW73cEStZDjS6tHAoz6Zpz+OY0=; b=NMptf53W6V7UzUIOvVx4QrFJjyUz3uT6qHJp7SoOKAyL/8wDqb03/VSR2iR6x4IQC3zCh1 YPOwrtAJFAlLPLOh7p646kyd6orl48+O4yP8IJCfz11amr55tRcZig6/pe3S/osHVJm/1i JzF8Jj8MPPw/EoI3jxCLxJ0QVLN63XU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Sebastian Andrzej Siewior Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 05/10] memcg: no refilling stock from obj_cgroup_release Message-ID: References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <20250314061511.1308152-6-shakeel.butt@linux.dev> <20250314112627.dPKeawXj@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250314112627.dPKeawXj@linutronix.de> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 792C440019 X-Stat-Signature: 6ttftsc7j64p4o6zzjngd3u39sjbrk5z X-HE-Tag: 1741965917-331909 X-HE-Meta: U2FsdGVkX19RN2Zvx4Ii19/ytV/GrvahHvCNaqi9JxaevKgnd94FBtACRM4ZX1Jre3Ki8ssmDk4Coz3n3u7xgc97jEZx4uWB4Jgy3Z/sbkOszzcvqcufBI0bPkullD1KexGfg9UzHCEf0fKIYgyUHcG5xE2w6Y2E9Lk/WChqKzDvb8T5oRHB4R2LuavPQ1Lq9VQd6emgewxiou2eRj5RW7ymHOxUoLr7Y5o4kvx7BbSDexpbI9Cv+BFUeBbzxDa0vwNQ2NZ+h+l3izK7tS9kE/WIoqeulU2czBrDCM6LX1g9A/o1bPznLQtTvs2eYYBY2ClT+MxsXwbrxfwIdr2kvEqC4Ef+jruMbHbAZ8VF+woqzB498wYUBTa0VJ9mtyNLOlaxOP1LcwO7jy8Z/qiDBM7qUVBmHDrT+787eBGrNNg79mkyyqJrsPEgTqwENQTAvXuhGWFioj2MHRsF1fehvyuJLuCYoQBuX6UonhMX5BSpQZ+UOWjQ0pQSJcbQBczlFJEfUx1UBOI5tdWZhXygR2PLd82LsnjYcnDCkWwnRkjMmXjH7lOnPOhk+b93AcUcXvmY6rXlr9Vx7ouU7LvinNVSQ6H0lxFZOSi2gJgMqBme7nyGtfZCn5etA4W+NMYcT1x0vUVRTjZ8w0QSuxLScSF79zS/y8vylkfDXVtGJWhUBv7Q05f4LrZLFng42HUtGH3rEypweoHteNPA+ajahGt8d0TMiEDxDJyg3iWppyV/Ei81S8/AMDttvod2840PiNhKXjj+T9ICeXSTTTgfRS//+HfuNDMXcUFrf+Tm58ARqb+nA9I4aEQdfb1x3GcjpYsjrrGW/HGXkGUQj+6dIzmf/VNCxOKreaPijAgmC0VcmdYcXgdzxAyAlWeKGEnHTxhRyyYwPKgwlBGGAZAdbO5kZ7URouFrrKMd23haDNKPtzh+OaKAvoWiqytTevDGSu9zxwKuDdSnGnGJEGV L8qf/N3B DePb5Q5csnp4LKKrShlLy5PT36uMVwsUY+74hbB9ij0JHg5ykGbGB0CzmnvInW/LZtgrr+dTJY+9zWciynePqpJs/2o7WYIGwAW5dxksMeg/a41RK4bHKfDwzo8d8ZA/vimZfuhAxBL75KpE1ftdklZMzXWCUIqCRp08axA8b0SmjLAwqgD6/t0hnjncTPD2v+ATRngZQPU1fhudiWgoNW4lEwT3Gzkvz3XyfZdH2qh1caDU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.031710, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 14, 2025 at 12:26:27PM +0100, Sebastian Andrzej Siewior wrote: > On 2025-03-13 23:15:06 [-0700], Shakeel Butt wrote: > > obj_cgroup_release is called when all the references to the objcg has > > "references to the objcg have" > > > been released i.e. no more memory objects are pointing to it. Most > > probably objcg->memcg will be pointing to some ancestor memcg and at the > > moment, in obj_cgroup_release, the kernel call > > obj_cgroup_uncharge_pages() to uncharge last remaining memory. > > This sounds somehow funny. I think the point is to uncharge the pages > without tampering memcg_stock because it is unnecessary. > Thanks, I will see to make the point more clean in the next version.