From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC55C54EBC for ; Thu, 12 Jan 2023 15:41:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A858B8E0002; Thu, 12 Jan 2023 10:41:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A35B08E0001; Thu, 12 Jan 2023 10:41:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FD918E0002; Thu, 12 Jan 2023 10:41:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 80E528E0001 for ; Thu, 12 Jan 2023 10:41:03 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 58759140CE4 for ; Thu, 12 Jan 2023 15:41:03 +0000 (UTC) X-FDA: 80346560406.12.DFD9B8E Received: from smtp-fw-80007.amazon.com (smtp-fw-80007.amazon.com [99.78.197.218]) by imf29.hostedemail.com (Postfix) with ESMTP id 66F95120002 for ; Thu, 12 Jan 2023 15:41:01 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=gO3firGu; spf=pass (imf29.hostedemail.com: domain of "prvs=36970dc9e=shayagr@amazon.com" designates 99.78.197.218 as permitted sender) smtp.mailfrom="prvs=36970dc9e=shayagr@amazon.com"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673538061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oUK2ACBDt68b8+5N1drGEA/zCC5P130zN9Q9P8hW2Zw=; b=FdpIC+BIfM9aHSofgL9ptEBJRjbnIOcKjnLAuDwTETnRItFTmCB31ML9QxZ2gdmu7PapHs mooP7Cu+vwu0ymZUzZwdmE7LKkfMR7vH8Pdx13zKTgM0IfyjFSmQDr96q0M7/1b4TVFY2P 0VHirL4JMApPgqn3BAM+oOmyoobUMgc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=gO3firGu; spf=pass (imf29.hostedemail.com: domain of "prvs=36970dc9e=shayagr@amazon.com" designates 99.78.197.218 as permitted sender) smtp.mailfrom="prvs=36970dc9e=shayagr@amazon.com"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673538061; a=rsa-sha256; cv=none; b=l11bT1PZB7qG0DR6o8oRM5veWqAW+tbE+TEZExlHuKDZAyUEx1Lo+3Tu49cSElJlx8IAca ci9cjovIxJyhNJa3feCyXLBy9yDnVyUaEHVGXeZnj7kiWVGA6laQG+wiNleySGwnaRYrX5 veyxkepXCcRAbyUhdmWhaZrIJwWuy0Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1673538062; x=1705074062; h=references:from:to:cc:subject:date:in-reply-to: message-id:mime-version; bh=oUK2ACBDt68b8+5N1drGEA/zCC5P130zN9Q9P8hW2Zw=; b=gO3firGuhgbBIVD6wlTt1i2JAS5FdFIvMDaV/IkgURiJbWxD/OszwE13 z/pOgP9RUrKvlOHl//2oEN5GAGcvjEnZi1zEbqbWbQEnQQ5razVje9toh X/JWMYYIBJjU1uYClZff3npT2SYm1EmZHwkzIm8Z7Wl0M65uJK8VrkBaW U=; X-IronPort-AV: E=Sophos;i="5.97,211,1669075200"; d="scan'208";a="170568498" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-pdx-1box-2bm6-32cf6363.us-west-2.amazon.com) ([10.25.36.214]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 15:40:57 +0000 Received: from EX13D46EUB002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-1box-2bm6-32cf6363.us-west-2.amazon.com (Postfix) with ESMTPS id 21A3882414; Thu, 12 Jan 2023 15:40:56 +0000 (UTC) Received: from EX19D028EUB003.ant.amazon.com (10.252.61.31) by EX13D46EUB002.ant.amazon.com (10.43.166.241) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Thu, 12 Jan 2023 15:40:54 +0000 Received: from u570694869fb251.ant.amazon.com.amazon.com (10.43.162.56) by EX19D028EUB003.ant.amazon.com (10.252.61.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.7; Thu, 12 Jan 2023 15:40:51 +0000 References: <20230111042214.907030-1-willy@infradead.org> <20230111042214.907030-6-willy@infradead.org> User-agent: mu4e 1.6.10; emacs 28.0.91 From: Shay Agroskin To: "Matthew Wilcox (Oracle)" CC: Jesper Dangaard Brouer , Ilias Apalodimas , , , Shakeel Butt , "Jesper Dangaard Brouer" , Jesse Brandeburg Subject: Re: [PATCH v3 05/26] page_pool: Start using netmem in allocation path. Date: Thu, 12 Jan 2023 17:36:58 +0200 In-Reply-To: <20230111042214.907030-6-willy@infradead.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Originating-IP: [10.43.162.56] X-ClientProxiedBy: EX13D39UWB003.ant.amazon.com (10.43.161.215) To EX19D028EUB003.ant.amazon.com (10.252.61.31) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 66F95120002 X-Stat-Signature: d59wmgmujkod8p9d5zxwu8qcqhgfxjkc X-Rspam-User: X-HE-Bulk: true X-HE-Tag: 1673538061-52323 X-HE-Meta: U2FsdGVkX1+sqV+Ucw0dZNxQQMlMb4bEateF5GTbxL8OnqrrLIF1v9YMI8lNy/5oDUkNDrQSiY0RrhIBSwPZ3grMYP4J7b6SgwIZLij1ANn17rHB59mt+qQc/4cQ0mSBfoJnC5MfJoizM9HfelicmULyrYmKlOYHaM+oxVNXyO3c7pYFTv76GIBod5ZlkkrUlF7H7MI/9/cgJahQ2UceVlCAt2AzKj9PsVwOcRel/+91LqjWcXjmNRL83HG6hvfOojh+1BQoxw7CN82ojzbwV9juZwP2/hVgAMujywCDcYQosHYsz5VCyOT3EoEfOSfn0n4QIG2S2Aomj2br82jX7Sl+XsWtQdFhX9xWbp9r8ZkHl5e8yq1BqONME3CvqwFYhWmw2u2A7+xbTtPWEkdFpE8wkVKlhXVhD+kcAKPOISIvGHF/7vAYgSMEQ14ZQ4igC658YqB15HlD7hDz2pzd9MW4C6YJN3wZO3d5kgEljiMEXNGX9NnBCxgDjc9gRRe4RYedKT+WdW7ew3DjI3KrYWMd/pJ5ZugowW45ctJH5rP1JtP1uq49oWt11Zusj0hg4bLWoreQ95Y3aeh09BszD32QW023dhmHXOBJyiWFgSyT3C0/Iq+IP3ltOXEHZxNPhdg+DqlL7pviFrO/PlkMTR8bMkCRZqmeYAIju+Nonaw3NGrmxEYjsLDUwOJ2sGO5Ygg5QfzONR2ASLMWMuBZISkaiwJozccShI35IALgJkWfg6pB+f7F3o77XQH6QCdcupnwnoErulfgoWI8TXbat8e2w9W+l5+HNobH7ZLo/hXk8jecwFgo0M7PvHyTWLemCDdePYjRdTfLnGIax/Vb51ggHz1s1JWgTLTb7uIPPLrZno6UGmTqOFctvbOX5ebMRFaJ5ZLD1FRvyLuMwSBZ2bxJy4x3XRUMuc6DKZZbMo1ZZZA3g70d6ZRymOPq8WSrgX7QHXktnJzq4V0H/68 1wHP7KrO kpD5i83y7tgi+L8RxFawNnL40XqlW8YmSou8wmOpJFDZwXzNvvmeU44/e1Tn2sC4mMiu6w3XeC/DCwUl6K+sKSh8CX/CnOHGRfxVTmia298vmObYS1X6QwBfIBUk+4+Pd3AxybyVmfWm9W+LZCToIw7JkT48/HZs0EChElVS+hWDs80recc99QRbrFJu+MPG8qCRiSPUJ+NUB8mFykQjs50PfAc4H7U8NkaY6leNLnicvsy6jDBHFG8pzqfGaJFs5AULQJIKt0g5hB9GQJYVf8XRKRPIRuckjZ2m5pepYx01YBfhmN+iL7Ar+I8+ua4ua7wwfbjo6eXgP/siDj42AnA4nm3Cpb486VnUm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Matthew Wilcox (Oracle)" writes: > Convert __page_pool_alloc_page_order() and > __page_pool_alloc_pages_slow() > ... > TRACE_EVENT(page_pool_update_nid, > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 437241aba5a7..4e985502c569 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > ... > > @@ -421,7 +422,8 @@ static struct page > *__page_pool_alloc_pages_slow(struct page_pool *pool, > page = NULL; > } > > - /* When page just alloc'ed is should/must have refcnt > 1. */ > + /* When page just allocated it should have refcnt 1 (but > may have > + * speculative references) */ Sorry for the pity comment, but the comment style here is inconsistent https://www.kernel.org/doc/html/v4.11/process/coding-style.html#commenting You should have the last '*/' to be on its own line (again sorry for not giving more useful feedback... then again, it's a rather simply fix (: ) Shay > return page; > }