From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C7A9C46467 for ; Sun, 15 Jan 2023 11:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E52A6B0071; Sun, 15 Jan 2023 06:20:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 494956B0072; Sun, 15 Jan 2023 06:20:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35D7E6B0073; Sun, 15 Jan 2023 06:20:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 29B8B6B0071 for ; Sun, 15 Jan 2023 06:20:37 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E6101A6164 for ; Sun, 15 Jan 2023 11:20:36 +0000 (UTC) X-FDA: 80356790472.22.32640F5 Received: from smtp-fw-9103.amazon.com (smtp-fw-9103.amazon.com [207.171.188.200]) by imf09.hostedemail.com (Postfix) with ESMTP id 1B63114000A for ; Sun, 15 Jan 2023 11:20:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=kCUqB7GU; spf=pass (imf09.hostedemail.com: domain of "prvs=3727666fa=shayagr@amazon.com" designates 207.171.188.200 as permitted sender) smtp.mailfrom="prvs=3727666fa=shayagr@amazon.com"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673781635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lN7D4Cqok9W2URLE4i2D8VpyfdXBM6+t+aiHuYVZoJo=; b=4Cpd5dGl0vL7qa7GqfR+OlOBfobId6b2Id1pmjCG7PXRWE7R1LNzykiGy+w00vkXn+s0i8 /SR2Pqh5TMj+QKNaewo3rTNBxpTfogM6z6mxGOOGIfgoxTeR5QOB5Dl9gPrxMnADtaRDnE AB5vVaYXyGiUcjY6AdsHEOpEDKbn6o4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=kCUqB7GU; spf=pass (imf09.hostedemail.com: domain of "prvs=3727666fa=shayagr@amazon.com" designates 207.171.188.200 as permitted sender) smtp.mailfrom="prvs=3727666fa=shayagr@amazon.com"; dmarc=pass (policy=quarantine) header.from=amazon.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673781635; a=rsa-sha256; cv=none; b=XfavI3QcMtLV/Pq1J+8zovUemIK25YhHgX4D7KWxNfeuZNOn7MjwJQAZQuir5n/ZXk2B4F C8wPcbtiWu5mpPKZyP8LSL+g6ztXIvo2tDtvgVEpprblfQAVCMYOm7d2IYZyEiecsc3aBc G3dgq4CKux9EOBpiHLm6Uta4Q7qn+4g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1673781635; x=1705317635; h=references:from:to:cc:date:in-reply-to:message-id: mime-version:subject; bh=lN7D4Cqok9W2URLE4i2D8VpyfdXBM6+t+aiHuYVZoJo=; b=kCUqB7GUN07MtzKS5XP/8BmaFif4pGgc+gYeO11k4/R8bS17KZBaCQq4 7lj1nL4PifQ2YuL/07u8Tw4bbU/CQAqSBvd+RQN1Ub8a6MYr0MsRZARnR 9GfB4dYtdyF3euE4Qy/CDbnkXLSUYlA1PqBg0v2XH87SxQB29/EWON3qh 0=; X-IronPort-AV: E=Sophos;i="5.97,218,1669075200"; d="scan'208";a="1092789605" Subject: Re: [PATCH v3 08/26] page_pool: Convert pp_alloc_cache to contain netmem Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-iad-1a-m6i4x-54a853e6.us-east-1.amazon.com) ([10.25.36.214]) by smtp-border-fw-9103.sea19.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 11:20:28 +0000 Received: from EX13D50EUB003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-m6i4x-54a853e6.us-east-1.amazon.com (Postfix) with ESMTPS id A8CCB432A6; Sun, 15 Jan 2023 11:20:24 +0000 (UTC) Received: from EX19D028EUB003.ant.amazon.com (10.252.61.31) by EX13D50EUB003.ant.amazon.com (10.43.166.146) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Sun, 15 Jan 2023 11:20:24 +0000 Received: from u570694869fb251.ant.amazon.com.amazon.com (10.43.160.120) by EX19D028EUB003.ant.amazon.com (10.252.61.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1118.7; Sun, 15 Jan 2023 11:20:20 +0000 References: <20230111042214.907030-1-willy@infradead.org> <20230111042214.907030-9-willy@infradead.org> User-agent: mu4e 1.6.10; emacs 28.0.91 From: Shay Agroskin To: Matthew Wilcox CC: Jesper Dangaard Brouer , Ilias Apalodimas , , , Shakeel Butt , "Jesper Dangaard Brouer" , Jesse Brandeburg Date: Sun, 15 Jan 2023 13:03:41 +0200 In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Originating-IP: [10.43.160.120] X-ClientProxiedBy: EX13D35UWC002.ant.amazon.com (10.43.162.218) To EX19D028EUB003.ant.amazon.com (10.252.61.31) X-Stat-Signature: x8me3eyfx6fe7yzuahwaqtjd5w4xhh1u X-Rspam-User: X-Rspamd-Queue-Id: 1B63114000A X-Rspamd-Server: rspam06 X-HE-Bulk: true X-HE-Tag: 1673781634-259466 X-HE-Meta: U2FsdGVkX1+dvtQGVlpOZmcDGGCUxpjjVbx7VDvHfkgZwABeaPza6omDDYX0k0Dmw5TBWAR3/b2FHyyIU0daLLTCEaOFipGv74LqqQZNXHb6OhoeaucdflRlykh0yzHaTAPwAtDoKWciMvELMmha8Dc0ppAZZNcCdQWiXNUZQRLi2xaJyP1K9GHFOO8YwsD80JsdYZ5KmcMGAaDhf9UbDRb4BxU4y5vO2fD4bTxNn8mD7R5q5UdcKoBVcouLLdL4wq8qL1jl4pyVDYoFkMGSOxKU5272PZ0F8Amr1mz4ah77XK3SCaohDggYMVJWygRfEKWLd+Beln7ZfNLxw6pxmD3fefGA7Ey3kGMk2J0BKLVTOcD9ooqVszB3l6AylSXdCVQBfPJl8lVS4wQXzdaDsSIiksc5xDduJJtB38a857xsXpNJYAIfYH0va0jADqv0i0Pj5rLCXvlOKrbYoagZeOqvPCcvU+keE1i+e7O7LFZfwW5s5Jnv8mQIT4xUzXoLQQ1KDpg5m0MV6bV7JJw/p8J5zgJOispJM5IgnsnhzrR4GYI4iA57gEYP7XiXi0ucLigLHZfOFznQqxm1EOTbF+wXBeA/RcYLNzhjU6eOLZnpktzzrHL6/eV8j52to9GUyfP8tXDzoz0Po1GQmOGC7FUEgftwE+JIeHFlnIEl819KY3nstUjRAD9Fxtdqmf4hfEstptsKYdvmTJznNIhUhAdeJF7pGHC8p3VbyJ7X2bPSHk/KS97z3vZCvtx4AIHco433LHmSN6DAkw9lqOFoKRZ/LGE4qMAr2trfQOkF3NejpyenZSSQkmf7xSMcvVh94xKydMir8Hu5WWMW3wIzpEOE+7WVrZMaE3Gkh5/wuvnN2zwO8NcThm9s+Wa6RBoFzciyAPih9xAFhhoYQBYi/7PsZ8sXBRAOMuUaNCmWkT0DlnM0fQtcoGRHrlZsGOIW8pKCj30V2coWEy9Wavj C1psaLLF pPxLrO04TKN5xB0OhKOhyXU3Wa7wlg0txEq8Q3vRIhsjufHDKEiuq8i2MM+7RAuVkZm6TH1yOBZYgPA0y33Ym1gxLy2imKM/zxFYJoPpV+rutYIqIziGObCe+LadzrFehanIglOMFh3ZXhPpi329BO6DAUMNmfSINH3Mc4rZNZZEhNOKRhZhWJ2lNC4qkeaVu7XRTTf+uRwnVRNFYvbzC6HfVw1i/TjMSP/3oSV6pGPdxB1V+ESEnFKiWcWUKt8HKmYpdc/5+nOZYCeqSQSzWSof8WwhS17L2ZW508hSsTvYCqOeCQupk1+30LPg+enj7wA+cIaI+Jr/C/nxoKFVWMdhMv2evpsBXYaY8MrhRP/8kV+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.008314, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox writes: > CAUTION: This email originated from outside of the > organization. Do not click links or open attachments unless you > can confirm the sender and know the content is safe. > > > > On Sat, Jan 14, 2023 at 02:28:50PM +0200, Shay Agroskin wrote: >> > memset(&pool->alloc.cache, 0, sizeof(void *) * bulk); >> > nr_pages = alloc_pages_bulk_array_node(gfp, pool->p.nid, >> > bulk, >> > - >> > pool->alloc.cache); >> > + (struct page >> > **)pool->alloc.cache); >> >> Can you fix the alignment here (so that the '(struct page **)' >> would align >> the the 'gfp' argument one line above) ? > > No, that makes the line too long. Couldn't find any word about inlining in the coding style. AFAIK 82 characters line is considered ok (and the file you're editing has even longer lines than that). To me it'd look better aligned, but suit yourself