From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58357C02185 for ; Wed, 15 Jan 2025 16:28:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB09280003; Wed, 15 Jan 2025 11:28:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5BDA280001; Wed, 15 Jan 2025 11:28:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D506280003; Wed, 15 Jan 2025 11:28:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 81D3B280001 for ; Wed, 15 Jan 2025 11:28:54 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 09D1A16148F for ; Wed, 15 Jan 2025 16:28:54 +0000 (UTC) X-FDA: 83010220188.13.8CC7660 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf20.hostedemail.com (Postfix) with ESMTP id 45DDD1C0016 for ; Wed, 15 Jan 2025 16:28:51 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nUanq15R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wu7zZod9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nUanq15R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wu7zZod9; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736958532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OwWlMeNIUac6pTlqmXEgukSP6+CjESF6OJN9nJ+Y+Fw=; b=rt3WWf6ai73bso5V7rrbVe+T/o4YfA4Xfs5cBaSCYECi7B3aZELJ5HjK1XXwge+oCbjWO8 vpCyRtocZSP8drcwcAsXf1yKnLdfMoEE3vQuaWggAdOrjtbhDk6Jk2Cp06dl9Y7rWkyPhL XOvGjrkR20siTlV8Ci6X1QzVq1jrqGw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736958532; a=rsa-sha256; cv=none; b=Z7uC53zjjKyY/ZTGZZ9EXV1d2S2D3QyRBtlp79kXXxTpiFbi4AqV3BBuYBe541iWp5A9Pb 2aS63P8KYs+ywdbFRGOJ9OfTVyhVpRVsQp0ZgWnGtoAXT99WNcpaaXueSBj7efC27g0w7w v/SY2i3LqfE6cWUit2Y+69ZPPxVyLiU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nUanq15R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wu7zZod9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nUanq15R; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=wu7zZod9; spf=pass (imf20.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9B45B1F37E; Wed, 15 Jan 2025 16:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736958529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OwWlMeNIUac6pTlqmXEgukSP6+CjESF6OJN9nJ+Y+Fw=; b=nUanq15RmvueyuPCRyTT4RocOkuzhqusRXeJI5MFo87QuR6KNP5VF6RqCVmQ92q4PwlreU ZoqJamTTYucgo92xbAKmVA9YaYpc9DD+5K9vP/o9NlWfKWK6iUOQGS2mfSDXJ5UBUIFz3+ Z//MSx8rvnse/dyzyFr4VjpNFnMu/4U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736958529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OwWlMeNIUac6pTlqmXEgukSP6+CjESF6OJN9nJ+Y+Fw=; b=wu7zZod9aFGPCzRB7pKVSrC2lr62pyPt1wMAfn6NRTz1D0Jz9b/otN9iagoGM3yg1v+01A 5bprqDY/5yGXRmDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1736958529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OwWlMeNIUac6pTlqmXEgukSP6+CjESF6OJN9nJ+Y+Fw=; b=nUanq15RmvueyuPCRyTT4RocOkuzhqusRXeJI5MFo87QuR6KNP5VF6RqCVmQ92q4PwlreU ZoqJamTTYucgo92xbAKmVA9YaYpc9DD+5K9vP/o9NlWfKWK6iUOQGS2mfSDXJ5UBUIFz3+ Z//MSx8rvnse/dyzyFr4VjpNFnMu/4U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1736958529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OwWlMeNIUac6pTlqmXEgukSP6+CjESF6OJN9nJ+Y+Fw=; b=wu7zZod9aFGPCzRB7pKVSrC2lr62pyPt1wMAfn6NRTz1D0Jz9b/otN9iagoGM3yg1v+01A 5bprqDY/5yGXRmDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8F2E1139CB; Wed, 15 Jan 2025 16:28:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WSnrIkHih2e9HAAAD6G6ig (envelope-from ); Wed, 15 Jan 2025 16:28:49 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 407B7A08E2; Wed, 15 Jan 2025 17:28:45 +0100 (CET) Date: Wed, 15 Jan 2025 17:28:45 +0100 From: Jan Kara To: Guenter Roeck Cc: Jan Kara , Jim Zhao , akpm@linux-foundation.org, willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/page-writeback: Consolidate wb_thresh bumping logic into __wb_calc_thresh Message-ID: References: <20241121100539.605818-1-jimzhao.ai@gmail.com> <64a44636-16ec-4a10-aeb6-e327b7f989c2@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 45DDD1C0016 X-Stat-Signature: ftg6xg71qo14h4kq3uygwkxb38jgde56 X-Rspam-User: X-HE-Tag: 1736958531-952125 X-HE-Meta: U2FsdGVkX19Gihpuu/tW7p9IzAc2IhGiRGUM/E4pU3dnai+hrefGSPgZV5bS4qpZdMyYDPC6DSfPD7MFuDw9Cu+mfF73qxm7JRM2wWrUOyqH/m/rzo4DXojWIR2+ZhAl1mYqPcoILwLoxTRh1FMnnClSxFuLwBjcVKKop2OAD4mwepZrddYLIZNeBSQsNonZ8YH5Sz9YIjbNt9pLN1f6iztupf4wMnlGpV+lfKNkcRToxOy1KO5CulLBlVH+uW6I0sTLB/qjNcC70OI2j4gfrL9pqQBVcqfhaydteTmEax00ZkPHkVRyV/ovxdR1lrnNwEp07vvSzQoLga4M8hB58xw4FeHkhFg2do1CG8bKdMeVe0+cRkW3jC08lZdBesG5ESPn4US3osFX32nffTABO+IAtK4j3POSQkwmmQZZHVKjcN8I+4QB8irlPc4O8mOojeGJmBBYby3VAssdANdfGmb2X8nhwLJGkJ4WQrl+uSKIX6fKjMGl1UDO/FH0GrOgv5eevM6xam6JNgv5lOS1UNJWCNE6n028P2Lt7BKLTLJ5IcCvGusiEpL1W/8U+P5qdstGmSvuR9fcLGBQSDoYKzDQFmk6HLp+7+bqXTnkZL1QwK8NUTKwLRvyTTof7kDej3bGgHs5EgigTVPN7B2g0Oy7jEbxCuQMjnLE5dzUpiypiW6xZrTj+PXCmTcY5gKMiyiuD6uMCQq7YAQA4YkSM71hn0VlgnDxGGU+3NKJ3VMtPW49Ix/Fq39ZkqMXfovwnHEFjFOvoI0GuZtcBphKfP5Gj3osQbbdK7z47jY9igbWK0NArYojdj12UeKJT6rqdlrhcCWGUYuvgGWEs5GnNHklkl0TpiGjfqYtABrXoOYlBvWEh5b/xwRwF+XbgWfo8l3zUOt1uN5rj+D//q04FzEWMSd35azr+y4XRrHOgN+CbU0Hv58bntPTjrvMatZP6PopO78eMhLVYZSFVtE v+cypCGB ybD8BORRFUz+L9Pb8ZITjEBxtih5ZIoMHaR4JGblAWbjrpVcAoF78fhKxQrANW9D8N8r041BSj/HjEvQNkrW4ntXiYIUQ7DdOGPTYp2yYpl2Pg/DoXWF+b0YkQAi0uCawOCDcoKspGEcA/HkzI6kOgaLp5Bjeahuk/6JJe971T64BdeIa6Y5VA3z9hU/N+E09HdJYdkqgnbekRZxggIR7ufLN3u+a6tpGTgqLRcUFdoAPn60kD1J1B5huwcuuOrKGIftV/ifSy/6rWpu5WziV5+TJFSg+083aZxoBlmH3YJMX+FJ+OcaViV6is+ui46tR5xC5jlq1xD7Xsg83HJSzxytJuDtxzH3AfALJA+Dp9yKw9M/ZYuFdd/cSQ2vE+aCqpj0uwhbqXFNwY85cnWVzQMTPLfc+d3qZsWOYf5JHYRD1dPPmiOPdxTQyk+BsUDjqQdaWMWXwF3rAdUw9YSOkuTg42IjyzYmCegHZIRo9h9ffSZwJeZl5IUOZXhN2LYxrFLlf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 15-01-25 17:07:36, Jan Kara wrote: > On Tue 14-01-25 07:01:08, Guenter Roeck wrote: > > On 1/14/25 05:19, Jan Kara wrote: > > > On Mon 13-01-25 15:05:25, Guenter Roeck wrote: > > > > On Thu, Nov 21, 2024 at 06:05:39PM +0800, Jim Zhao wrote: > > > > > Address the feedback from "mm/page-writeback: raise wb_thresh to prevent > > > > > write blocking with strictlimit"(39ac99852fca98ca44d52716d792dfaf24981f53). > > > > > The wb_thresh bumping logic is scattered across wb_position_ratio, > > > > > __wb_calc_thresh, and wb_update_dirty_ratelimit. For consistency, > > > > > consolidate all wb_thresh bumping logic into __wb_calc_thresh. > > > > > > > > > > Reviewed-by: Jan Kara > > > > > Signed-off-by: Jim Zhao > > > > > > > > This patch triggers a boot failure with one of my 'sheb' boot tests. > > > > It is seen when trying to boot from flash (mtd). The log says > > > > > > > > ... > > > > Starting network: 8139cp 0000:00:02.0 eth0: link down > > > > udhcpc: started, v1.33.0 > > > > EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 > > > > udhcpc: sending discover > > > > udhcpc: sending discover > > > > udhcpc: sending discover > > > > EXT2-fs (mtdblock3): error: ext2_check_folio: bad entry in directory #363: : directory entry across blocks - offset=0, inode=27393, rec_len=3072, name_len=2 > > > > > > Thanks for report! Uh, I have to say I'm very confused by this. It is clear > > > than when ext2 detects the directory corruption (we fail checking directory > > > inode 363 which is likely /etc/init.d/), the boot fails in interesting > > > ways. What is unclear is how the commit can possibly cause ext2 directory > > > corruption. If you didn't verify reverting the commit fixes the issue, I'd > > > be suspecting bad bisection but that obviously isn't the case :-) > > > > > > Ext2 is storing directory data in the page cache so at least it uses the > > > subsystem which the patch impacts but how writeback throttling can cause > > > ext2 directory corruption is beyond me. BTW, do you recreate the root > > > filesystem before each boot? How exactly? > > > > I use pre-built root file systems. For sheb, they are at > > https://github.com/groeck/linux-build-test/tree/master/rootfs/sheb > > Thanks. So the problematic directory is /usr/share/udhcpc/ where we > read apparently bogus metadata at the beginning of that directory. Ah, the metadata isn't bogus. But the entries in the directory are apparently byte-swapped (little vs big endian). Is the machine actually little or big endian? Honza -- Jan Kara SUSE Labs, CR