From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EBEC71136 for ; Tue, 17 Jun 2025 12:23:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F8516B0088; Tue, 17 Jun 2025 08:23:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D07C6B0089; Tue, 17 Jun 2025 08:23:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10D696B008A; Tue, 17 Jun 2025 08:23:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 04C806B0088 for ; Tue, 17 Jun 2025 08:23:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B36901A01E1 for ; Tue, 17 Jun 2025 12:23:14 +0000 (UTC) X-FDA: 83564807508.19.87D6685 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf01.hostedemail.com (Postfix) with ESMTP id 97E6E40006 for ; Tue, 17 Jun 2025 12:23:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=BKeTHirv; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750162993; a=rsa-sha256; cv=none; b=Li6MIqdEySY9NzuIYyWnRCsKPEAd59yipS/vzbiBD2xcGgi0riS3gwkSS6ao3ZUMEkjCU1 sEUkpCGuUqcoWOH9ASaw191hvYXKvlQVja+d1hOAkT8OQBN4Pale/1DVRzkX8/WX90R/8n KIQVIsMOmdZKoARayapYf2WowXjyCTI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=BKeTHirv; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf01.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750162992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=21Go1wj0x49xdQOFnhkIKy1MZpMdJcDxWBqyIqwuot8=; b=Vnoj+dLUH4AItXczI/lKHt/9Cc9iCAlsbsVJGoM4ij61HhksaJ2cj7gjPDSj4epFVaGqq4 uRCShOuArAcRpDZ9Qccmfx1ELRkACYCQz/3ICZdze8vD7jvJoG3CXpFEnaAccv7ebDX5EF xLk5OZqGlrqUyidr9tCHpM2FKEhIi58= Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-451d6ade159so46894475e9.1 for ; Tue, 17 Jun 2025 05:23:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750162990; x=1750767790; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=21Go1wj0x49xdQOFnhkIKy1MZpMdJcDxWBqyIqwuot8=; b=BKeTHirvh1LpSpNGtqe2JdJOnBgeqVmRny3/bcyZYTpZwSETGtgpfGnMYpRxKf0ahC /iC5GOai6hGiNJsfptEwreg5DLX/TWNEt01cWsjVaK1DFlw+6ObUlGTIoF9C5bMBHvRb 7bYuRulm+0kwlvgoNgR7DmtaWoeMbKRrkuEJmSKB23cC76/s46eesz4brnXxxDP1OwoN dtpBs3+YgKeVXNObK9F0IB8DBRpqEwFvSU1nR7RVI2rjr0UosZh+TwLS4+zlAxp+C5GQ 0sAAZ+zRDYCu4k//c9jXgsazsQsHN0Dh1IM6Da7wmW0JDGoe9b73YdMqfI2zj2T8i26j 2uOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750162990; x=1750767790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=21Go1wj0x49xdQOFnhkIKy1MZpMdJcDxWBqyIqwuot8=; b=OxZhKcBK2H1Nm4X26kOgEte2SZ/nWI7o1TUzKSERwEpzm1E5QNRdZfziK/7xSrDdFL ig1vvAf36s2YsaYvsxH6zZtEvoi3HNCe5JjEb4M+TxZObhiA9gh5Eljbjg19XpBzeC9O lnEl9VdHN9oNR8xyGHmPrtky4KuAM+loKftjFnV2UH1spmCzFLU4EmYVvuD9BTRqinyS 13dsTlRi73eFrEVlOLMBgy9xH0xDbwqWXvbjXHUUlUZsB0AIqrDdUDWasqSQU85SBhPl T3GFpgEkqQmM8ntK2KMvXLe8YJXuhExZN4gmwbQ3p9oE8fFt0bfgzqesMreug27cfD57 3czg== X-Gm-Message-State: AOJu0Yw1M69udcHo51G7OtqrQPM9BwumCGXowUv7vz79lhFTnEwXD9n1 rTo+VXRrK2qFadD20GF04R92kXL48UNLWFBT6tV0ugbYiy2XgkDHrvmrYhv+crvYKig= X-Gm-Gg: ASbGnctZ2f9FoTdRsIIiesfjOHSEvFOsvDXlVV+vCLAGI8KF6U3eVIpJpA2tnqIaHX8 HBzuuASv2cr0UE1X2L9CEGAkF7+UHfyIiiUILuidFwbHcDhi+KIQcSeqmhcGTDHKOijUZxTgisZ Au+kJGYVb7K15dVMZfyXCny24euhxVbRS8un6Bf0891/zCv8yx131wAuyGI6234/5ki48T5weZM JAQZ1siGoivKvGzxPylFnLR2FtceGDFHVbrClfujLRu7YysyIirhd/Olb/DiaxN8boc6LAXZTjU zEL8gMwczyvyQX3cfpwMPdCwhiAQyQDrm2b5uXmhomeZLKnOVdnUSialIl7HN3T8RpAePwJ5vvU = X-Google-Smtp-Source: AGHT+IHemldAx08RKX+2t2fiuYieKOkNAzOmNF3+c2oFhTT/lpYZSkgPImE52/XFg7cSXUZMXu6Gcw== X-Received: by 2002:a05:600c:3587:b0:43c:f70a:2af0 with SMTP id 5b1f17b1804b1-4533cb48951mr120152275e9.16.1750162990026; Tue, 17 Jun 2025 05:23:10 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e224617sm176822635e9.2.2025.06.17.05.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:23:09 -0700 (PDT) Date: Tue, 17 Jun 2025 14:23:07 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: youngjun.park@lge.com Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, shikemeng@huaweicloud.com, kasong@tencent.com, nphamcs@gmail.com, bhe@redhat.com, baohua@kernel.org, chrisl@kernel.org, muchun.song@linux.dev, iamjoonsoo.kim@lge.com, taejoon.song@lge.com, gunho.lee@lge.com Subject: Re: [RFC PATCH 1/2] mm/swap, memcg: basic structure and logic for per cgroup swap priority control Message-ID: References: <20250612103743.3385842-1-youngjun.park@lge.com> <20250612103743.3385842-2-youngjun.park@lge.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cxa6tdutywia4blb" Content-Disposition: inline In-Reply-To: <20250612103743.3385842-2-youngjun.park@lge.com> X-Rspamd-Server: rspam01 X-Stat-Signature: duqrqh5bwsiky6hcn6im5quiqm4nbx93 X-Rspamd-Queue-Id: 97E6E40006 X-Rspam-User: X-HE-Tag: 1750162992-150660 X-HE-Meta: U2FsdGVkX181258T8+uocewXdBHvHccTSsBnXXz3zCf98Qr81+BJYjUt6cPkPCBtoRz5JaeyH7M9bXsTvvy1TaMbYrq7l3qaPQks/TFw9ms6RyHvvWz4Jo6glowPAQEL2Chtx99Fsj0IaahI2FsUb1cUvg23fIySZsEcLtxioBhehG16k0MBjkXI/6xRudp5NlqdmwmSQiD9F0ncbU0ztVmWo2+dPPGQzABdX5FKC9Li/CsA4vhfFIKo3wJUWD2Mfo1MDbmBOptM4L+g+T+AJXGtwZ6YHrEl0PZIdMUY6TwdawigLFVbATGf1ZvWHXToL2R9LS+O4j+IVK7kRslyzry0ex78GG9vnGfl170iO770H+h5TseDSV3AR8e1nDmFC7pGalgxsrne0oAEkv5LQRCHLSs1zaiYkf2/yYXgKnEc+V/WSZgO1iFv0guTJ7hmdsmACMnqleqim0eXEQErdBcXG25wRkJE6opmAK9yvMdoYN8KBs7s5bwnC4Uuno3iET36QyAqyAINhLanUDjIldhLrjFmb9sDMbBt9Ll1X/v2SELA1UFT3DOfuzxykXto05Kfc4UR9Vqz68ODDYgnCl/JVzu/neo43/ZVX9cDmkgL6nARpkllhdZOpgsrQIlXUQ4k0ZTQcaPo2dfymtU5zIWyOmwPNGswyGQRoXZ86wtbVlrAFUCnC60nOSjXjflxdcvat2V3n/E4Aato2qre0isiGX4CNGmpfgksmqqcL+k7N88cS3L9J/dG4wxiGERJZpamaJ1P0Y7Ip0qPKqVZH+EwUkiRNJFOEGpoA/Gi2//Xi2pvF8i/alu3ybPLA92SwULWVYGrPk2sPh64mN3yj/6II+nv1lAhn7kChHY13JU25YVtle2pSS1OQxczS7i8mrcP63uvlIQ/UF/evzoMpFhBzyTUtyntZQwNlAFVZQiATkN4SW7mvrFi43tcqrSrZuYn6muBoibkegHaofG id9ZL1qF jmfinaynW1phpw5q2a/ZGbD+SjxhEpq7c8VjSJjLguSEWDTNvBfrIzR/7IQp5bphhO0U5QIjhAmj+dMVtwDw+o5RJJmeO3kEReYOD4HtKcN409ILyQs382VfoCI7q7iQL5Ni6m7YLqVQCSEWzQzx1VYD3Ag1UdDpUwVaa8hQSmd/ZDSj0b6kOFCq4CAksX/cx79tEFmZpTvtnl2yvQJZPlZxEcolMXlNSPYtAUnG4g87jvhIYxze9SbWpkO/R+b0Rv773IB4fdlYmb4cRJ4FgocdZqWPbVPdIEZcJLvGc3XwH5w1ApMSevMD97n9Na1CS7n4smxQPBXiP1VoteTT4njKrFxIrsfil1tHh66iJ1vBkpwB3iP+S1K/nS6XxQgVSnxIhR4f/pXPDwaevtI3CmfgC4iJBu/FglkWAVYJ2YwFxyN49zjnpzQ2/bHG5hFooBX2zZopAbWSM4QU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --cxa6tdutywia4blb Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [RFC PATCH 1/2] mm/swap, memcg: basic structure and logic for per cgroup swap priority control MIME-Version: 1.0 Hello. On Thu, Jun 12, 2025 at 07:37:43PM +0900, youngjun.park@lge.com wrote: > Example: > cat memory.swap.priority > Inactive > /dev/sdb unique:1 prio:10 > /dev/sdc unique:2 prio:5 >=20 > - Creation > echo "unique id of swapdev 1: priority, unique id of swapdev 2: priority= ..." > > memory.swap.priority >=20 > - Destruction > Reset through the memory.swap.priority interface. > Example: echo "" > memory.swap.priority >=20 > And also be destroyed when the mem_cgroup is removed. >=20 > 3. Priority Mechanism >=20 > - Follows the original concept of swap priority. > (This includes automatic binding of swap devices to NUMA nodes.) How is this supposed to work cg1 /dev/sda prio:10 /dev/sdb prio:5 ` cg3 /dev/sda prio:5 /dev/sdb prio:10 cg2 /dev/sda prio:5 /dev/sdb prio:10 ` cg4 /dev/sda prio:10 /dev/sdb prio:5 when there are competitors from cg3 and cg4? Which device should be preferred by each cgroup? Interface note -- try to make it "Nested keyed" or "Flat keyed" as described in Documentation/admin-guide/cgroup-v2.rst (like io.max or io.weight), so that it is consistent with other cgroup v2 APIs. HTH, Michal --cxa6tdutywia4blb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRCE24Fn/AcRjnLivR+PQLnlNv4CAUCaFFeKQAKCRB+PQLnlNv4 CM9nAQChEzdekCNE43fNB7rnSRjzNssuFzuex9JUVSGIfGo09QD/e/YzVdE7mQ7l 29U75wiBDcAwyoo351mIl2azH41iKgc= =C+Kh -----END PGP SIGNATURE----- --cxa6tdutywia4blb--