From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD1CCC021AA for ; Wed, 19 Feb 2025 01:23:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DEE92801C7; Tue, 18 Feb 2025 20:23:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 333B02801BB; Tue, 18 Feb 2025 20:23:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2232A2801C7; Tue, 18 Feb 2025 20:23:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 058222801BB for ; Tue, 18 Feb 2025 20:23:37 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A9E04C08A0 for ; Wed, 19 Feb 2025 01:23:37 +0000 (UTC) X-FDA: 83134946874.12.537B526 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf25.hostedemail.com (Postfix) with ESMTP id F34BEA0007 for ; Wed, 19 Feb 2025 01:23:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xrskDb0e; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739928216; a=rsa-sha256; cv=none; b=hzrouu2JzF6/aYRfDISO4a1WnAQduPWbksI6HpVoHtWKcNRALSwOJcEOrIjQBD/uUyEuFf niZhvpq7XQg7O4GymC0jaFH026XqzY5xY5DxNrN+XrDIjt5xAJtVEW6xIWl4jHQKamz2Au BONW+E/p8/PqVjhZTCDCwovMtgxVf5Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=xrskDb0e; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739928216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ke++idLqL9qhaVRbOQX4Mzv3IAedX2ae7RUwDB45D/4=; b=Lrklm/mffHiKHDt1wvx69qLh2CtXNrwO6dyhVl1RdIzHjCAkV53zwvlNBZ2ebb29TsSIGs DaOEOUhPtkhTL0+i+EqrzF1wdL3cZOV6E4W0W9veJvhpFQsk5vYVH4Z5ewa/m8SlJUbaWY sDVaoNe55L+zC80admeqCh53tMRzcBg= Date: Tue, 18 Feb 2025 17:23:27 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739928214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ke++idLqL9qhaVRbOQX4Mzv3IAedX2ae7RUwDB45D/4=; b=xrskDb0e38jba9ec+udSrYS35C7C74ESeuoRRWr9qT+48qimSAgnHxCvgSiy3jq0LloRJ8 Ydq3CHWRnnXZZpi6OHqGB/LmVhHdjeARil+nSojWmSossn+YwTWCMyoDyFKzOqNMdRJu4H rEg/kvig7A4py/S2Jna7yXZJFmw7HnU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: JP Kobryn Cc: tj@kernel.org, mhocko@kernel.org, hannes@cmpxchg.org, yosryahmed@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 01/11] cgroup: move rstat pointers into struct of their own Message-ID: References: <20250218031448.46951-1-inwardvessel@gmail.com> <20250218031448.46951-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: F34BEA0007 X-Stat-Signature: eko9d3ircbbunrzqyouz57g6txb5q8d9 X-Rspam-User: X-HE-Tag: 1739928215-512801 X-HE-Meta: U2FsdGVkX19vUJy6uF/TuV4hSlmX4AJy7JpDhgnLRm5QBaOW+JrofQliliYRLWDTmb3mnz9OZH6GWlX3kXu+MIjYu9/CiX59dyW+hqW33ibhswfr3yioZnykh6+lAZOVOmZORrdcIQ15RlBfYvq4WB0Xfwl1ScCY9jf53ZOLzQyNhK1021z/iuS1kHnSpgcQDv73MoyItZ9dmTRBO9TXeapL5O5006Z+vapGY9p9FJspC56Vhi7fgBekptL5WMYaoSPIh4RSn1Q2YghVzD+aqaPwud7oy0YCxF6jm01/J8Td3zcm87bHVyaMwo1zw4ZBXNLxK83DwFIIHJeGX4oz7YMFEzOh/w2XUk3uS9jmlGfGah/bfAibDEnuelVxIE3inNRhQ0PeCo1XjdVjRte4OVxFO4hl9uQU8rclob+cCCQB6g5lkBKlJJGFVfAeR4oqr1ptAW1DDfD2+lv7BVxA74Tl24QXM5Td0FrBLpDv4AOy0dnmRPtQjISQVne4mJAk4otiLUhxtQqwHBrRr8HT3nuYLod//e3AzgjdB4rHVzz6LqthxV5492EDBfFbv7dGJnUGz6vnhdMjzwI9p0Hc9Gr66t6cXchgSijLa2FWRj751iCzPWM0gKBFryzgUKcQoSVCpLYbch5JSjSm1KQgajsdwQn+U1ORD3vJV+tCKqhKe9Bmgst0UaQusYf39o1JaJurpFRLsOO6NFojHokMHe7bI9DG+vZyU942jDh7FIbxdx88RPNtm9bfqSkmH/0wBVwQBOm4x7ebw3UJcMQvVdJ1A0eNjYf+vgMchDRcMrIvgw51Y8JWJLTRFA8G06vld976Rzyi4EwdfuYUk83USqV8YEJPUlpUJ884dQul+wXqtofa9rAWE3elN5UtlrMGl+TezE9t51lRrZJeHZgq6Tlvu9vLnAFv5J7jpJ6d8h42MZ3YJetQrxSfuqxy8n1eJNmrhfsnXZtKgvQx511 LEskZ+v6 nqYHxRIPObuzLCG9x9M3rQant4Ez+uY4KETYuKDIXvkvUeG5vmJwVDtrc4gxcNOFWj86z/LFc1N++MgxgKEf2/9ktSzguZBCLc+y+2YjgnimAJXZRv27LilUDE6il6+e8oah+HMW4qwZOgl3KW0Zx6qYOYmygvzsMUdstbBz+PoR4yRMkb13cQyHyNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 05:05:52PM -0800, Shakeel Butt wrote: > Thanks JP for awesome work. I am doing a quick first iteration and later > will do the deep review. > > On Mon, Feb 17, 2025 at 07:14:38PM -0800, JP Kobryn wrote: > > struct cgroup_freezer_state { > > /* Should the cgroup and its descendants be frozen. */ > > bool freeze; > > @@ -517,23 +445,9 @@ struct cgroup { > > struct cgroup *old_dom_cgrp; /* used while enabling threaded */ > > > > /* per-cpu recursive resource statistics */ > > - struct cgroup_rstat_cpu __percpu *rstat_cpu; > > + struct cgroup_rstat rstat; > > struct list_head rstat_css_list; > > You might want to place rstat after rstat_css_list just to keep > (hopefully) on the same cacheline as before other this will put > rstat_css_list with rstat_flush_next which the current padding is trying > to avoid. This is just to be safe. Later we might want to reevaluate the > padding and right cacheline alignments of the fields of struct cgroup. > Ah I see later you can removed rstat_css_list as you moved the rstat state from cgroup to css and you don't need rstat_css_list anymore.