From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3755FC3600C for ; Mon, 24 Mar 2025 17:48:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47F58280004; Mon, 24 Mar 2025 13:48:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4082C280001; Mon, 24 Mar 2025 13:48:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 281B2280004; Mon, 24 Mar 2025 13:48:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 06643280001 for ; Mon, 24 Mar 2025 13:48:23 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0FFA280712 for ; Mon, 24 Mar 2025 17:48:23 +0000 (UTC) X-FDA: 83257178886.27.BF43A52 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf22.hostedemail.com (Postfix) with ESMTP id 1CCE0C0002 for ; Mon, 24 Mar 2025 17:48:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=KkYqK3Cl; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742838501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D2fnp6shvw9hnQWeNOFwj+HGFjOKb2GCTSLXK9jM82M=; b=hng0zerEcNTrRnF2FCaR6gCCO4yaXHoib7RR+rDtZ9vr9uvdM/9buwa+0CPGXVH/HmBO4W ee8kF7Qw9F1eyjxnFrY3nIqTKmiU7kabmdyeZV5cH91OzoM8QUSuXhxEEDKgWq5wJrM3cl Ow2TthhkPHIq0fuGmHwEtDTceEzSWxU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742838501; a=rsa-sha256; cv=none; b=2DB+F0mByFWdQGjN2sHv8VZgpO/ufUkxyuoOUzpPtXv2r5Au65m6ATGYYps9clT1/8FsHy GoMR5kqY6eTTqt0RAgbkU/D6P4XYN5JwMahoNWGNlhDtVfVpa50piqZslXWnkkTPNEu4NU GhB9ao/WiEHeS3mbs620wtnHhy22hK4= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=KkYqK3Cl; spf=pass (imf22.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43d04ea9d9aso21465205e9.3 for ; Mon, 24 Mar 2025 10:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1742838499; x=1743443299; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D2fnp6shvw9hnQWeNOFwj+HGFjOKb2GCTSLXK9jM82M=; b=KkYqK3ClXKRcWwyfe0enHjEYzW2abXAreMkeW+DU9XYA3gHIE0x824S39Sv737uc8F pIcBJnHe8BA1PRv5J/GT/khS1IR3BpkpWGg5FZEXyaz04OpKs3eBcdm00Gs9yNHsCx7e fHqrfPnbOpIovIyQ4y77/4rLXmICwv+SZRTVtPtuHv0P93u72ZzqTqNWa7+JzwvYGcqr td8ZqXYaYM6+2eEt4XeSn8mjUqu4ZLxLVPxQc1Xpwcpe6xg4GlIPupIpJD6/vlleQoFq JMexppN75BRMrnw8MrDLy9qk/gsF535LngDs1TGsXoQ0Iq+EY9YIoyy94Tpo8ORi2Tcn T7xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742838499; x=1743443299; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D2fnp6shvw9hnQWeNOFwj+HGFjOKb2GCTSLXK9jM82M=; b=t8csYQnkBeYDojrwmNQHbchuN4ia48xiG3JwVwXaIn2iCW12oTFW2NWd0xg5gI2EY3 pG1sw+yYM03RlmJ6jOpQS8cJ7U4RZt2daNEgNnSuJ9fUEvN3M8ISXEtS3F8avgvHnRZk 1StFTuaL19Km3obyS9g+gUrylHSz0D5EOxbSPJw3xB928dqNHxFWBSVSPNGXnFsWcYNz HKzaSMnW3qtqNrv+FY1IoOqCqkZFEcFn5+XoHPjDsgv0NkIKkT+WJ9PJhpt6bC0iGN9y YysvnSysYmAvWLvNr5rhN2xZ9HavhEtjkJjwHJT02O1FJ28Qu0/CBocJRXxamH8BwUZS mF1g== X-Forwarded-Encrypted: i=1; AJvYcCUx6wYwU7bfcuNfeqCep3IfRLafU58XONdZnTH5oV4Hd3vH+8/i0A/mTt0UBxByO6nCCpGPtZ0eHA==@kvack.org X-Gm-Message-State: AOJu0YzJt/KHOq6a/OpL7hjwAfyOafeKaa0fr6Jf0kmSzqV0lWYtmjfc U4YnQ9ZZT5ng7GnCVMgrujvccNyH1XrbeWeqf5xp22vc8iGMBeINfNUERe0eJGg= X-Gm-Gg: ASbGncuCwkyv77ihI712K18dUp+orWa5PnbTQV9P4brxiuFSc/MqP8Ov5zpGCW/B9pz nEivQpnlPYoEl8Euywcu6b9T8SXAhVBW5FogrICF2K/3HCAz3E0yiHAtRhxwJWRIB+9ftArzq7g Evms2rtJTJ9KK5GAxN06fJ0YwJH1Il1Bo2zc9c0V7WpD4OkawaRMpbfxYrlDGM+w0yHJKBYRhFr v5XrWqkeZkW8KmRC6Y/Nb+GMlgkh0KGYb3cQC029T3oVBah4tKG7Ayc3rUXKvKAq3rOQjQCSv3u idIRaWMu8w0wCeB8yr1/p/tH5l7UrsI16kYqZVXGAaeAVv+/+23t/tlBaw== X-Google-Smtp-Source: AGHT+IExAHqqsKOcxE7n6h/EWdZmTNJMD3wEo3cTebnUNe87wsJOe5/915dDfyOx/qiguLvpWVNNzQ== X-Received: by 2002:a05:600c:83cf:b0:439:91dd:cf9c with SMTP id 5b1f17b1804b1-43d509ec70cmr161589055e9.10.1742838499485; Mon, 24 Mar 2025 10:48:19 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f332adsm179041365e9.3.2025.03.24.10.48.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 10:48:19 -0700 (PDT) Date: Mon, 24 Mar 2025 18:48:17 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention Message-ID: References: <20250319222150.71813-1-inwardvessel@gmail.com> <20250319222150.71813-4-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lpw6po2lm5fp2lam" Content-Disposition: inline In-Reply-To: <20250319222150.71813-4-inwardvessel@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1CCE0C0002 X-Stat-Signature: mf47z135bi6xmf1eius316i3fg3qtkto X-HE-Tag: 1742838500-950776 X-HE-Meta: U2FsdGVkX194CrPQ87TMPNl8lnTfOo9xc54Fr9eWLpBMzrfRAUHYC57SfZ13BCpKPr8h/BsJ6b9KyCdc/bIwucNyFO+C+sRU1Ybjj8C+x/tglfsz76vnkrbQFxEsZyOHQ3ZfriZLuw/jm4NrQt5VfEFB1usZc29pPpk1pdEfKQkYlh901/9DfWfItVtXnpkAW84t7FuhbPSiu//6lp02XyE4DDqTymdmrh6AJKfRKnX6163Jt4YfKrRcGUg7FmqQlXSuIKJrAPPt+icYmN66fQfgaru4k/w2n/D4nhDt1IJwRVJi74cqg8Kmk8orF4e+QtZmmvUIIMC+3pqJkKCRdcQ4qzVuM8+yAT7RXf/iweyZEO/cEBoKoKFZyuYb80uxgHB9P4kNLtO6G+lBxfroQ/7z23pL2ct9z55eRNYdcUL414n0VdGXczQ6HMmP6OtAlInwW5R0dQWr3miaCyGWi4Y2r4mru0RHtFpDAx8hr4BO0DR9NwwqlrJM5fjfrVXkIGa8Me3EHA/zsnU3Ix9/U6+OC9wh573U7KfmiP5nMGdjFp2O+6v+8xreshhpTG96tcAj+ItKlk16p0I00NBk/AWTVM7PvLoLuE3mYHjBDaKxuYCKbFRSpZwIBAHQ0HVJ/GdaWZ2M8if/kyUHRH8dx/ZOJQA6FEhQO2gOMr4jjGYHnwpwqjZ2dr7bYozHTTT1UxWfj32wwotrf2e4YFm6/IgI7yskF8b4m8/WmcrIPZz03ZPGnKqK9ECYOaURYmooxFRwMavw4ZYtBmwwLguJbM/vgWi154GKEQ8Lq93XuHyfMXXOSGeCoikkXA+62AtjjLH0OPD1a1o1kkJdfwIskfUntwEcADyvA3gwo2Uiwd2DJINVApjn1LOH0jJB0lwW40TzBPJG6HrHYHSGBw76/DnH2NKdxGy6leNHLi7/XakN569Q8V5As2+M+n3LsX20R+A3tXBxx7zF8712vEm yZaMkI6U 5R57xFkjA10+n51H5j4BxgLNk9XSDpHf/Dgaui7QIAs7MmtrnsBkf9lkeF8Y9eVyJZ80zGfVeASFYMLvR69E/e3HBc7JahHqXSVsDRfQ33qsj+veDv8sxMeLnrcFCny6R38TEHd7J+2vLXeLm9LP736EzS/0iShkPMbsay8vNC4WlaCGsjc5CI4QX13YY3qLgFHWNOtSR0HTmdrsiQHLdv1dNHZezxwEQCTw0xQoR1d41ZXYG1oGT0cXSEFUdis/a/Bn32LLzaz4TpX7UxNnGxq3vIsaSle2lalApz0p/oWt+AXRWXnVa4ADhkH5AQvpfVCsp0Ud28uXBODT+Z/JmDTM9ZXC1Z1gpBwcjoMrtrmHzEx3vRLUW9pwIypBDkdgD3rjWfe0n2NaIWF1VUvqb5/Ex11yE/G++ydhTu9aOk6ye2lHFALw5BAkKYKS8mIGlbb79X6Xuovx6LAc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --lpw6po2lm5fp2lam Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention MIME-Version: 1.0 On Wed, Mar 19, 2025 at 03:21:49PM -0700, JP Kobryn wrote: > diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c > index a28c00b11736..ffd7ac6bcefc 100644 > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c ... > +static spinlock_t *ss_rstat_lock(struct cgroup_subsys *ss) > +{ > + if (ss) > + return &ss->lock; > + > + return &rstat_base_lock; > +} > + > +static raw_spinlock_t *ss_rstat_cpu_lock(struct cgroup_subsys *ss, int cpu) > +{ > + if (ss) > + return per_cpu_ptr(ss->percpu_lock, cpu); > + > + return per_cpu_ptr(&rstat_base_cpu_lock, cpu); > +} rstat_ss_lock rstat_ss_cpu_lock (judgment call only) Michal --lpw6po2lm5fp2lam Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ+Ga3wAKCRAt3Wney77B SZYGAP9LUeQCF4HCTFUtka9FD6zGHaRPoUOtugfygxxe9p8oiAEAiTLlDTgTEUoE 7s8ddTx2wfezw+zc3VWeSYokTOF1xgc= =yZiy -----END PGP SIGNATURE----- --lpw6po2lm5fp2lam--