From: "Michal Koutný" <mkoutny@suse.com>
To: JP Kobryn <inwardvessel@gmail.com>
Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com,
hannes@cmpxchg.org, akpm@linux-foundation.org,
linux-mm@kvack.org, cgroups@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention
Date: Mon, 24 Mar 2025 18:48:17 +0100 [thread overview]
Message-ID: <p7uojyqriqy5qjen5zg45qxggwbnrvdf32pyabbah4arai4vin@g62jjsikdcqw> (raw)
In-Reply-To: <20250319222150.71813-4-inwardvessel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Wed, Mar 19, 2025 at 03:21:49PM -0700, JP Kobryn <inwardvessel@gmail.com> wrote:
> diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c
> index a28c00b11736..ffd7ac6bcefc 100644
> --- a/kernel/cgroup/rstat.c
> +++ b/kernel/cgroup/rstat.c
...
> +static spinlock_t *ss_rstat_lock(struct cgroup_subsys *ss)
> +{
> + if (ss)
> + return &ss->lock;
> +
> + return &rstat_base_lock;
> +}
> +
> +static raw_spinlock_t *ss_rstat_cpu_lock(struct cgroup_subsys *ss, int cpu)
> +{
> + if (ss)
> + return per_cpu_ptr(ss->percpu_lock, cpu);
> +
> + return per_cpu_ptr(&rstat_base_cpu_lock, cpu);
> +}
rstat_ss_lock
rstat_ss_cpu_lock
(judgment call only)
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-03-24 17:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 22:21 [PATCH 0/4 v3] cgroup: separate rstat trees JP Kobryn
2025-03-19 22:21 ` [PATCH 1/4 v3] cgroup: use separate rstat api for bpf programs JP Kobryn
2025-03-24 17:47 ` Michal Koutný
2025-03-25 18:03 ` JP Kobryn
2025-03-26 0:39 ` Yosry Ahmed
2025-03-19 22:21 ` [PATCH 2/4 v3] cgroup: use separate rstat trees for each subsystem JP Kobryn
2025-03-20 21:31 ` Tejun Heo
2025-03-21 17:22 ` JP Kobryn
2025-03-24 17:48 ` Michal Koutný
2025-03-19 22:21 ` [PATCH 3/4 v3] cgroup: use subsystem-specific rstat locks to avoid contention JP Kobryn
2025-03-20 21:38 ` Tejun Heo
2025-03-24 17:48 ` Michal Koutný [this message]
2025-03-19 22:21 ` [PATCH 4/4 v3] cgroup: save memory by splitting cgroup_rstat_cpu into compact and full versions JP Kobryn
2025-03-20 21:44 ` Tejun Heo
2025-03-21 17:45 ` JP Kobryn
2025-03-24 17:49 ` Michal Koutný
2025-03-25 13:55 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p7uojyqriqy5qjen5zg45qxggwbnrvdf32pyabbah4arai4vin@g62jjsikdcqw \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=inwardvessel@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-mm@kvack.org \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox