From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC69C282EC for ; Fri, 14 Mar 2025 16:03:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A2EC280002; Fri, 14 Mar 2025 12:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 55361280001; Fri, 14 Mar 2025 12:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46AA2280002; Fri, 14 Mar 2025 12:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2C2ED280001 for ; Fri, 14 Mar 2025 12:03:41 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E6CB9C12F7 for ; Fri, 14 Mar 2025 16:03:41 +0000 (UTC) X-FDA: 83220627042.03.856B959 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf10.hostedemail.com (Postfix) with ESMTP id 19285C0005 for ; Fri, 14 Mar 2025 16:03:39 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fNsQGZuZ; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741968220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4CTT02FmBRZU5Cwt4ngsfM8t+ChpAnoBkXBi8a3BtK4=; b=mr4A7XbuymiKoYd/und6vuVBhvJQwBn3NY/OSbtYgYayMZDROI3SSeZOr23asNzRFdNUuh zCGVf9+3SCdHg5TKWUY5SJWwJRFkC83ThrqrlxSkIEVbqY9BM5IjfFsH1IR4/Ng6kIlGkR 5AIAolXeo5h6tRMuH3Lkb5im7SCreB0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741968220; a=rsa-sha256; cv=none; b=WTqqrBdSgNpR05dmXIqX6vvMA1Nm5yvrDbIe76y9eREbTm9R9jk5oPOTRelUgLg2Q6FIw4 i2Wmy4NbBSujyvkPdrwDoeIZ0McHQls+ZrdbNnIrUbRFZyYzU5Ewmrpi1zPLCP/WksR0yV 1QxVzyQfqz6KX6ZVHQ//4uh+vkwWDKo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=fNsQGZuZ; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 14 Mar 2025 09:03:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741968218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4CTT02FmBRZU5Cwt4ngsfM8t+ChpAnoBkXBi8a3BtK4=; b=fNsQGZuZw0rPbHUA9iWBUzeGKeM1e6d1wSwp3NTHWe6TiwSharfI8h5jWYjpDXAabMK0Gy mTMmj6SOLuD7KrbltqVnmCsPtraLDoccquSeUDHX8G2gTZCJH7exSJB/NdUqhIVx/u+/zy 9+j7jpTXodhAJuFBWyZh3QZ7Hi0x/hU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Vlastimil Babka Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Sebastian Andrzej Siewior , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [RFC PATCH 00/10] memcg: stock code cleanups Message-ID: References: <20250314061511.1308152-1-shakeel.butt@linux.dev> <6bd606f4-cfe9-4afb-b538-26feb56f9268@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bd606f4-cfe9-4afb-b538-26feb56f9268@suse.cz> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 19285C0005 X-Stat-Signature: 7uso95wqybhp4nbquhrujecqbtkmecjn X-HE-Tag: 1741968219-732296 X-HE-Meta: U2FsdGVkX1/gH+CfyGJBNh15nFwPbhUclf95u3xH5YfF3YgJx10XoGAoRWAppDUtG0cHah08+3StkrSp8JN0ZDuN71SjwWJks7xu63KKd0OPL7OkXSRby9Eyi12ZA9odJcEjLFA8+SPqTlt/2Zj28yXdV0huJNIjdF8DYSzwAU7Jd+tF9qIFjCaNRbuVJ5bjZd3BExFMpZhcKyqafTdM2YTCIBntmVqX3fFOQ1e92I2DE7fju03DbBDCnh6oNvOof59j4vP+ty7MjOqw9DqlGt9Qw33K76aMqPbvQ3ApDnJxSUUr5uN4LiL3gISQJ5ddAHbr9MIDc+vIu/yF/exB8aYuC7N9E1a+ILxHdqPbP9IpVcvjdfBOtv153Jl7mCyUAepv012YPy3CyF93Fd17gi0sYhWIJDKVHdZsrqrEmI8sJsFuT/0AriRp6TrelFS3c4ek+spiNLUqYFDZdO3Q2g+i7NvJwmiLd6mE1F8w063el0UXUjo5HlWB/XSO3OQmec/ZRdYKrTOENW2HSB4p1uQyCn+TbO5giceH5OfwXUiRnFgY7eqddfWfBwIHd+w33iffIyQpaoBXP0+RoryXZkUTZdWTxKgKaq1wFJlQkuNRqLRGOswMa9Xp14bTTMFO1W6cvf54lpPhCSxWsHVeohIQAuYn0k0bUjuM7mqnSt8wMa/sjmchMsfOm1XxuiRNjXz9b98+ay7+QNNGeOUDGit9wahNeqGuNAPNpbDhMkccHlfa85GfBBm6bEKworaCvXFCpZZKZrbHZB4ILeN7KkBWRbTKkn/b4BBeRMfwhMwRlew/z4firH9LV0d0GgT6dyG6PRsTsCIY7zXsvOOuVwMtNA/Y/V4bH7/k1Fos0Mzh9e3u247cU8hjizNvvQK2KgsBeKhn7BttBRU40hcY0v3qI2l99F9l+jaRth7rqkY1UguBIigazWvDb69UXvCVJxBpJCYmQe4zdqtfCaO ar3IEiTl Ca9X//PZP4G/3QoxaGBP/ZIo5RWzdJ6dqHm+xUTC3Wb1PAe6AeUez8ya6tMasgpghpqdyI+bOKS7rtB27WAzRQXWxzXp5nLZ9G1OBOMvbB4Mm9HbHaPv3pMGCVn7Sn1vyiMkt7AVp3HRGE//4WRm3wzpXK+lCWEkrbiX724+x0bmO4hXQgH4Aw6dOQopyFdugJCimEV5Y4HjC6k8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 14, 2025 at 02:33:28PM +0100, Vlastimil Babka wrote: > On 3/14/25 07:15, Shakeel Butt wrote: > > This is a cleanup series (first 7 patches) is trying to simplify the > > memcg stock code, particularly it tries to remove unnecessary > > dependencies. The last 3 patches are a prototype to make per-cpu memcg > > stock work without disabling irqs. > > > > My plan is to send out the first 7 cleanup patches separately for the > > next release window and iterate more on the last 3 patches plus add > > functionality for multiple memcgs. > > > > This series is based on next-20250313 plus two following patches: > > > > Link: https://lore.kernel.org/all/20250312222552.3284173-1-shakeel.butt@linux.dev/ > > Link: https://lore.kernel.org/all/20250313054812.2185900-1-shakeel.butt@linux.dev/ > > > > to simply the memcg stock code > > Hi, > > I've been looking at this area too, and noticed a different opportunity for > cleanup+perf improvement yesterday. I rebased it on top of patch 7 as it > would make sense to do it before changing the locking - it reduces the > number of places where the local_trylock is taken. If it's ok to you, please > incorporate to your series. Thanks a lot Vlastimil, I will take it and add review tag after reviewing it. Andrew, I will post only the cleanup series soon. It will be based on next-20250314. If you decide to take it for upcoming open window (6.15-rc) then some coordination with bpf tree would be needed. However for the next window (6.16-rc), I don't expect conflicts.