From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9697C71157 for ; Thu, 19 Jun 2025 00:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574A28D0002; Wed, 18 Jun 2025 20:07:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5261F8D0001; Wed, 18 Jun 2025 20:07:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43AF28D0002; Wed, 18 Jun 2025 20:07:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2E41F8D0001 for ; Wed, 18 Jun 2025 20:07:11 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00BCCC0F41 for ; Thu, 19 Jun 2025 00:07:10 +0000 (UTC) X-FDA: 83570210262.27.601D0DB Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf06.hostedemail.com (Postfix) with ESMTP id CFEB118000F for ; Thu, 19 Jun 2025 00:07:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="PWc7/Cfz"; spf=pass (imf06.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750291629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TN4LO1bJYNfPoUQFGuQUYNGEvypwOvZqTrhYfCptwc0=; b=A9WCAkmAevic6A8d6yGsvb1juneKbRGpseYE38xiVVG+NtBwToSRhuPn08d1yAyp/jVr6V Yl92A2gKQsIDNqv8HKlgC3NDmc7yfom7MF5N1bVqh00Ewu82YyrAmqYZxDrqFOSu3kjmkt jnAIFqkytLQ0VGHJyNJxQeBePGOEkKU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750291629; a=rsa-sha256; cv=none; b=NfJJSDDgPrrT1PKnPUlCGMEEdny0Y1a7VaLC46U12JsEX1n8Fh9FhBRNX592rgYJuVB2xr IWiqA3D6eb1tIAH9mt/z3MSDhMkb5Z8o8Th6Agaf69O1j68bCvdwBzG0rfnpSDOMk3MxYZ tz1cS4CXGHRwX3EOjuEvoyE4gRBEf8I= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="PWc7/Cfz"; spf=pass (imf06.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 18 Jun 2025 20:07:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1750291626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TN4LO1bJYNfPoUQFGuQUYNGEvypwOvZqTrhYfCptwc0=; b=PWc7/Cfz+CLd79m5ei3qSW93QKVKnoK8BebDTuty+ENe9uE/V5mAZhSUXbOiLjHyE4aSl9 s1BkT/HIvGTYjbKAnQYZUdiBK9kHf7FHmSBkds1rZzLh1SkNBr9bHj1qz8Z3UFKDsvzjoD 8eYjLAr3AvhdQed9aoza8hgIWNDnQNs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andrew Morton Cc: Zhongkun He , mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: rename the oldflags and parameter in memalloc_flags_*() Message-ID: References: <20250618070328.2192849-1-hezhongkun.hzk@bytedance.com> <20250618164334.54616cb2d70a1ee3c1f28a81@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618164334.54616cb2d70a1ee3c1f28a81@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Stat-Signature: 98kz9gj6oyhw4bwizi75r9pgt7knegrf X-Rspam-User: X-Rspamd-Queue-Id: CFEB118000F X-HE-Tag: 1750291628-121886 X-HE-Meta: U2FsdGVkX1/5k6jVMEt+D9E9VGGcQM1Ul5KP1z5gBwjP0HoGTqGSvTpHObRm7RaZpUXS690sb5hKcoYTEjxQLTendbwQMl7tYh3l2nGB9ssYtOUnfnK0w+LYiiyvahMapDLhE2IGvS36Sb7iJQcq1YW09ib5xIpkhd89FAIy0LaTM0T6dhbx2HQIHcjWCg9tsOEYgswNH0PfqkBvaZk8caZpGyBKKnpZD1NBQcJXcVEJAQsVR2TDqwvhPyB4u/y0YwFcM3I7mMThuREwD9y0yF+HXfWl3nJV19GdIIyYwKQwhZq/GaORwQQHPb+uMThoq26g8Nml8o9yrBAtgXp1CoBnl11t2THDzy9xSgh36qnUCLMrnIapw9beQhgX7zmwgYZeKOR2jDt72aL3sfY6pBeqGi+p3sELzYYm9sIuJCRIuetjIDnATysPFMDt5Wu8d81AREcv0Swmc55ZN4ht5XH2fu098q9EG1Ro/Tm9qX0+WYShxKFXjmnFPV6QZc6U4NjWGU3yd9W6+C6+uamaOrjgvlIpQv+yVr61he+tZIhcJ2AdDaJizRSIKX6jgfcsIfEbq2aLrP2hQqH+6kS7oUGcEZMwtRWGKpzGMl79hOAGr3DW07yaNSaTic2FqZcTebvYJ1+hzvOHXAy0NtFvskTd6TSj4hwTK5eGlIwKwkIg6yJ4vaS4144N0783vfIvT6fUQk11e7jmNx98I8WzxlE7/dQIhOAzAdWsFHQxB/OiXF7un9/CbAgxrPm4/OCBm036ndONS5n0yOgJCzUivXPONznHcxWFSkH9zu20uXKwLwrSvBMh/pyJeRIi0h+GEoEtVBCmc0iI13epmUOZ4UErRoaWcHGoHnFefyRdXTs7Ccf0y8bvKZy2cp/spFo9ajTakLge3UPEsPG8JwcHGWZiMRk43mz9uRaPisqAJJWDhPA4uHw/uNs6wt+uEgQJZBcDOp2YgvF70DUBiTi l//I5tjy E4U6NUOoTIMJZRgo3+6w5KNQ1Ni1h2PPgTBmswLMBVTCHjXU3xE7eCkCU5+h19k3es10r/vO7DwzQ+RBTfmxSAgD21Hbwnt0M5B1ycyrIiwJBGi/DEA4TCEE+ed+af37fljsv7WAOmcSC/2DyfyXTKmYjm2Ib5cRxBwh1gG99aNukxkOHv73weiL8nsr90Etsq6u/+nyPGLfNPEnhHOEZKLUb7EbXme0+erHsGbwZblQIApFS4B4OAiPvP1G4sfggVk9EklpmZYubusq2EQByt2b0pQEd9GomhHo/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 04:43:34PM -0700, Andrew Morton wrote: > On Wed, 18 Jun 2025 15:03:28 +0800 Zhongkun He wrote: > > > The variable name oldflags can indeed be misleading, because > > it does not store the complete original value of flags. > > Instead, it records which flags from the given set are not > > currently set. So rename it. > > > > Your email client is mangling the patches in strange ways. Please send > yourself a patch, figure out why it didn't apply? > > > --- a/include/linux/sched/mm.h > > +++ b/include/linux/sched/mm.h > > @@ -322,21 +322,21 @@ static inline void might_alloc(gfp_t gfp_mask) > > } > > > > /** > > - * memalloc_flags_save - Add a PF_* flag to current->flags, save old value > > + * memalloc_flags_save - Add a PF_* flag to current->flags, return saved flags mask > > * > > * This allows PF_* flags to be conveniently added, irrespective of current > > * value, and then the old version restored with memalloc_flags_restore(). > > */ > > -static inline unsigned memalloc_flags_save(unsigned flags) > > +static inline unsigned int memalloc_flags_save(unsigned int flags_mask) > > { > > - unsigned oldflags = ~current->flags & flags; > > - current->flags |= flags; > > - return oldflags; > > + unsigned int saved_flags_mask = ~current->flags & flags_mask; > > + > > + current->flags |= flags_mask; > > + return saved_flags_mask; > > } > > > > -static inline void memalloc_flags_restore(unsigned flags) > > +static inline void memalloc_flags_restore(unsigned int flags_mask) > > { > > - current->flags &= ~flags; > > + current->flags &= ~flags_mask; > > } > > I guess so. Maybe. A bit. Kent, what do you think? Eesh, seems like pointless verbosity to me. Maybe don't change it if it doesn't need to be changed?