From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1727D3C92D for ; Sun, 20 Oct 2024 22:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 55C9C6B007B; Sun, 20 Oct 2024 18:00:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 50CA36B0082; Sun, 20 Oct 2024 18:00:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35F076B0083; Sun, 20 Oct 2024 18:00:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 17DEF6B007B for ; Sun, 20 Oct 2024 18:00:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 391CE161419 for ; Sun, 20 Oct 2024 22:00:32 +0000 (UTC) X-FDA: 82695350850.28.7BD03F2 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf06.hostedemail.com (Postfix) with ESMTP id F2CD818001B for ; Sun, 20 Oct 2024 22:00:34 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="gzI/G+vA"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gnrWd3Y1; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729461497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tSIMJqI3PWwzoEAsJ+kHOGWfZQT1LRR5+CI2sCaRNnE=; b=ebNRc3z7/WjIGLA5fNof1qn/cIQT2zqDS0zYAPmwH7sOO4u1ycaeNnsfv1xfWNQZ7X+RiB qCU4KyHz63Op8PFy9zsaKCUU/E3PnkoAF2vvulgxU5BLj+VXrt3aGW/vL8uR3/IFae1VUY aAZcYrG0xSgwPGZJkFFVQyJKVYMUnRc= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729461497; a=rsa-sha256; cv=pass; b=4f9oHW5W6xbwSlpgosCpZGC19qHNyLY6KvNgAUaIlVH/zFkaj0SKT9D25S0kixW35apxp7 ka6D7avbN1A5sCJN606TO3v7ONU9GB0eIp2sK+0rlIuE//mkMdtvovp+4uP6c2oVndXadY 3M0JpPl4rP/kKMOsQadOtWo+HGWm/q4= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b="gzI/G+vA"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=gnrWd3Y1; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49KKo1rE021940; Sun, 20 Oct 2024 22:00:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=tSIMJqI3PWwzoEAsJ+ kHOGWfZQT1LRR5+CI2sCaRNnE=; b=gzI/G+vAq6J9ANWhpY2fVbXdRynGWZircM DO7S4APS7QmVSXsnS9z2+g5K6IwnANrxhSx7FIQ+Q4wNcGcpANzEryk56NY7ZKFc mtMw26obPkzfteCc4X81VZv8eNd1oMlrzYfIsHNSvimjcvIq0+SUgGg1Y8U0PcaW ICCsd3+MwO1NCSQQ+ocHxsnYGnIHc6fEE6CkSqF/0oYbWYX/b0CySWRKzNpT3Ltz PDwbcuxgHXiK4odf2XxF6yHD+jX07gt9l7FfurQShurlYgzw6VoR30B29488eM6x /GcjjBSM06yFyroqcNoEsNxD+EIx3XWVSwAH9ereqYdoR9iyLutQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c53uj03u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Oct 2024 22:00:42 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49KKe9H6022738; Sun, 20 Oct 2024 22:00:40 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2172.outbound.protection.outlook.com [104.47.73.172]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42c8etf7yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 20 Oct 2024 22:00:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ea8ngXaAK2owioPHZZBulwGMCOxg2wwCePfUe0917x9lhxPoVF0CNvAwYQGvc5dQVIXZCGpQhe00YWbwHTceMLfIanMSNZh7I+WK8f2oaHdm27wTqeOW/so1se5cs9vJjgTEhR1PWvleWaKcYKueowKSeMpgudRXFWc13K+pDVRJbWgyM/uZRjddL7Oymzv26S058fpnuCOOYB4bFCNLFvy9KLGnasfp3qndPu7k/bgPPTg1Z2tQ66ifHSKZh9SXrT6hfz0aMRjWeQNt+r/pkSIFIAM6XbrCV31wP/y1/czKVhxnUFFOWmvsLxAQhNZU5/2e3dwRcZQRzWMTUsu3IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tSIMJqI3PWwzoEAsJ+kHOGWfZQT1LRR5+CI2sCaRNnE=; b=mEaB38LA+amOXOAmo8eoxSGkcdavGPsFBVxlgpTXCDq8HYFJR1u8CeHFfvNivjgGbO83y0ayS5hDVaMQN2bMpJvnWCB9BqLoo8dCM4770SZknYEA+XxGFCPx8d6MkiaNzFxfVDtd647c3SMGsQDOTA7dIaOnn3vbco3Fqt7kozjwcDWU6iu3YxMmKaK9u9szDWzxK8d8H+7v6A/Md/jk9UdEjrZbgfvb+3xXZfx58e9Gd5u/kWlgqmNW+R+FmbElkzJg7ry5IU7IUam/v5t2wGsr4IheVj2NNZl13FPz7r7RyoQWraZ94coq+94D6nFnY7DNNCJ0CjD5VY753mjZTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tSIMJqI3PWwzoEAsJ+kHOGWfZQT1LRR5+CI2sCaRNnE=; b=gnrWd3Y1KWSvKxmK4QhoNPjb29n6/VLgsAtEAOHIvc5eB4UQ75RKScpkXoq72SRgsXv5nsgUB81nV8lo7cewSpZi/rg01U7i5cbJK8hig9ffnMQSbd3czx8dqZC7LDwJzzMdfqpU63OiPhl3Mv34ljwlXBMudxd6e7nCPkMPMX8= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by SA2PR10MB4521.namprd10.prod.outlook.com (2603:10b6:806:117::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Sun, 20 Oct 2024 22:00:38 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8069.024; Sun, 20 Oct 2024 22:00:37 +0000 Date: Sun, 20 Oct 2024 18:00:35 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes Subject: Re: [PATCH 3/4] maple_tree: use the correct min to calculate split Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Sidhartha Kumar , Lorenzo Stoakes References: <20241020024628.22469-1-richard.weiyang@gmail.com> <20241020024628.22469-4-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241020024628.22469-4-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT2PR01CA0022.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:38::27) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|SA2PR10MB4521:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b8bf062-1aad-47ed-1326-08dcf152a14c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?KOHG7XS7L8w7Lxu1twmVGyI7QOuo9/xnMpxhYSNUIBUhIP/20moz359qnYJi?= =?us-ascii?Q?AIJaJxMUD2FDQw/GJ1fAX1JksV/DNJxmnjImR/xC4DmR22dk18aEzqOO+swg?= =?us-ascii?Q?ofqO/tUtqGg43JuVGgHhFWKw1SrXawBvGD9SxxuV2MbH5OTik4A58OuVcVfg?= =?us-ascii?Q?ItZtB93yOdacZPK1bQNHdwXSXDHAZoRoqOTgzN2tWIJsTl34+vhgGByPdTxI?= =?us-ascii?Q?t4Gf0UAZtd8JgoEFvNyk15u659OaRqMLvTdLk17TU1PkajDOsYpYALCyb/oz?= =?us-ascii?Q?xHgFpFjGbnNNVKmKnW8sO+1TSogkGwR2UvJQlYm5f/IZD+0NuWksWsZM6qMw?= =?us-ascii?Q?Uw18lEoy4h8PIKKcfx56WDyouASnFHifg/1/Ww9BDqS8TcoNaYGSvZVN5AnA?= =?us-ascii?Q?oIaRsGcL2YDGDj5PGFLW4RD1E0J5PIjx9umDW1RLB+uPWTvEUZ4FWBIl/l4Y?= =?us-ascii?Q?UgkzRkA5PPgdmYwN2c0qiobpIjov5xCKS38wyX23CuI0msDG5kFhAzUC4R/I?= =?us-ascii?Q?wlvj8WPr/724hLCNKkdyDAQnKCEq98sjwhCmTVJUHkcQAv0tnEoQ3uTHCqsY?= =?us-ascii?Q?eY6WKzVYt7QK3B+z1RWCJf/F1Ac7eqk52S4D/xZwN0BIYdg7SyXavCKH+ae3?= =?us-ascii?Q?0j8uMuk8R5IGPyBgAPjWgF6SoKiKCtYyQMrj2TZ1Gy/p+gkT7Pem8LxZs2Wk?= =?us-ascii?Q?ldcSi+riIUChxiJM4lsHb/ZEJExrix+4xJ1wZ2P/av1zjmIP/50CgoWW3M1p?= =?us-ascii?Q?rZeFozwOju/UIEWjQgbjNMv0XHKX4t8yXzlkPI2Fspl4BvWsk+W/gwiUH7jn?= =?us-ascii?Q?xl0JeDoDAJVCbkPPJgPHvRI/KYF4Ttlp9gui+PPppuFYiulLSLbeHftpqmbw?= =?us-ascii?Q?/BUCcnuH3fJIXo1gOWQdnbHv/q1Hk8SWmWJ6tJU/eUHT3V0aWL2rWILNACAn?= =?us-ascii?Q?dC5bVxLOvhjug71rZ6UpSCgfn8xE9RcFfPv/C6Mi7VOQjDJdVziCMhkHQTKU?= =?us-ascii?Q?xpwkXPSrS2BaD565UoXjS5/tb1fipwjqdqjqYjeDy/hr8h0bw65bVX786Xaz?= =?us-ascii?Q?m4h8CrJ2Px68g3BUTciRHgrNiA+GitL5kTyPeJIFgfSPp5m2HiRB8Nh/lO9f?= =?us-ascii?Q?ESLnGgmsWhIGi2fzgy0LUQ1BHOo7I3PUnkTtebz/+soAM9eiy6ymzbKu5QK0?= =?us-ascii?Q?HJQsG0HizNn4pblvzGIinKhRSvwoteTyR9QbjG/VecN1wlWvXGzj0EF9X2cU?= =?us-ascii?Q?1i+YV6K81u5reZyCkldvtmDz5044VkMnavSXwYpGNTTNVmxKL+WiyyIoPOTc?= =?us-ascii?Q?lS3nrOjRawUT7DoB0G5hCHGS?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bGoQhLH7meViycq4hGhTEC7IGwD0GqClh2vsU79paFY/wRC8yGot8UJNUR3C?= =?us-ascii?Q?GKZT77xBcK8EXiYzkdVNhEXMHtvkJKsC0ON3gO3RZr/ot4nMv8mHGOP68dWw?= =?us-ascii?Q?ZygH8R4jPmtAenr/s2fmtQ+ENlGDcdlQijeZgjWUkRS4TTnHk+Ze7bSBK6dl?= =?us-ascii?Q?iVUDp4vZeaR78KglQi8k2lRdU/s40/AlfqnV6xG6YFNw0updDzfu7McVJjRn?= =?us-ascii?Q?ShK7XotZwAqE/ec5AwoFWCANB8Fys22hhcNrqAAwcFb0r0FV2W9V8Dc9mWdl?= =?us-ascii?Q?okEDkKgRTl5sx0UzqvHvwN8RCCjEplDUz4bqdDNKxZ5/Te9lxrXJbkFczbES?= =?us-ascii?Q?FkOF+8ZAgHAKVt7hxC2wJ3TBX2YNFubv7+igC8Tz2uHmT7FDykh6R5vOQgay?= =?us-ascii?Q?+qdsW9kBWvXDmrjZSQfLKbVfRciA5MdOkSF8DcL5VuWFEfwjC3TDbVG0afjL?= =?us-ascii?Q?KPk/ksFNQDBvOTf3ujYTFStVPN2VUp++XFneBwMa7hxJjY3i6bq3U+DmKDLx?= =?us-ascii?Q?hssR7gajVNV0ZNXJMHQCphx7No4k2wTenbUCifBHFZNscI80+PPgDnX5ZV8k?= =?us-ascii?Q?yyQDmGkEx8clMznG6sYBNC22K5atiw+fynTzzyEg2HRm3PYtjYcbNO/33eLB?= =?us-ascii?Q?9wXP/kxXOe+saOQKbhZdeENEt7T0XShvZXHnoIJw7/NQrWbySxU69Am35HHx?= =?us-ascii?Q?H06I0d7rhjXDQ10pvFcRbWY6ZXhccjfYfXLGpd7frgAkjrR6DP6BPXeLFCnZ?= =?us-ascii?Q?aLJ6BEIEZ9TcnFRM55p1CvREs54OiucfVbpQIbBbq3TJF49UmT+t5ZSaQgzA?= =?us-ascii?Q?YtRjjjsTlKN9WFr+BEWivKyvvmqwlcpbwWSScm6tuG3XuWFpy4yftqZgfIGq?= =?us-ascii?Q?dNCDbKCnv0/CAcMt6sKZgEBBFM5zJpk2kCfpiQrXI2wRNwYyZEr+PJHw5bC6?= =?us-ascii?Q?kDxhRMwacVqOqJ9gyOxqeDbvJRQblY1aWjMn63G/iz8PgDHbX32t8Vy2alvP?= =?us-ascii?Q?YCOIiAoRKSAFuKSfXhUBAgsApZjVeH2KSZ4Av9Scj1CaRdm9CuYUiPoahxGt?= =?us-ascii?Q?FdNrRH3L5tuF7Uz29aumbp0WMol4kalznQzN3FNnqEa2cZiOZPNjyRznVG8J?= =?us-ascii?Q?ZsqH43XjrFXeSQfjNCVjaVIcefMPtUtfyAkPX3VYxvP5pQNKGNYb7n5BEHii?= =?us-ascii?Q?SgXS6GySuXwxgkeQY2Nyz1plQgp/NIFKLNFwggCTbMNOjwmFaDEFeo2hVjm2?= =?us-ascii?Q?8TdWT0r6r/t7/rqqX3NEriisBgJTH6jahunV2WgoEqT8qJlXPTdnpgOJktXS?= =?us-ascii?Q?BTy3WkINlxG5iZrpjohLtJCdf25f0YAgEFMz5lzGQOxkW4Y7m4H2qFOn/Jxr?= =?us-ascii?Q?Dl2Z+h2rkWVLsCYXQuGiPPuhiNBMysH8OjciWBS0+y7UDpmN6nRC8Q3sMNGI?= =?us-ascii?Q?n5Z3Fq5RcNQ/GTNOMGbQOesIOzrGYJ3+uhB6v2ZEttt/P4ehqmh6zEOVpJrf?= =?us-ascii?Q?Mq1nf/uox5hHFP52+f2YzMMRjR3Rf0xCg7uG2b9GFpxLlvXyZp/lNDVS9CkM?= =?us-ascii?Q?j+OVKOkuu6blBwQwdMngX2MGma/eEEAEW/7PuEN/cjNi/i9/FVF8S2qs6HEU?= =?us-ascii?Q?/Q=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: NZswN8zlcCyHmyrHouJrgTeVsZiQu1Bhw1NvCO8NjUmqg2oIrRD64itmSRZmnzYTBTI4tPrt/V6T1lg0XiUE4VXtxSvdc8+dBpAXHKu7WCmFSfybTxXR3o4A09ypHUnouZlnXaZ/+z0TFWPa3yoZB98Iq4h/44ga6JT6nWHvQwfT9cEttFbBjEwdPAijxjgaxS4b8EThcjJgtEaDnDzersddwQDaoUsl+KSDjKCoV40FpAWFvvwzgw6v1rmS+bWS8vKlH+MJUixpFLAhW1cf98aow1OlxOMGxIXcTHsu2HB8qM+itiZJDfuqihNOKEuOW4N2CXFSS7tvXvp2DiYTytUtzMN45haHcFTUPi5v9pdWHAyaghMkUlKOmQbq0MthmJ1GF3P+1uqirdNmSQtJgJBYE4JgJ4uuh56h22m0qKMlg48K3SrIy13FlGXp7I0FQj661Xw05HUXLfFK922EUE4tbAY2kQTfNgX98bbhnqYCA870AwRZWqbKYHFJwI5XBIm2TS83SFpeDFC9QkuauS+q9L7adHqOXKRDITOlKRZfXjBfDds4ekN4XohCCm4JwlrjIOL4MSSHofoXFdC92u+1rQMIK747LGjHBKZAKxI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b8bf062-1aad-47ed-1326-08dcf152a14c X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2024 22:00:37.6855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UsMfIxJjsF3EuhpQlaqH8IzrPKrDzr8nzpmjeATS/+XsIE3fm041jJ75g8WRmBvTV88/9udajHeIQT2CR60ENg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4521 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-20_19,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410200158 X-Proofpoint-GUID: aULb_bckxnyrQTyUESPAGxiPISDBLK4A X-Proofpoint-ORIG-GUID: aULb_bckxnyrQTyUESPAGxiPISDBLK4A X-Rspamd-Queue-Id: F2CD818001B X-Stat-Signature: 7he7oh7q5y3abrchq6e6gkgyn4xakpmm X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729461634-625439 X-HE-Meta: U2FsdGVkX1/8wKeDS2pNLEQYI+M17H7Aq5OeNtWMnd0871UyS+ViY1x7HWtK2Nt5B4tXyrk9riAkhvQ4drf2s82UeTpMJzVJ2A8rVtAK1sSqcu1GdqyZjPiEIdT2ZFUrLbiHwUfqZTH4a5QKSgoU2xJoQZGVyG73pHSQmnG0I/778w3S8Z3um/pSXBEfK7YC0tuCUpfU6BXcFt9E6QFKaa/qEajSqTNA/O3gKji1U1pdXZnRpWLw+BZ3FgRKEMazSsyHh/3H6JIz79iE8PooFUcl8oiw5sJItZHECeMGzrLSwNKZ/g2Ca+ToJopvmKvsvJ7PjfL8v697d6CLPDF9kh1guNGv19Oj2mB6zB7i7ooXp74oHP0fs9gjJdRYEWzBVvc/EtnGjvPcdBF1HZ9xu0zvFVYz+Y8hobX+9pJKQlgk/6BYLgG2aPUH+fTDiOYX8x9ZM0PLsdJFuVmwaT1CibAF1Rh90juu2cCrj84c5OPBj6LJfaIzC3m5it2iuJvPdOUTcus+qZUuihq9xW9bNBf6CdW9Z+OjnFsT0HKsax/EkDw9KFpjdBjzaZfPMe7baN+umEn1W2Q1lD2hovs8UPM0GuFIzLhbqr7r6MLBMth3bn25d3N/97gzMLWSCTEJIj7A8WhezxUpnSY0ZsQE7agrhyeMmdKLlaqwa4F+8p91EF5WGaLJaIqGlwkU3fdLRSSb2NVWMyuYShGhfKf4IFWHKI9h7qKes2nKd9DXk/VQfHhjDqPh3a1RI4+O+OjZRe6Y6VpxPga4rfRqF+K/9lAwACP1tvfr9dMIzuMl3md1P/UG9b5sebubaoicPoS0h89HHJ009PJn1GidFX+WCSVQPn0WslROumQ60JX1UKWi+eRFWJfN5qNCvbM6HJlwmFZItJ/9Pt83d8kEUKzk2Femjhbyjs+hKCdfTJBpWcbNO86ekKGvQfmSfahyi2H+Ok0VegeDJ9vUyqGJ87y NquV1WWd stLOuyKY9TrHeNKHb1XEzBiHs0U9zaiikOlquXL+CIlqm/cu1DucL39S8HDf1Zt7MzzqRLIQPR++1CTk9PbkKOVkGmlHPhB9Xb3OL5PDPyNzSWRTeElc1Oy2YFTYrIgFql2SSuzQBLr1KDrl10/Kf7MwBbKo2cEG/YyY9+PRUxMVDKk+nErOCsQ2jVp9ZZTtBAFgHj+XKeULebQAlc1NSd/03AxhIF/2AcQJbdVA2V+GyaOQyiGhmEVPArEeMfsNnyzJjgMhtCWkP6MZL9RyXgY3yZE+U+woCy/ZK0CHHfyBdXkXznkBR62o1Z7jsrAuijGWKoa+caRwhxpaHsvPb8Vl1UCUeYcvi4DTnTa8yR66rwDSQ3VjoptJeIqNbMAsrrQA6OqEU6pVq+SygmJSp7WstRfu6f5SidfAOwubuPLNfE9Dqu3r6HeAUMMLObWXt+Lh6MmkV9GEkepa1p/Hfuy808N1fdj1Z7gx5m79kd84PRBbJP59XJ+ZeH5YdYX5JKpyFsi2Lgfj1VZlEHeWAsm3DlS5AQ7rrxOISuNvIT6wGZNlXuFjqlhBVCOYs9T6YMSfGpi28ZjK/ofc7//gjKvvC37AmEfkzYF1YRoBTSp+2DVqhgLnQZdlY3LZCPl42WzJkq+KZTl6iVy/cz2TkSPtJv457eIIs2hQJvk4LvN8Bnw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [241019 22:46]: > The check in mab_calc_split() is to make sure the gap between > [0, split] won't be too small. But we don't pass the correct min. > > First we may encounter a pivot[split] smaller than min. For example: > > mt_init_flags(mt, 0); > for (count = 0; count <= 240; count++) { > mas_set(&mas, count); > mas_store(&mas, xa_mk_value(count)); > } > > On splitting root for storing 240, the pivot[split] is smaller than min. > This result a huge (pivot[split] - min). This is fine. There is an open work item to make it more accurate at higher levels, but it's not a problem as it is. Each level upwards needs a better 'minimum span', meaning that the node should have at least mas.min - mas.min + level * something. It works today for leaves, somewhat. > > Second prev_l_mas.min is not initialized for the first iteration. This > means on splitting leaf node, this value is mostly taking no effect. No, it is set to 0. Not initialized would cause random data loss. See MA_STATE() in the header. > > Since we are now calculating the split of mas->node, we should use the > mas->min instead of prev_l_mas.min. This sounds reasonable, but considering what this number is used for, I don't see how it is working as well as it is today. I will need to look deeper into this. > > Signed-off-by: Wei Yang > CC: Liam R. Howlett > CC: Sidhartha Kumar > CC: Lorenzo Stoakes > --- > lib/maple_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index 894dc5e9436e..c2d4b188646c 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -3357,7 +3357,7 @@ static void mas_split(struct ma_state *mas, struct maple_big_node *b_node) > if (mas_push_data(mas, height, &mast, false)) > break; > > - split = mab_calc_split(mas, b_node, &mid_split, prev_l_mas.min); > + split = mab_calc_split(mas, b_node, &mid_split, mas->min); > mast_split_data(&mast, mas, split); > /* > * Usually correct, mab_mas_cp in the above call overwrites > -- > 2.34.1 >