From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12374C54FB3 for ; Mon, 2 Jun 2025 14:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8547D6B02A2; Mon, 2 Jun 2025 10:16:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C2F6B02A3; Mon, 2 Jun 2025 10:16:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F5B46B02A4; Mon, 2 Jun 2025 10:16:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4C3116B02A2 for ; Mon, 2 Jun 2025 10:16:03 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F247F140935 for ; Mon, 2 Jun 2025 14:16:02 +0000 (UTC) X-FDA: 83510659764.07.1644873 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf27.hostedemail.com (Postfix) with ESMTP id E8C6D40003 for ; Mon, 2 Jun 2025 14:16:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=E2j7HRAx; spf=pass (imf27.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748873761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pasRCSC32VgEjcQb416rK5+EN/XRXvQF7vBXVNk/1Wg=; b=7s8TwEPNlcvfVQMyLdYVPKcmPYV30fxYmxT00e4P8geA7vYs6AvMj2Z15vE26Lns5in8F5 vUQD8FpA5Y4AW8g5dP73ESq8t0M3yTUTWvZT6rm113i4XfQmsBDEZjZnaiJeD+iNSxyClq eLPOc89K9P5Kvf/dAfGD7zxtMMht65c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=E2j7HRAx; spf=pass (imf27.hostedemail.com: domain of mkoutny@suse.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748873761; a=rsa-sha256; cv=none; b=fB7K9vkFbSma6Fi/iVPJM7VRBfOoSPPHcDF3DKe2K1VNQ1U0mzHM9p/V6oJiyQeZzb7FYM Gl44YLgZCjxtJtUiOqU5+g/HhAZgNbZw0JBkOrZCTrPn/VppMciJbHYCuI8aYjZ7sg/Bg1 kBmkuEWzh0fOxXi46P2GwqE9hk2SItA= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-441d437cfaaso29891015e9.1 for ; Mon, 02 Jun 2025 07:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1748873759; x=1749478559; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pasRCSC32VgEjcQb416rK5+EN/XRXvQF7vBXVNk/1Wg=; b=E2j7HRAxja7XUSo5zd2vU0PVQAfhLoY9F/0lzb0/GcbKcCEOc1dQgp9zL0T2lRmkV1 B4aWzEGLZVqdhkoyTRLdQHlceHysHv43NR4lCbqESsZkkLaVgaqQrZbLdtCsWeAqzmJS TEogh81VBAzEb+wpyKsN2FAJ4qSImXqJzmoFYAIP6EIXlGsBIhbD54y1sAfVALERFw5Z wVt9T6RLWo/n6j/BWQROUPHBLI618HtB8/QJEu6mdk51cH44Z47FocmThxbREtEipaLa H/bprVjX3K9uMHwF50gRV/vT5yS7R1LVK/TuglGPt5R3Vg1H4KTchCCyzMYGHuAz4uSP SIag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748873759; x=1749478559; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pasRCSC32VgEjcQb416rK5+EN/XRXvQF7vBXVNk/1Wg=; b=SuHSv6RQQMMTnBPPYyr8Ipf5SoBsTXuS1nWjy2I1ZjXpbJUeXCt0jAruh3mlhd/Jv5 +O8qb6cnpjOomBqWF2yZqof6wlaKfZpGVDnGlXIwKSJfVmNU+m5/BOgXQTPGXFiborIZ g9jIHQxWa4nEDxsv2vHjcEh3gZouQ46HlCIGJ2Ztbzw3+vSQVp7QQQ+p6uMGW1xFuuUd DdmM9mXM5WC9pLv6rWjcKlwy9td418KLw7CioqkhFBVK3JL8IwVD7Y7DkdUyry4NqZq4 dePkCyPMlh4NOqnWaiXP6KQFgLy21bUuG22c3qPfPrnS7ePUHjb1cdyJLiQJH/tsdxe3 276w== X-Forwarded-Encrypted: i=1; AJvYcCVarAhNXtI+EaGpJnJWxVWnniQFWtm/RkqZcRoaCkThk3ad6LsgW/0roCX0Y5oSHQ/xyAcCw4EIaQ==@kvack.org X-Gm-Message-State: AOJu0YySRsYg9/E4fCXoDKFIJNjL7MSpaW5SM7fmihQNCz9SFqmi57t7 fmgizEAtcvgx3p1KaVP4ZGyOXiHp9yLEWuDm6npWt4/QhnpYG5Lx9/60kI5Vf+USge4= X-Gm-Gg: ASbGnct5wQJRu5duPTsuTAaTRvYHQkunuROCuXlaf/XqmXCEXXgve/A28IVh/ae4bKH GpiAUIs/T5qXODjauaWsOodieXILqtdJ91x9LE9sT7ApU+9iAHaTPhXRVBy+O3OiFrPVcrW3Twy EfXsLtlKrUrisEFB9JUIHBptw2rciog2J+SdGgYauH1x46NLiXMcVOQSj2JrKeo9Q+CluTxLemQ fUMDDHBd3RftfziLW1Iai7AoxpZODzh8PtQqe5ecBjOPDKVGTSJPnWKWCf/UKoBO3BSx+wyt9Q9 re3DFDk23XWWZc/xCMgERq9Wrn0ZUJ1ogYNax/dBC5ycFmVdi9EN2A== X-Google-Smtp-Source: AGHT+IGeRpd8VDsT9tzxbCNKifu8MjL161GTIQbbUw44DS6V6JSyR7z1tMRcG6paU3cdSynR/larLQ== X-Received: by 2002:a05:6000:2c0d:b0:3a4:e5ea:1ac0 with SMTP id ffacd0b85a97d-3a4f89a7f0bmr10299120f8f.5.1748873759286; Mon, 02 Jun 2025 07:15:59 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8f194sm125483535e9.4.2025.06.02.07.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 07:15:58 -0700 (PDT) Date: Mon, 2 Jun 2025 16:15:56 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: syzbot , inwardvessel@gmail.com Cc: akpm@linux-foundation.org, andrii@kernel.org, ast@kernel.org, axboe@kernel.dk, bpf@vger.kernel.org, cgroups@vger.kernel.org, daniel@iogearbox.net, eddyz87@gmail.com, hannes@cmpxchg.org, haoluo@google.com, hawk@kernel.org, john.fastabend@gmail.com, jolsa@kernel.org, josef@toxicpanda.com, kpsingh@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, martin.lau@linux.dev, mhocko@kernel.org, muchun.song@linux.dev, mykolal@fb.com, netdev@vger.kernel.org, roman.gushchin@linux.dev, sdf@fomichev.me, shakeel.butt@linux.dev, shuah@kernel.org, song@kernel.org, syzkaller-bugs@googlegroups.com, tj@kernel.org, yonghong.song@linux.dev Subject: Re: [syzbot] [cgroups?] general protection fault in __cgroup_rstat_lock Message-ID: References: <6751e769.050a0220.b4160.01df.GAE@google.com> <683c7dee.a00a0220.d8eae.0032.GAE@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kzcsf5ktx4jfm6ch" Content-Disposition: inline In-Reply-To: <683c7dee.a00a0220.d8eae.0032.GAE@google.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E8C6D40003 X-Stat-Signature: hjtehs9po1kkh37hchpmef9ckbepgz7h X-Rspam-User: X-HE-Tag: 1748873760-147788 X-HE-Meta: U2FsdGVkX1/9jMDEtA/oIo1G64Z2HQExEVRUh6IbPLBUF1Oadgd7ZQjdKVY52SzlRhetAJb77nEgKms+0uETqwjl35fSdUcLWl/HDBOLXQ5X564rhowgK2pa0BBcLSJLh8aebqPqtg1oAv/5urUKaCOQ3v+ZXEef+kYYN5xpykphISMDcehdGLsbQo1O4K7GjYzk6unXhAAz0rlVIV6AFe+ZnYMAjDpBl37e8x9egh6xeCZ04fwR8DK+o5ClOd47C1pq7jz1ONiTSS/Fg36FtRZAHhWRPOZ/N0gn8g/RnDT6f25bPweTbne8ua1MLq6iMM25x5sp41JdndrhOD2gSHokKIaEntRVRZCjGu0Vn4vwjr5R+oZ8E3MfWBBzCgHmRVXrXDyCy51J3hc+r5Doch4dXNpRuFh28de7g5hHPIDnGZBHWRQO/q78rMISwuTIFG733CP9PKS5qtVAHD4oT7rlx6+e70L5u8nES+YX6+FT5KdW8v5iOwXLlqiLPdvmAswI5/cEnR3lOLNEtU6bEfYwTUx4q/KvvlvPw8UypmKZ0pVmELk6OlbICHtRHY7scj7qJOF95+8D1g2Fici3hMMyngkKdlsJS6PK52KSH3L/9qj4epxwlVUw6k/bQ4DKjhmpIfrdIPgTKyox1TiMeljYrcj9BT3eKdzrXIpJGt1v7udL1ZzdSsz2TNqY6bRA0zBFK/fXDRRxRqTJ/nFvVgn54o0bJdxopI4hH//gYWQAgxrwFpX/9SvpcMHZqZc3kPAs+jeHceAKMw3LB9KcGB2ykWMh6zbKowgwzwGZsId+RxZ3Fibyg7zVxW12IZlIS1YTqQ8RNRCd52oCnWYyo/ll78N9t4RRQ0drELl2jivQLlBJ10D/ZIkAiDT0J20trhX2FW/8meJyxcMDbuBAJY6SEXKyhCHUX/nc5KYCxDM362q8O2kXN6OxgulMqocKXbEX/0ppwcANsU9PdAc CUgBYUi3 My5GbjWB/Rq2dSPtNQnnnuKaiHMdLzSWaXneemrwqJSLaKFA4JNitrCokPxa8i96WBt6it5x7xE5B75fSZSqcSRHvLoOMgByG66HKPVRQHvHIt1H4zR9Oc4duTvIKzAuyqvL+DGVQSYf4ZB5LDDekE76fyCdLjodIm63znDjTRBRi/gKKQTHfVSYRMsi0C6FYHqwyk3Z8lsAb5EZIpanx7wE6mcZh4lqc3OD91od8UCyLAkEQTh9mkNCjjT9IkGfKnia1JKjMe6pcqyg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --kzcsf5ktx4jfm6ch Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [syzbot] [cgroups?] general protection fault in __cgroup_rstat_lock MIME-Version: 1.0 On Sun, Jun 01, 2025 at 09:21:02AM -0700, syzbot wrote: > syzbot suspects this issue was fixed by commit: >=20 > commit a97915559f5c5ff1972d678b94fd460c72a3b5f2 > Author: JP Kobryn > Date: Fri Apr 4 01:10:48 2025 +0000 >=20 > cgroup: change rstat function signatures from cgroup-based to css-bas= ed It says: "This non-functional change serves..." However, it moves the *_rstat_init in cgroup_create() after kernfs dir creation and given the reproducer has a fault injected: mkdir(&(0x7f0000000000)=3D'./cgroup/file0\x00', 0xd0939199c36b4d28) (fail_= nth: 8) I'd say this might be relevant (although I don't see the possibly incorrect error handlnig path) but it doesn't mean this commit fixes it, it'd rather require the reproducer to adjust the N on this path. 0.02=E2=82=AC, Michal --kzcsf5ktx4jfm6ch Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCaD2yGgAKCRAt3Wney77B SVQoAQDHq+sRBr9VIovCUMvE0lKEciOvnR/BAoR4DPgcg+NOwAD9Fm1hrpnED7c+ obYDZ0tb/tA0+9khXt2TrVelWDcc/Ao= =n7f7 -----END PGP SIGNATURE----- --kzcsf5ktx4jfm6ch--