From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F14EEE266 for ; Thu, 12 Sep 2024 21:14:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D8C36B0082; Thu, 12 Sep 2024 17:14:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 987096B0083; Thu, 12 Sep 2024 17:14:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84EAA6B0088; Thu, 12 Sep 2024 17:14:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64A326B0082 for ; Thu, 12 Sep 2024 17:14:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2F141A0A69 for ; Thu, 12 Sep 2024 21:14:55 +0000 (UTC) X-FDA: 82557340950.14.07506EA Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) by imf20.hostedemail.com (Postfix) with ESMTP id 5ED3B1C000E for ; Thu, 12 Sep 2024 21:14:52 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rAJPpVUT; spf=pass (imf20.hostedemail.com: domain of justinstitt@google.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726175586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2EO0qmaSPp73jvXnTs7TJzCKL8q51LBbEbQNyisfg4c=; b=sUyeHTv5wQn0YPFCaHZlx1lRohxJQ9eVxkuS2wt8Ae9iLI6fd855IA5bs8y1spiTVBhwCN kfkVMcfUIhG8mOUxxXgNhSZfQU+dg5FYhfw82l4rz39CMT3uZyOpFDo50lSuXLUh0bsI89 thqGNYlMnW9Dcn2iHiISHjI7mo/mkVU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726175586; a=rsa-sha256; cv=none; b=wzAsx5AprELVohbX4SMfl+ayyeEeoXMN+3/QaG178jsXGV7XtUyN/3BJ226saD17KM9Sgm XlYBtKrTpnR1EecJmVRrWZiqaD7KZOD9MW0oLTR2rePzpE7RvotcUsgDbDJWAX7nxfDwWp JfCcBlF4M4HeQtxzRm7Bu/X3cDssojA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=rAJPpVUT; spf=pass (imf20.hostedemail.com: domain of justinstitt@google.com designates 209.85.167.180 as permitted sender) smtp.mailfrom=justinstitt@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-3e03a5ed4d7so745763b6e.1 for ; Thu, 12 Sep 2024 14:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726175691; x=1726780491; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2EO0qmaSPp73jvXnTs7TJzCKL8q51LBbEbQNyisfg4c=; b=rAJPpVUTwFGje5x3cKRGit2WkQQurOT5wvGTcdKXu5t8eLjbGI+qPH7Z+GerFvJgiC Ir5J8FTk/WDlpEr/PPYInjPITdhG8qj3VzAOrNH75CipUn30jqD5IK3oAkT14/4yjYW2 Rg9kdX6OgZsCwZuwTjVQ2mSeHdtUiUAG1ePKSJj6BEtkJHCptH64wmBWK9HI/k92B9ci p9nrfxbHv6gOy/urOC/4ps2Oc8zjUvLsPzMlMzPPFp4o4qXqmTSPnkQ7sy7W6jfAfyLv rdQgg9ezCFCxU8e+aVNwagQ0CYCChFIGc47dmM9nNdVWP52Uo1OX9kpBogx5cTPmugEg y8hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726175691; x=1726780491; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2EO0qmaSPp73jvXnTs7TJzCKL8q51LBbEbQNyisfg4c=; b=lIO5rSdGW05rrbIJORlI8PFGdb44kDSESxmCzfRrkbJZ+77W9xQJX/3cO2S3YOpWw0 oG0Wf/YYtRNUiSH2N1ShgRdJKfB+ot0M1oW5f/M5ydncBJ2ki7AMDu5Os6hpnqQ63TuP zJPZGBaRfjqiKSJquNDbTcrgFt9EG/JLCbsy7BqwKMNIfm0iuENVpce4KbcsfcbhCOJj KG6qgQu3ij80xO9NefM59ONFzGqavUxlC3dPnN25kcAfL9jckmZP1ZgaoCY1Cm8anBZx oHfDlL2Fa8qs/ajy3xBB6Ng/aR+sVQ/dbvrUwtUDEUlEIh0rNkRKYhaQMe8GhcZmU11U Lovg== X-Forwarded-Encrypted: i=1; AJvYcCVyPHLaDOncHWgsW6aqp3qKEsw7Wg7ZjBVf60lRMIZxNVqbyiFQuni+juwJraMbxj6SkoGaqG2oHA==@kvack.org X-Gm-Message-State: AOJu0YyTo4Zgw+ocfhkZkU23JChQXJ69Srx4Lz4YkISFgmiGhJDfAd5h zOm/dybNwcjvH+MNg5ZQ+L8sYjwRXLs8D8iu2tMs3+qYWoxXODzyQKluTYQ/Kw== X-Google-Smtp-Source: AGHT+IEXhrO73skogk/s/nT+zYKnKQ0Yub0DnxaAiKfl03Q20IYpu3fPe1nRti4noHn1qI7LW/QNUg== X-Received: by 2002:a05:6808:399b:b0:3d9:3a2f:959e with SMTP id 5614622812f47-3e0719ee561mr3950771b6e.0.1726175691128; Thu, 12 Sep 2024 14:14:51 -0700 (PDT) Received: from google.com (30.64.135.34.bc.googleusercontent.com. [34.135.64.30]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-5e1cab53594sm2250200eaf.43.2024.09.12.14.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 14:14:50 -0700 (PDT) Date: Thu, 12 Sep 2024 14:14:47 -0700 From: Justin Stitt To: Yafang Shao Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, alx@kernel.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Quentin Monnet Subject: Re: [PATCH v8 4/8] bpftool: Ensure task comm is always NUL-terminated Message-ID: References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-5-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828030321.20688-5-laoar.shao@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5ED3B1C000E X-Stat-Signature: ug81zi5rua3619uexahxak51x5575uzn X-HE-Tag: 1726175692-656254 X-HE-Meta: U2FsdGVkX19/JVM4I5VTq2/YZc54uiP3sFsPR1DBFQEmgng9ycGoZsrX1ztLJfpoC5EspZaWdHMYmNO2jfGa3Df3XupamrE/ULlaYoI7SKXbUydqtQZzzEXpdbTYAPWrNLOKcriIcWHlterOircSNSNwH69gCz2dbBbEDuZNwDt6cjYcYEY6tMZywtLPmB9Em/KP1GXEO1UE6Jxvcu2DXqVe9CBQtwgDYBxdtFxQj5N4KSzP7DfPWfRpCCXiESxx//bCYtnSPScUMn1VYhXviFi95SJI4yGzQhtQQKAR4qz+dWeJZswlkCh0ituSyFnB6JOD3zA00SVmxhYC+s0J1VZYnGCSfD+graeXMFbwupsYrC4ckHtcP3LctAFfjpc5FeA0pjek0wnwm3mD++pgeeeTJdAUE4lahRdhjfpzxTeV0U0tR3mHhT64a4UUkodF876ZhEnC4YCHlJM4JYVl3HBnprnVEEAD1d9+KJd5RjG5C9k1ofq43lt0IMn29RrnVEmgwAYkSK4pmQTswXhvioe1O7m6IT1BBHnCdOCW5mhVbQ5abueGlHkG+zBwADzu9TYyITgEMGQ7mvz++vd56GKnZX+Z45O+ESIjunERZyb7HuC+Q24E6+EVmHNvZOuBzdXdb0Bd8t238pnvZPyzr+GPqN/+ryJXqzXnjXjNrWTrzEGxl6e/QI3Nn+h+DX82Splo9JO2BtI1t4f4qbGc9AIHhc+T/8IGetsRwzRdkcpzoU4gh5lt25ExWYQ0pR7mC4FP2fM5MrQURDAZ5pzOsxGjf9zsGW/MlaVHaPdH1ZrBh2ChhFzSEYUWiOlyG5Phq0mrTVc/oc5ChEdlogUJeI9YjSEspCaYNSGMaRL0CnxhNFqYdYXcH/v1I+9aD/OhLZ4hiTDQQfUPF/YcSGsiBoyAL2rYVB8cAVC27TL79ecvT08gk45P0rXauXp5t/KvHw/dMVYkAnBd25wE2mx LcapXuef rDZssVRYaxPldgOVwIxYW79SEL/njz3lRwKomEb0eJRCWnuHwHjkBWCiNpWXDs5ejTH8eyy4ef4B0Gr1pwhtx13H6XpAaPHcz+D8IyiGXYUqCRG4EecTHUygVEyA5bssqn5u96822UQ76xEhIxLih2ZYMu+NKg+O2AayvjbuKb3jxGUYjLDFrAhdyY2Dnd1l4MJP7e61OzXt8e6PbrkqOJPqA8ZbM7heHGWB6mBplL5MXBjEpw/vik74p1DIZs/b+xXq2SIYpnBKRH85ZpQaJIyVbpsrJ88sRyruviFGnnsNM8swRthupzsEHB6oT0sPcpJyKd5XMLw65m4ziupXMtCxo8gfenhMk8qLqHO1Ct4HlQTEq9qe/hlUmnQpELzM9ERvpjpObX2AeGtG6HnMmaOtXgKzUuyii7nsW+lrHYR5ErysLgQ/DnN1/zQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Wed, Aug 28, 2024 at 11:03:17AM GMT, Yafang Shao wrote: > Let's explicitly ensure the destination string is NUL-terminated. This way, > it won't be affected by changes to the source string. > > Signed-off-by: Yafang Shao > Reviewed-by: Quentin Monnet > --- > tools/bpf/bpftool/pids.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c > index 9b898571b49e..23f488cf1740 100644 > --- a/tools/bpf/bpftool/pids.c > +++ b/tools/bpf/bpftool/pids.c > @@ -54,6 +54,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e) > ref = &refs->refs[refs->ref_cnt]; > ref->pid = e->pid; > memcpy(ref->comm, e->comm, sizeof(ref->comm)); > + ref->comm[sizeof(ref->comm) - 1] = '\0'; ... > refs->ref_cnt++; > > return; > @@ -77,6 +78,7 @@ static void add_ref(struct hashmap *map, struct pid_iter_entry *e) > ref = &refs->refs[0]; > ref->pid = e->pid; > memcpy(ref->comm, e->comm, sizeof(ref->comm)); > + ref->comm[sizeof(ref->comm) - 1] = '\0'; Excuse my ignorance, do we not have a strscpy() equivalent usable in bpf code? > refs->ref_cnt = 1; > refs->has_bpf_cookie = e->has_bpf_cookie; > refs->bpf_cookie = e->bpf_cookie; > -- > 2.43.5 > Thanks Justin