From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 606B8E6FE4C for ; Sat, 7 Sep 2024 13:29:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF5816B0083; Sat, 7 Sep 2024 09:29:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA51D6B0092; Sat, 7 Sep 2024 09:29:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF85C6B0093; Sat, 7 Sep 2024 09:29:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 888B66B0083 for ; Sat, 7 Sep 2024 09:29:12 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 28575A1936 for ; Sat, 7 Sep 2024 13:29:12 +0000 (UTC) X-FDA: 82538023344.25.B3F7BE2 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf06.hostedemail.com (Postfix) with ESMTP id A6CF0180004 for ; Sat, 7 Sep 2024 13:29:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=E7BbFXS5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wylkjxuF; spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725715699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NtXsv9rmo2/vcWmH4tbI6A/FySkq9LpV3OHaWzhAiYI=; b=U9jjnUmaWhNaNleSIWajil6DermQCf2pjMHrQeu+Pm1m9RnJ31vH9XgIRx3RdmTwCpzkfX kaq14mFruWEMSIkvU9WpJ3TGkmcaV1MDuUbYTRkUY97jdrRHbetul0OarjAS0+ngUF3zhQ QxIh7zQFjbT0cEIRw8HNEiEe9nQpCqc= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=E7BbFXS5; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=wylkjxuF; spf=pass (imf06.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725715699; a=rsa-sha256; cv=pass; b=TO19LIBIELVw8sIx3F1B2QL4XeMgdWPA48SJ56mdYwyUsoqAn8TqF0mC/E/W+kukMKGK/h ujiKJPsHXG54Y1U9Y3gV4XgfKsmxN0ajzJcqXu9D4U5ZPD0giqrZWfl9m47OiB6RDXT0wa w4WGiFmdCp7ydFc+5bfixvZp503EIX8= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4878fWtj029782; Sat, 7 Sep 2024 13:29:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=NtXsv9rmo2/vcWm H4tbI6A/FySkq9LpV3OHaWzhAiYI=; b=E7BbFXS5FfzApdpj/a3jwVlm4IwplBc GoVcEHtrVNkoAl59eiunhnGlVeSdOT8IK2p61YfUYJ4YUUHV10ML67ZPoIjwK1GZ 1KZqABTHXuRzTCNHwBWmDoJRjFMLw2LiRmth3eYcqsz8IlquS2RuB7UK2PXxwMbE LLqfxu3GB/LIYiUpYaCgUj+dCPSQtUQuC8zgFBBEK7y5J9WVcgLYJpWEYr47Ka5C xUb0sCC/KXf0awa/T+5E+ZKAbeqgqyKanpCHUL8++Pw135ziXlj5hJ5nKpC66Bic vwvbN7K4vwNv+aO5mD/YYMond89NCP0McnFlXLBgg3RPNG469P8yNhQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41gfct8ba2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Sep 2024 13:29:06 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 487C8SCY031613; Sat, 7 Sep 2024 13:29:05 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2047.outbound.protection.outlook.com [104.47.70.47]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41gd969mvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 07 Sep 2024 13:29:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D2uyikJDeBJrpNOXXD5H9IIIHNE8K7WQ/D4to6PfPVkhTMJ4fO+biYWfaL+0Y067er4c3pRGABpy9F2hHk+IpvbhHgQFpytmFOf0awAjraUDRZcjMdwrHgelvaxg+bapKbx7rTh5ntNQ+nXY95CT5UrVdQHysTmlC8SsrJgvPskDK/pSN6SkoOC9t+Ok90d+ryD9e+BbGGnTpsOqsiB5V5Obtru77Q3XAE5gQsloc+SXEfmO4qEoyqvrCgc+Cdb3yJT8a3d6CByQogKkDX3tYvf6/zhOp3c4J7o9Jmxo1C9ujinRuVQqapt01OBTgJNP7ly/sDuJEV/HwdJAWmLc5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NtXsv9rmo2/vcWmH4tbI6A/FySkq9LpV3OHaWzhAiYI=; b=QNYgLtBq4mcnqbM9Sg1aBZKhWw6y90XP/dqmMJgSO0M7Ay3cyMKSm4uP5MD6xW8dU8eWvYlebBVUK+k+HzV/HOAQ1Dvct3SnyYeNahXybm7nEMYF3XwzzlFAi/vOTlLA/B/6YMfgqaVAL5r+36sNqkJyG8AGh2ZZsEbpvqmsGjiDYabeGmV//bnvWOxfrV/OyAKrCspaUdZirh8tsHOoxyW3szmordaC37iP2L9bBOJKAXQhww9vxm4KEkkPsLK8tUKpyHhNSlx0EWayI2kEYi3sDV7RFbnRboMsI2AFGn9om5EVK9sa3mKhvWvgcQSwZPwZyNwtWb2QfMw8ZASu/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtXsv9rmo2/vcWmH4tbI6A/FySkq9LpV3OHaWzhAiYI=; b=wylkjxuFkiI3SWlAEG7G/ftn3ZKdoKBtN5P7gLUgnmSc7DpeIR6jn+oK27XrIgEOpm1VmSlEU1aXlkcRhCbiUsM/wt4f9S/UY74ZDb4qSF0PXpORD9L7Slp28HusVVHY4+poz4O27TThfss2aKsHkYKTvVbT+ZEKMm2pnAZgSLE= Received: from LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) by SJ0PR10MB4461.namprd10.prod.outlook.com (2603:10b6:a03:2d8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.16; Sat, 7 Sep 2024 13:29:03 +0000 Received: from LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d]) by LV8PR10MB7943.namprd10.prod.outlook.com ([fe80::a8ec:6b6b:e1a:782d%7]) with mapi id 15.20.7918.020; Sat, 7 Sep 2024 13:29:02 +0000 Date: Sat, 7 Sep 2024 09:29:01 -0400 From: "Liam R. Howlett" To: Wei Yang Cc: akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] maple_tree: memset maple_big_node as a whole Message-ID: Mail-Followup-To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org References: <20240907084927.1547-1-richard.weiyang@gmail.com> <20240907084927.1547-2-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240907084927.1547-2-richard.weiyang@gmail.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT4PR01CA0362.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fd::17) To LV8PR10MB7943.namprd10.prod.outlook.com (2603:10b6:408:1f9::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR10MB7943:EE_|SJ0PR10MB4461:EE_ X-MS-Office365-Filtering-Correlation-Id: ffc1c7b3-2fc1-4b83-2a54-08dccf4109fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hF96s+EmWRDT2jOPOpPXBKWGY8NOuDfsfcglK7tzAMvCVM/Np9AfaLcbpxyn?= =?us-ascii?Q?3GoNl8SNVkFq2k/0VBi3h1oNZ53AMtC03z/wR+pmSZ/k0F1TAYu6IxJlKpvz?= =?us-ascii?Q?Ia6Yb0UrCcJpLIsGvEp/ZkPLM4GnxxIiCTSEDYfr4Hpd0thucQiI1xTvUS0Y?= =?us-ascii?Q?mSD4oWC10Qit0F1GQZGESth6vTNIvTWeh1bRpHyXYRufcj07uXtHjzAMfF7U?= =?us-ascii?Q?UV+GObweeoEVl+SpN6LbPA6t2or/I28Baqm5nUHx44DIY5djAlrpYQLVTVxB?= =?us-ascii?Q?YyrCbpQL31RTsHYZ1EYMfn3irVDH6v5XZj/8S30/LbE+68KavuU3z1vQ50ig?= =?us-ascii?Q?0d5H1ClhVQouk0GZ/kFxrU63KlIBJiU9C2AgzVnEs+cZlHuzd20KLkqI7bV1?= =?us-ascii?Q?hyTH0nm/V9S2BNdWt9uifGjvc4V8ftUijUZvCc4eCjXeB9VeZFiUY7t4je+P?= =?us-ascii?Q?Rvb//GiaZwtBnb+a7izeCpGhHxDGkV7METOZDcfJd8ItUq+rwKlfia2+y3ht?= =?us-ascii?Q?BPOPRKCZhpgiwRVJcdZ4vRrFTZTXSjkI2x+6+X8y668OKQr76XaRKpuZLJgi?= =?us-ascii?Q?g8ZduuO7JhRR+Ogq3hjzFFXSRhcKnMXyDvu72dSUqVF64hkupOcFlsymXr3Y?= =?us-ascii?Q?52rSeFcuyD6U49uDbZYAmKVlpmL85HEiW4FNYPAsItTL8rdackeaUI/aUhUG?= =?us-ascii?Q?tuAO8COnsp4kUbljW7FCofgioKiJf3xp16CBT1U0LXNoSbZ3mpkDVgpkpROV?= =?us-ascii?Q?guTocAqmPHb1IhX+HP6PcDXmrc9PMLo/CG/P6PzHcJ3ai2rlyxNWUpjkMx5t?= =?us-ascii?Q?JXLncFdcnWv+aL5CAgGpOB5kSW5bpkLWSCX8uVjqHO3OQRek/i4/w3PO25DH?= =?us-ascii?Q?40N9Put7CVkJUaJsmJWsKo7w+T2InJ5swmeJeI0nNYoK5HaJmDIxLodW7pd2?= =?us-ascii?Q?riqs0oAn3ZJXmx8GnT7k2f/XZBzfVKYDmFbGzECi6OjXtGOAFCYse368sWra?= =?us-ascii?Q?ip9mN8yugrx/FR96+3Kh8PFo1V76YSoVZndWD3tol4oyUHXk9mLyYIxuAHxB?= =?us-ascii?Q?Ae6W/rp0YwS1vxnNUEyOJSK9RRCAZQ+/utfyFnrdNfiWT1wErurADolf/wle?= =?us-ascii?Q?KpCkgcaJ8j7OWvzuUBB8ItZ6ytKKieIt/BJrS/ltRM+7jHZW+RrLuy5WP/TK?= =?us-ascii?Q?J18oMyGxq5mCBJiw4zz5efSC6Troyhr7OmdJlO4acE+QlZVfv02v4uDYbgPr?= =?us-ascii?Q?e/Ocv7In8BkxpUOYPvTQrGXanGOaJZk72VsN59hAmBEf/WTkR1xUyynbox8Y?= =?us-ascii?Q?3xqrr28noy8+aeAvHgCHqhR11SImudIObFja7gjLQiaJ6g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR10MB7943.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9xoQYLQclmQQaq3VXBjKD037YtsRwOl/t0xIQ/ytU0nLlaTnL8TcZY4axv5G?= =?us-ascii?Q?JUlep28YQUz2rH4RW7S9Hp+kMu+7w5CqrNA1vvqAiiDpa0GKHWQxCngG0i0o?= =?us-ascii?Q?C2llB00JcPFmwI+Em6Q12aNTinoGHyl17MBGBH8mbidoGqUlAD3IWwmt0pEO?= =?us-ascii?Q?M3DN947ARrcY3wQAaT3iW892qEsh+7LdjUDfwb2X71NIOt0c71OBffj81EPi?= =?us-ascii?Q?R6HcQNJhBIjUEcKoCCx4m+NIukVZn/Fu4EqwrenEMz4vu0C68qIIYPTvo4qo?= =?us-ascii?Q?Z7TJ4gv4yG7n44cB1kpdBzV9hdpgC3KVpBFaZr2uxidvDORabR6F7tl8HIrw?= =?us-ascii?Q?DQTnJ2dWJ/v2ZS7f86THPLek4hAvjIMmvxRLPGk9bm6fPvIBMh5B5PvjaP7N?= =?us-ascii?Q?uJ3p0zzLpwZ7d8DVuGywyAIKhpT7ey21lmB9aVh5beaWzKBZhShuMgCkNCpk?= =?us-ascii?Q?RJELk/P+pvccHz9Wxtf7rwovhkgHGIds4biSEPpwj3Gf9An/ens/+2+8sUs3?= =?us-ascii?Q?ExZSEb+0lyIWMM8XDTNTKf4ROKgPxLtT6CsCpB0hyJg6YLY9VgyRzZhAWWjY?= =?us-ascii?Q?DjR1Opex5j+0Rfio0aeoXpzV3eUYgOA/HoAk44160zpGnogKw56UhvZFeRun?= =?us-ascii?Q?aCJVJJMsQ/orOko416Tg5nopbMw088M07GjF4Y2Krebmy7BKGvIFImq+AW1P?= =?us-ascii?Q?UHclAv3W8hjRA1J+eU/e4D0uzaauoEGgGoYTVz3Ddz3n2KDBoVbdo7CaT1OB?= =?us-ascii?Q?AV2UEWwV/yjphyzy6xuDYGxc8hXSXzUJ1yYSJ1LAb1d0i0eWXQ7P/Om342UT?= =?us-ascii?Q?Ro9j9pQ5+xIjndx2rCO6YmyiIDQeVxwu1ousn6nXZxDjGmVSaTpeJc1LJhA7?= =?us-ascii?Q?xdU4zs/jyk98ffrW/PxuLxAEJC4SQaSrOcNRhIWYiJY4CALzjqLFgIl+qS+d?= =?us-ascii?Q?vM7nINmTQ3ALAfuT1DQRDFmciUMVJxSUsEoX9fGzO0V/Jwp7RS9UT/YWcIdp?= =?us-ascii?Q?sU4ZX/3ZKnd4MxfwitQKOXbhQ0EYhhBpXZy4XYMRcXzKsQzuZtrxCvpQPQLC?= =?us-ascii?Q?NSWbmo0EhjmxPilc4kPMl1WcEbh9DEwcSxarZc/yrK9nn8H0hfxR3ulYlqYG?= =?us-ascii?Q?Ul9j8uydU2eCqQCFmd+eqdmOraVU1P79YRmoc00iI4EZB5pjQ0G4B5ZVYoeS?= =?us-ascii?Q?zK8U+kIr7HJVFjCE58LHslmpRogxIRunnwHGl/vC+By6AxOy1pJYoYzn46tQ?= =?us-ascii?Q?JkNoAH6u99BvF6U6NCPn4F9PLR0LOpuobWOL2WMSVvHxz6nGnN/s2/0LISUx?= =?us-ascii?Q?i7fAEbH/jh1btJjUbVNuAKCeTCXhq2oaxHg8d2kEFrD5yEwRFiD1PvBQZ/k9?= =?us-ascii?Q?Mw+fVVd0kdq4ZaWGjjMUj9tSg/4xsPAYmUSH98QvHp82L7Pd1Eov0hkTX2Ui?= =?us-ascii?Q?VC3Cj9uK77E70p/Ddwsn8TR8tsk3xNbIBl5HDaSbQvqZWbwER04qPgrVP5po?= =?us-ascii?Q?+1kkpafHLdFr8TlpcI5cB37W57yPPUMljvwhoQvITPKpkoeTqNWqPxFOWOHr?= =?us-ascii?Q?cI3Z1kxLplf8r19oeMdSgvw9PxsY5pkc5eQ2AEZ1?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ejo8k1cDPELTqSlGS3CfLHiDruKgrMvKp8ZLzcUHBAnIyRC2NN8nQ7F4Kz2TVooJBxMMbTTDr/j+3AVYfeGWXKwCTaU8UZBUw9ZnCZBbFH4r3UPwsX55pXkPb2cWF75YY6ZnWzMxLEYpgw/w1bdMtRW9K9oz7enGv5QV+OHjOicsWIlkwDmhOEHwrcb5Vg2vhNqiu0VMI73bW0QgkXPQtJKDq93DQmua1kqgJR8uZW5fyb/AVw6eXoJaFUgnzAWDl5AXL6m9UQgJmnQNJbHhcsfxUN9hv7gz7KvZ42oY/mCs3DqrHsQ6vxr6M3nuXHk9Galkb1a7hiTev28Dqpg8RKLiJtGHE2m89xtK2syfjihIdmD4lqNDMtzmanD7JIcb7KEeqp5X9l6IEe2ftUIhxHUyJUa2VpCeWZ0wWGt8VuIPisVuv5Aeb9hnt52e0Uj9cGLLX81O8MjGmqtAOaHpE0v3Pu47f0/CAIqUCwnd7mKcjovWuCyS0+wTkg2xHoibMb/bjWn/bInJlFxqPrNUeSFcpYJSPMjRJzoeDFGi7oeYkwR2DPos9m+3OUjJrbdyr0Udwth7X1vfbtQPiIkuFD4u/4VfvpGDshYwgrdISL4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffc1c7b3-2fc1-4b83-2a54-08dccf4109fd X-MS-Exchange-CrossTenant-AuthSource: LV8PR10MB7943.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2024 13:29:02.8906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uyX68tMOmzHtsMni0XvR4O1rwHbgDaTPDiNQiHsJpllKN5KHqd6nh7FVl3O172++AMJ+IviOEE7VvVMjMmigwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4461 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-07_05,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 phishscore=0 mlxscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2408220000 definitions=main-2409070111 X-Proofpoint-GUID: JqdiDI8p19u8KPwA6CwQpotgEknsOKbz X-Proofpoint-ORIG-GUID: JqdiDI8p19u8KPwA6CwQpotgEknsOKbz X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: A6CF0180004 X-Stat-Signature: eqyi91h8zmzo5iuxzup74i37um6po796 X-HE-Tag: 1725715748-582070 X-HE-Meta: U2FsdGVkX18wZz+w1BZtPqi6khLYg62C+RjUhrTdNfJGEn4fNk8Z2wwmLZshYgFuyyV0+SM9AoxX61OKie3WtqI0MJTCWt6LphT5KySfY+EtoUuDF/+ge7tDJPgsRDdcJ8ND1bcVOrv93qbrQeT04I/4V0y800vjpGtJ72MxC+eSYs/g9jpTEvKBQLy5ymVrMyScg5IvNnR/Q/W4I5dbOfeuqpG1FscTxOwZkbLe9r7EhyLQKfKOColNStQSM8/t47mzlvTNoboglsMupewHmFFC7e9L5rxb8bWmm3OpEhQN8I67R4rToo9sa/pXBoB4jwA1nSe0l0IJWjE/jlgPOLxrKH4iSptLkxoyLqK8Ype84THO9NBZdW39ta4x4jZ9vzkDzqZQUakFd5vGzfHrsM+8m5+GKDcEnAdTfiMeaxbZfqDbQBFJyTT9PmCqri+4geNXO1DVfBc3W76gBhQWFEDKcBa1v5GGbndAvK+8iR+z4nEBCoRF9xOEDXQPSRaUVYYjf7rd0ihzd6RvQc93SjgVGpYAh2xJQQDEhnB4Ytij+fl7K8nuycRWKAusShOKbY48bdpj1u2vjlSvPSBBSMu8Ee8cwqAa1+wPaznrMrL1Iq5R/uCB3wTnR7sc5Uj3U/HjP2TIiG1+o52uzzIhoxDmtLGLIIBPcqWNtGY8tGYjkjm1IO06OKctQpXUVqrngAygxURBxBWsJguSZIq9gt2e9HvB8FMpckcenPu5UnjiAW5yceKcgEjm5Qc3IMu+lzMwD/R/WdSOvF9Ng2TNXk3mEFa2HvMknR5uXk2IEU/mmRu5enGKDB+AB76QtKZR0Lm2bqjEdfXjVioBq4BGmklV7a7xwt0k2hwhkoMo6qBkLBQ9ZRiwLuK9MLwEOamPjZx4XOZCsVzJjYrS8HK5MfsodyUMHUP2+TjJmL6qOXuorOuA17DxmDZKqRmkOcfA+OvayM/HRA0nQ3n4usk qrtb3Erb yJRvWOLVFLFT75hj2pHR/MlIqRCKzjL6EFZpoZnVqN3y2b3UEY1e07ERN5uJdjzB/mHiYlc1wZKBoh2EqEV+GpDzQMPaCHpFqSCMidIrRL6GJem3WaR6TI7qtCdCjokogfkd8SQ/bMudX0Df9vJ3foeSPAAzjZEgTAl/XP/7QiKQZvSRuTyZARrY5RXiHz5pdzFTVNC2lL0cGKmb3QmdqBIisxPORpjuCcJoHY2WXG0cTzA0cBcJvMc2CVEQx3KdaL4hwlMu1QE0dEjW/3d9bEZ6b8ecvxaFsYLf8LoGSA/azS+LLb0KQdQezQ1K86OUbqrqcJYw2cti1ddIeWFPHt+8ripj/x3Ja+U3vzGFRzPcnMNtJ5tB9K7x/5CJ9mbJfejj/tChmO95ZVEPXZozWqtlyh6uUvXXaDgzV0Ic2I95W3V3DMLhPHlChpDpKslggNE5LH6UmRM+OaQYiW5f+HFUYc96tW+Nx+3MECjQ1s2A6bsmrRbkZCFD4wjmFUyIjSds2+jsTbzfvK7jufD+iKGxHR++FT2jY8551uqxLAfb2zy55WXB6bv2zM7nUhW7p9iD3TbrXm9l9GyFWTB9Nck19Gumxphh/VeOr4DkISUUscADOJIRENKo7Oqr1pAfR8IqEjMeuOef+8w8lazKL8ATNdPeriy9k3u7u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Wei Yang [240907 04:50]: > In maple_big_node, we define slot and padding/gap in a union. And based > on current definition of MAPLE_BIG_NODE_SLOTS/GAPS, padding is always > less then slot and part of the gap is overlapped by slot. ^^^^- than > > For example on 64bit system: > > MAPLE_BIG_NODE_SLOT is 34 > MAPLE_BIG_NODE_GAP is 21 > > With this knowledge, current code actually clear the whole > maple_big_node and even clear some space twice. > > Instead of clear maple_big_node each field separately, let's clear it in > one memset. > > Signed-off-by: Wei Yang > CC: Liam R. Howlett > > --- > Liam: > > This looks obvious, so I just run the ./maple test to see it doesn't > break anything. > The big node also includes the type, which isn't cleared. However it is unconditionally set below, so your change log is not correct in the statement that it is fully cleared, but the code will work and it is worth fixing what you have found. If you are sending more than one patch, it is better to make a cover letter to explain your series. It is probably worth re-spinning the series to fix the comment, but these changes look good. I'll have a closer look later. > Do you think I need to add a benchmark and run a perf for this kind of > change? No, you are doing less work so this should be better as long as it is correct. Zeroing can be expensive on some archs so this is good. > --- > lib/maple_tree.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index d8f10773e451..911c5e04e634 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -3134,10 +3134,7 @@ static inline void mast_fill_bnode(struct maple_subtree_state *mast, > bool cp = true; > unsigned char split; > > - memset(mast->bn->gap, 0, sizeof(unsigned long) * ARRAY_SIZE(mast->bn->gap)); > - memset(mast->bn->slot, 0, sizeof(unsigned long) * ARRAY_SIZE(mast->bn->slot)); > - memset(mast->bn->pivot, 0, sizeof(unsigned long) * ARRAY_SIZE(mast->bn->pivot)); > - mast->bn->b_end = 0; > + memset(mast->bn, 0, sizeof(struct maple_big_node)); > > if (mte_is_root(mas->node)) { > cp = false; > -- > 2.34.1 >