From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12E2C5AD49 for ; Thu, 29 May 2025 10:47:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FE3F6B012B; Thu, 29 May 2025 06:47:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D5956B012C; Thu, 29 May 2025 06:47:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 812D56B012D; Thu, 29 May 2025 06:47:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 64E706B012B for ; Thu, 29 May 2025 06:47:19 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E7B8CEA4B2 for ; Thu, 29 May 2025 10:47:18 +0000 (UTC) X-FDA: 83495618556.07.41EB5A5 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf27.hostedemail.com (Postfix) with ESMTP id 3D71C40013 for ; Thu, 29 May 2025 10:47:16 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Lt6SHHEx; spf=none (imf27.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748515636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lMyFdTprv7X/zYgM+g97+qIf02cu+8bPuhltvnmafKg=; b=HBQSLQWEUVZYwuA6K1Al1M/50nnbhSnAPiublW0R/rZPh5LoVx55V1Au/FnVEFQP+cDQb5 X6EcdK7Z60GDN2f7LMDDtYziqAqmQ+i/rIiftwts1FXUmROAUkj+/wYXX+DsFG/8tnvWOy 7c7UorsJWEDZN+UgkA2GkGGf0qKEY6E= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Lt6SHHEx; spf=none (imf27.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748515636; a=rsa-sha256; cv=none; b=kbukYVL4a22s5I3tJrszCXA6YqA+wTg5j9wyl37vhNVk6uhTU2K6idjk2sBxoiuTuOUrJw syyY8x5LQU9+b3sCbP+zRMPAWkYwCAPqyjE29DVZS7IDBrvj+KpMNEPOb3A2lKJBZ2Y7SG yIcY+Z7FENcRGgKOxoU+j9jbkO2TRNM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748515636; x=1780051636; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LVRwWoUatGOrd2tJr+IxXkFBmJAhyBpbsVHwVJNjD+g=; b=Lt6SHHEx0D6cx49lGkrDSs4f47pduOO+1OJ4rBkA6taCR4WJ/N53QbrE DAnWv8F49kOIcAlscSqOM++W5ajRowJDGYgqf7xCWB1IMMS9+RAnqwW8m Uwi+K2+s7H3onT13G64Z6tDpiWsMxQw7uxONLVj8wVnLVn7/Q6iVz6Gpb POeY6zjskm2Nj7TZHCw1UscXU9XagqreDMT+vRZ4Mf6ZDd/vUD/RLGLqH h3ETrgrtVj4Dlt2xiQM4Izwj5RgLuP4Ky/jmYfiqJKkaH7JGs9XOchMK4 JLTyIz46U6UtReeTuMX1s4bfu/9fb1XJqqwzU3rDqPXMhTpylTe7Cutxu A==; X-CSE-ConnectionGUID: x4X99waoQ/G0B9Q9O0CrLA== X-CSE-MsgGUID: hZbAb/NJQ5ClLiCbbghp9Q== X-IronPort-AV: E=McAfee;i="6700,10204,11447"; a="53196016" X-IronPort-AV: E=Sophos;i="6.15,192,1739865600"; d="scan'208";a="53196016" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2025 03:47:14 -0700 X-CSE-ConnectionGUID: s4B4ZiAUSp6DyUTnffUjdQ== X-CSE-MsgGUID: ESX2CJwEQYWD/+AmcTx2Dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,192,1739865600"; d="scan'208";a="174400473" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa001.fm.intel.com with ESMTP; 29 May 2025 03:47:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id F004114B; Thu, 29 May 2025 13:47:09 +0300 (EEST) Date: Thu, 29 May 2025 13:47:09 +0300 From: "Kirill A. Shutemov" To: Vlastimil Babka Cc: Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE Message-ID: References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> <7ae9e9f9-80e7-4285-83f0-a0946d238243@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ae9e9f9-80e7-4285-83f0-a0946d238243@suse.cz> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3D71C40013 X-Stat-Signature: 8kmjznjutf4myqkh876966m6ect5jiza X-Rspam-User: X-HE-Tag: 1748515636-939897 X-HE-Meta: U2FsdGVkX1/50kY6ivTIopTr/jVnOwGmn+UWdI8mJslSkMr1GhkdLbw9yckxPizrI6tRB4rH8OiP1VdHytZJwqTJk/fKtWlrTQYaCx0ICJcf9wIUt+/Gg03L89TmTI7El/YLr7+cNfGnzhhFwElYQlcKCp/YyQ/hTiIoXaXTxXrDVi9FfmMffRz03rkSaz1DEEe9lSSkdmPDh4BIHgdPuReL+b6k7KhXs7/9m/1FILc4t4f7xZ3OLho+VKCnZwvrRV/qI0HvdRFM5doKwccGY2iEWh6AqwtelUF5V1/YTdIr4gkl+AEBxHROI5e5caegO6s1klE3CXERHr51evpjPWon3SZfo+TR5lPN7o1DQ2iKcmwp09Udi8hX+QGKe5yIrU3BiS3Q0s3fcZ4BvUbclCPYLML/20cCzA2wr0r10px9ui7gG7SJEnZRPf2P0/+uk/otx7ZOjav4Yjx9vUDGKBtYm/LKCwPTj/Wv7XC+r6fjvwSwgFNe3BDpoHraSV7F+Nz9x/JW7sxlZtAEs2HIhQS3s27bpCHOSJA6IROfp8t3aIJa9MJ5X+Oshr7z3/8VFskPbymn+K7NU+bFJbzbxArSpMLw99spR7xEhCPs6fO4aA9AL9Xenwx13u78RFEs2PbJ5olwvJd9ArAtgpv4R/I8rdW6DKE0LMR+eK0/EWHtfLAPGsDO0AOwovfRfL6dGFQ9ZcfPUkAF9a5cltUTGjPbVxCLEbMhAWISqCYRntgxi/xtlfL11qJKX5tDELelUA63WTDRYcX8yU/y2rX3/GSWv6OAoeOyDRewsnT6lfdQqJphEqW23HWtBmQXCcGhmocghioDgWhmMEF90ByjrhOJF2P1HbTxD3AYlmGQLaDkFmX2OERW3IoFwi/UxtgmChCSP2gLagCLnXNIktfZpJRDJXgV4iWOTwDmbfSFaWUaOuG2IoVuBGSQ/CycCq6hz0ggKAiSyBY0a+ini/f 2v4t2EVe SYk3kMpwRhBlq6QfndhV0zrrIomMgKNft6siB41kDiOkft2nuaRQ9PZabNBlWqcUlYfmSHsDxCyKWCaiUsovnRM3jJZY/BR6X0mm7QmLWMQUOpyIiJB4mWtQ98MRfTMYMiZmUrkqFtxcdmYl5F2xHO6zO8gaeHMJBBkWzNCj/MwI6p3/65laPiWG9qKexrdfOoZy9Rnv6i0T6NQO7OZXi6zAY+PVpGlu5fHTJorO4TiMQm4MIg6s4P5/EGyN9T5Xx1ZDw+NrPiRNXg7/VY43MvrFA6o7ygnkwPjhQbKKuvM/6skI6+cbryKSMrXlXr1c02/60DidrxdFdhL13ZX4wt+Nhvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 12:40:21PM +0200, Vlastimil Babka wrote: > On 5/29/25 12:38, Kirill A. Shutemov wrote: > > Hongyu noticed that the nr_unaccepted counter kept growing even in the > > absence of unaccepted memory on the machine. > > > > This happens due to a commit that removed NR_BOUNCE: it removed the > > counter from the enum zone_stat_item, but left it in the vmstat_text > > array. > > > > As a result, all counters below nr_bounce in /proc/vmstat are > > shifted by one line, causing the numa_hit counter to be labeled as > > nr_unaccepted. > > > > To fix this issue, remove nr_bounce from the vmstat_text array. > > > > Signed-off-by: Kirill A. Shutemov > > Reported-by: Hongyu Ning > > Fixes: 194df9f66db8 ("mm: remove NR_BOUNCE zone stat") > > Cc: stable@vger.kernel.org > > Cc: Christoph Hellwig > > Cc: Hannes Reinecke > > Cc: Johannes Thumshirn > > Cc: Jens Axboe > > Is there a way to add a BUILD_BUG_ON to catch a future case like this one? There's BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) < NR_VMSTAT_ITEMS); in vmstat_start(). Making it strict != seems to do the trick for my config. But it requires wider testing. I can prepare a patch for that. -- Kiryl Shutsemau / Kirill A. Shutemov