* [PATCH] maple_tree: Remove redundant __GFP_NOWARN
@ 2025-08-04 12:56 Qianfeng Rong
2025-08-04 14:49 ` Wei Yang
2025-08-06 14:16 ` Liam R. Howlett
0 siblings, 2 replies; 3+ messages in thread
From: Qianfeng Rong @ 2025-08-04 12:56 UTC (permalink / raw)
To: Andrew Morton, Liam R. Howlett, linux-kernel, maple-tree, linux-mm
Cc: willy, Qianfeng Rong
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
made GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
up these redundant flags across subsystems.
No functional changes.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
lib/maple_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index b4ee2d29d7a9..38fb68c08291 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -1344,11 +1344,11 @@ static void mas_node_count_gfp(struct ma_state *mas, int count, gfp_t gfp)
* @mas: The maple state
* @count: The number of nodes needed
*
- * Note: Uses GFP_NOWAIT | __GFP_NOWARN for gfp flags.
+ * Note: Uses GFP_NOWAIT for gfp flags.
*/
static void mas_node_count(struct ma_state *mas, int count)
{
- return mas_node_count_gfp(mas, count, GFP_NOWAIT | __GFP_NOWARN);
+ return mas_node_count_gfp(mas, count, GFP_NOWAIT);
}
/*
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] maple_tree: Remove redundant __GFP_NOWARN
2025-08-04 12:56 [PATCH] maple_tree: Remove redundant __GFP_NOWARN Qianfeng Rong
@ 2025-08-04 14:49 ` Wei Yang
2025-08-06 14:16 ` Liam R. Howlett
1 sibling, 0 replies; 3+ messages in thread
From: Wei Yang @ 2025-08-04 14:49 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Andrew Morton, Liam R. Howlett, linux-kernel, maple-tree,
linux-mm, willy
On Mon, Aug 04, 2025 at 08:56:57PM +0800, Qianfeng Rong wrote:
>Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
>made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
>Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
>(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
>up these redundant flags across subsystems.
>
>No functional changes.
>
>Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
LGTM.
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] maple_tree: Remove redundant __GFP_NOWARN
2025-08-04 12:56 [PATCH] maple_tree: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-04 14:49 ` Wei Yang
@ 2025-08-06 14:16 ` Liam R. Howlett
1 sibling, 0 replies; 3+ messages in thread
From: Liam R. Howlett @ 2025-08-06 14:16 UTC (permalink / raw)
To: Qianfeng Rong; +Cc: Andrew Morton, linux-kernel, maple-tree, linux-mm, willy
* Qianfeng Rong <rongqianfeng@vivo.com> [250804 08:57]:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
>
> No functional changes.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> lib/maple_tree.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b4ee2d29d7a9..38fb68c08291 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1344,11 +1344,11 @@ static void mas_node_count_gfp(struct ma_state *mas, int count, gfp_t gfp)
> * @mas: The maple state
> * @count: The number of nodes needed
> *
> - * Note: Uses GFP_NOWAIT | __GFP_NOWARN for gfp flags.
> + * Note: Uses GFP_NOWAIT for gfp flags.
> */
> static void mas_node_count(struct ma_state *mas, int count)
> {
> - return mas_node_count_gfp(mas, count, GFP_NOWAIT | __GFP_NOWARN);
> + return mas_node_count_gfp(mas, count, GFP_NOWAIT);
> }
>
> /*
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-06 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-04 12:56 [PATCH] maple_tree: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-04 14:49 ` Wei Yang
2025-08-06 14:16 ` Liam R. Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox