From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Qianfeng Rong <rongqianfeng@vivo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org,
linux-mm@kvack.org, willy@infradead.org
Subject: Re: [PATCH] maple_tree: Remove redundant __GFP_NOWARN
Date: Wed, 6 Aug 2025 10:16:13 -0400 [thread overview]
Message-ID: <ovpvaeadvegfuhzl7a3ttnmwok7qwn5rs5o3ohwww3byfqdbkm@jky5zrvvj7lb> (raw)
In-Reply-To: <20250804125657.482109-1-rongqianfeng@vivo.com>
* Qianfeng Rong <rongqianfeng@vivo.com> [250804 08:57]:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
>
> No functional changes.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> lib/maple_tree.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b4ee2d29d7a9..38fb68c08291 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -1344,11 +1344,11 @@ static void mas_node_count_gfp(struct ma_state *mas, int count, gfp_t gfp)
> * @mas: The maple state
> * @count: The number of nodes needed
> *
> - * Note: Uses GFP_NOWAIT | __GFP_NOWARN for gfp flags.
> + * Note: Uses GFP_NOWAIT for gfp flags.
> */
> static void mas_node_count(struct ma_state *mas, int count)
> {
> - return mas_node_count_gfp(mas, count, GFP_NOWAIT | __GFP_NOWARN);
> + return mas_node_count_gfp(mas, count, GFP_NOWAIT);
> }
>
> /*
> --
> 2.34.1
>
prev parent reply other threads:[~2025-08-06 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 12:56 Qianfeng Rong
2025-08-04 14:49 ` Wei Yang
2025-08-06 14:16 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ovpvaeadvegfuhzl7a3ttnmwok7qwn5rs5o3ohwww3byfqdbkm@jky5zrvvj7lb \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=rongqianfeng@vivo.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox