From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF25C02181 for ; Fri, 24 Jan 2025 11:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F13F28005D; Fri, 24 Jan 2025 06:03:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67999280059; Fri, 24 Jan 2025 06:03:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51AB428005D; Fri, 24 Jan 2025 06:03:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3149C280059 for ; Fri, 24 Jan 2025 06:03:27 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AE16D1210DA for ; Fri, 24 Jan 2025 11:03:26 +0000 (UTC) X-FDA: 83042059212.27.49557DB Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf16.hostedemail.com (Postfix) with ESMTP id B264918001D for ; Fri, 24 Jan 2025 11:03:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BU6iPRS3; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737716604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eYrh6bf6R4rO6hBmLU/8hAQUGHYtsKKXgezZcXZ/w8U=; b=m2z/z7o7KZmHBR7nhoCYgtxpC9XeAOorTg9ZzlKI+BtC34kxXXyMqdNlcUzNJaQMq0Y0Cg M8mBm7r3iZ6mDp/6TIdIYBpmVmqxeBBI4d4klTjb8At9qUUNVQZo6UxWRaHhLz+/biexwN eJKRvh6EJi7I7a0FkrQanZNhMMjQqYo= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BU6iPRS3; spf=pass (imf16.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737716604; a=rsa-sha256; cv=none; b=ZEwLfEBb7yAXwaaVBgdAMy69aW8p3bS2FJeVyQ6OY/RJvDUjzOhCenITZvDeCZFOjEHtwy EU+PjD5aneEXOh4lC5G7ZDP75y+7fddaoGrOBTBw7NXwAaqjKrmfE4AzHRkZ9C37cDWBfv KPrAe7sGP3LVIlLAQD1egSqCD6pBVXc= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21654fdd5daso33097165ad.1 for ; Fri, 24 Jan 2025 03:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737716603; x=1738321403; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eYrh6bf6R4rO6hBmLU/8hAQUGHYtsKKXgezZcXZ/w8U=; b=BU6iPRS3BXl3BNHssn6lM74U5ceHGlpYJTJ/7EG3l4GbTZsisVDTLNQNX/vofqoTI9 AGpEBQG2XI46O/Xq9t2ZzFo/7MMUJ6OaLsXD1IdNImYkt9japHXH4BeiAgZ4dBH69m8f KRtngT5ddAKVMB+jqrycMG7dYC0HJ69Oebjog= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737716603; x=1738321403; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eYrh6bf6R4rO6hBmLU/8hAQUGHYtsKKXgezZcXZ/w8U=; b=DfQXea2tU32N6aHsig2uVq1RMvdJ0xPYjbEy6xozusT0jrvhYGkARSfWoCV44FRg5U KFTz4rA7Y/x5PB+vGyL78xweDBom0ujDzIFwqOfPLECcZcSNkhnYcc+Yd66QUKjz8BfO ganrW9dhPjzn7gzNadPbpR+5WTEXA+EwBjH5BRIyW6igS1+lsLZ/kdkp7ShAEXdyWneo wdpnzFKhOGg8xmsZNvefxc5g+ciU/yDidG7w+EVaDz6sO1OtGBbuuwlfU1O31XH5WpFB oY+ENzKo/vMo+vucOe2wy/mKWPCJUN3bOpsFmcR9thj7OmigqudlraCznrPAxNwup0m4 WpIw== X-Forwarded-Encrypted: i=1; AJvYcCX3yVPNh1QNRW5B2TKpHR7G3BZJWbWzLzoPiO2Uh8t+Is9vp0Nyuf0qkdzlmtQ/dew7uq7BVEGEcg==@kvack.org X-Gm-Message-State: AOJu0YzVfb4DEfn1ZAiB9sHrovTlgQut8R6zDsTXzlASng3z6zVmbJVs Q9p83fuHacceTaILxukWOb4x/flNJudb7pygr0kkR0tBQGTdpFc1w6DC2bKsEA== X-Gm-Gg: ASbGncs3wjIy0Y44GxuPWL30J2YONoINsuDxACZGEHpsV/y/G2NkrTcYnASqus6H205 xJDwxdzMt8HO/b0//7m9xE9O/5D5m+T4EF/GVknUlediORbz4+NnAV6Aksaop8gIug7hgj23ukv k6hk3onh17mw7rUnv7b5755tCTjq1p7sf1jBiSDOmFboaz8nM4AAUPxFhj/HZlDtrsq6oSeTCnD 6/jLUBr+dB6/gZT6rvfeuCgha4RShsdwHp6xmcCVSqr+qFAzzNOFJnzHFj8KhjuRiH/a76X/L/B LSJmdrOy X-Google-Smtp-Source: AGHT+IHLLrp3zaU4pU723+SpRjqhJnBm9U72wkK66PT719ZERRvH5g+hmYNeWJ2x5+wswy3J5+WgtA== X-Received: by 2002:a17:902:ebce:b0:21c:15b3:e3a8 with SMTP id d9443c01a7336-21c355b78d9mr411051855ad.37.1737716603343; Fri, 24 Jan 2025 03:03:23 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:4989:d5bb:e88e:bb01]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da3ea3ca7sm13620055ad.72.2025.01.24.03.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2025 03:03:22 -0800 (PST) Date: Fri, 24 Jan 2025 20:03:17 +0900 From: Sergey Senozhatsky To: Hillf Danton Cc: Sergey Senozhatsky , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/7] zram: switch to non-atomic entry locking Message-ID: References: <20250122055831.3341175-2-senozhatsky@chromium.org> <20250124103009.1761-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250124103009.1761-1-hdanton@sina.com> X-Rspamd-Queue-Id: B264918001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qkz9akq1gcpfxk41momgkfikbqz1yku9 X-HE-Tag: 1737716604-712822 X-HE-Meta: U2FsdGVkX19zzStYjWpGfq7aipVydYtVLF6PFopVx+Dyb/HxNw8tugBrqpMvPc7k4zpf6uK7FpfrMbqcp8lGEyy6U6G7ELW7GhuKeDpiKtass7bL+GipDerjcP+gagyZJXgxlYPFFf9BMZZj4yBG+bq0epB9Eaaa3Nogmlf6JRUi/93fsk4p/CEdlE7jecG2I5gFjWmYcY7u1hPHsfd0SY0DorNCwPFGn9XzH923nlT98i5uFu7VPIiR37m0ZpIc4kI8tPBgExATOMIIoTMd4MP6pBdnVKQ/pfLtCyIfvKKB/gwQM2rfXIZAeKJ7XMUvDCts6e3Hgi/A23LSWFnyPKB81OXvTIrQk4Lttyjer1I80P3+C3MsadoMnyQtpkXJGemajcNYZsWCMFN+p30IDyiinMZdQobtOblfcJRFlZT1AHfDr6BrE54Bq90Vvnr/88K6oKZzuURX2z6LZged3SIXQwneoeWVWSn20y1d2OBu3wKQymuAzqtNq00nTSyPWRSmThouroQgWmSysT65t5AJkpHfNLR0E3JgDWcMHZKaFwPQWwQ7hDESM+dsvRX1ylWt0rTwsSiwmaQSu4QmDeKrqhwydD+S+qK24Y2SPXVBrdm8D7/+JP16vgpo6XegwPyBFRIhtaRaOkrlNmkrEHzXJKEW8dW1kYXAwLpsmIRDKsz9kkt3Q0JvuNQzYKR4ID3VGrBjtcYjlCAKhkt2yxfNASWUadVVus/TdibtAr++OtqNVxloqOn1kVfeLGsurkoGflLXhAi1HV+S5SrvulBt5WylrFHR2X3NHzRCL0nhbrfAEFhcp8fnvwHKh0dtCusu312wTfnaOoi7+Dd8Gh/PhPZJCJhcCSL1/apHrFxiPQqo82Yz9HfuKJ6P1yXSRYNk9DbMocyE7u9z0JMJc2Ho6467lNBhDLgVzFr505WP0VlWGJoW6y81ljP+0ax/NgRCOoKJAFN+UsN/Qfu ChiarRbw Daj+QC+SWBCKLq5Vl7nr9HK0pk2yQHzpHIfKnPMuGTcdChUWywEffSL6Id/e+BfuOfBtyNUvbTHhilHQuugdaTIexZSZ4AtVg1VeQRcSA6Vwa9oazNtLY3qvQn1fK1Grvx15yAY76jiYziATPFGjY+3AEezm7X5p9k/scr0ozuibiZGRjjZsvvVMkLmNPavBTDa2pzzKBT5uF7tgwnKG4jfly84uUc7iAAYmhEPV6WdlFWBEUeHoYhsDB9YxVFnwo7SykiCOjArZIO3MmBk37nnIqp4YJ7wjrmkb0/obRMI7T/XTu+OI5mdzaHVmTRXYcsuhVPGX3j8Yc69QgGhDhYrDxTwosTrdQz2pLZyM9UAgRD5s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.102178, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/01/24 18:30), Hillf Danton wrote: > On (25/01/22 14:57), Sergey Senozhatsky wrote: > > > > - for (index = 0; index < num_pages; index++) > > - spin_lock_init(&zram->table[index].lock); > > + for (index = 0; index < num_ents; index++) > > + init_rwsem(&zram->locks[index].lock); > > Curious if lockdep trick [1] is needed here. These bucket locks are not part of the v2 which I'm currnetly working on.