From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Hillf Danton <hdanton@sina.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Minchan Kim <minchan@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] zram: switch to non-atomic entry locking
Date: Fri, 24 Jan 2025 20:03:17 +0900 [thread overview]
Message-ID: <ougqn5g5izptxbqhh3zpcxs45cfxxeqlicv5dgmtz4d2cicpe2@sptb3vgxd7ff> (raw)
In-Reply-To: <20250124103009.1761-1-hdanton@sina.com>
On (25/01/24 18:30), Hillf Danton wrote:
> On (25/01/22 14:57), Sergey Senozhatsky wrote:
> >
> > - for (index = 0; index < num_pages; index++)
> > - spin_lock_init(&zram->table[index].lock);
> > + for (index = 0; index < num_ents; index++)
> > + init_rwsem(&zram->locks[index].lock);
>
> Curious if lockdep trick [1] is needed here.
These bucket locks are not part of the v2 which I'm currnetly
working on.
next prev parent reply other threads:[~2025-01-24 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 5:57 [PATCH 0/7] zram: preemptible writes and occasionally preemptible reads Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 1/7] zram: switch to non-atomic entry locking Sergey Senozhatsky
2025-01-24 5:06 ` Sergey Senozhatsky
2025-01-24 10:30 ` Hillf Danton
2025-01-24 11:03 ` Sergey Senozhatsky [this message]
2025-01-24 11:09 ` Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 2/7] zram: do not use per-CPU compression streams Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 3/7] zram: remove two-staged handle allocation Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 4/7] zram: permit reclaim in zstd custom allocator Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 5/7] zram: permit reclaim in recompression handle allocation Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 6/7] zram: remove writestall zram_stats member Sergey Senozhatsky
2025-01-22 5:57 ` [PATCH 7/7] zram: unlock slot bucket during recompression Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ougqn5g5izptxbqhh3zpcxs45cfxxeqlicv5dgmtz4d2cicpe2@sptb3vgxd7ff \
--to=senozhatsky@chromium.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox