From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A8DC4828F for ; Wed, 7 Feb 2024 16:41:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E574E6B0074; Wed, 7 Feb 2024 11:41:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E07546B0075; Wed, 7 Feb 2024 11:41:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCFD76B0078; Wed, 7 Feb 2024 11:41:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BBE276B0074 for ; Wed, 7 Feb 2024 11:41:12 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9C3941C17DF for ; Wed, 7 Feb 2024 16:41:12 +0000 (UTC) X-FDA: 81765572784.04.8B83661 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 7BD3F20016 for ; Wed, 7 Feb 2024 16:41:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OeyoffAt; spf=pass (imf13.hostedemail.com: domain of jsnitsel@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jsnitsel@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707324070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pLHmOri0rwabgYHmtFqkZU7UR9oorDvGKBxIT2pvDE4=; b=66wN+5GLjmLNNW0DHudnkRonDJkCwIG90Q9nKvXPwQ9NJmB2nQJijZS6Kom9t1BX9FfI/5 RUvYVHkSHPmVa66vrs2ibrNiE07raUbYnlor8hOAqi54YccE7N+qOjlh6HCtlUsZk5nLPm bhrO6GCZxCR3EHs5a3/TQFhjcLFy67c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707324070; a=rsa-sha256; cv=none; b=IQnhj5TjIo/pQdiGMidBQt54Ra90L0vEyAiIyccYtM1OXF4R1WpZimVjpbJSoQ+pFc5Uvb s9wXLhzZ+qXR5LjjQbQnup0H/pB3uZn7tIjejQUi6g2h0lQo4z67twtqKjt648JRods90b g7y6KTlQHTXcV+Qwb4FW6k7tlKRN0sc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OeyoffAt; spf=pass (imf13.hostedemail.com: domain of jsnitsel@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jsnitsel@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707324069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pLHmOri0rwabgYHmtFqkZU7UR9oorDvGKBxIT2pvDE4=; b=OeyoffAt9znlUBvPx6jjzffZp2gv/ptcpw21Hltex52Fv4Mc7rTcmf1q05e+KRe9yhs3gC lzB4M38B9Tkl7ae5UNYMDDpAQy4SUJrCbmGqTstoA6zkOOMKzbDbx/YfFvxc6Gaarp9xWT IR3d4PylOyx0LBacJu/mx5wz0FhOA/E= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-9tpWKWJmN_G2NHt6PDEkXw-1; Wed, 07 Feb 2024 11:41:08 -0500 X-MC-Unique: 9tpWKWJmN_G2NHt6PDEkXw-1 Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-7d2fda27b16so330176241.0 for ; Wed, 07 Feb 2024 08:41:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707324067; x=1707928867; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pLHmOri0rwabgYHmtFqkZU7UR9oorDvGKBxIT2pvDE4=; b=ZyqKy73scE5NLVlQMRRXFtvl/ki7ghtfnuyicdGtxi6bDVijcIlGwq0UvJFbyz3AQl QwITm+PNiMzf9jA6cPr3ZSZwXfDA/5cODD+T5pJn1VMzaMgucLF0HU+YT6ufkCzpjafG ape/RiUpE4zImCft7uuJq2l8opVjvQiPAXELlTM06czO85fOZcA0jsQJEup3GkXaq7jB wv/S25Ew5uvhk0pmJsE4JDspa2PZVub03GeLW46ksABx7gGc7Y2jxHEwIRj52PDwFgOu tGZK4GleKS02L5axNuMRb4ezGE8YrgfnvqYvfgvkqHvTgMcY3cG9SHlzjfwXW2rF6QjX D/Tg== X-Gm-Message-State: AOJu0YwZAFDgR1a1Obi90Y654NWi8G90ccnD5gYE4+VrhhxqXlmnS9vb P209Ja7j+njIXyHCg7E5NSsIhoSNdSQXhGxjhGF/2vhiJ1uQhpL2XEmK2nk8rWDZqXXXqsSEYRu LTQILSOuRwBRNZ06ES2xgFI9eN9UCbrGTWTGH/4Q/FU/cFhW+ X-Received: by 2002:a05:6102:4423:b0:46d:2719:7a8d with SMTP id df35-20020a056102442300b0046d27197a8dmr3213008vsb.6.1707324067565; Wed, 07 Feb 2024 08:41:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGI7L8pil6iYGjgA+wbXsRO5bpLfCdQiwFjFbu6u3Xk4AfE+eFX5x0ob1pS5dKI4b5MoLT5EQ== X-Received: by 2002:a05:6102:4423:b0:46d:2719:7a8d with SMTP id df35-20020a056102442300b0046d27197a8dmr3212990vsb.6.1707324067181; Wed, 07 Feb 2024 08:41:07 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCU4YpG9ByTiv189vcqpCJjfwcaVnc97uYfbTiy23VL7e+NLa8gM9pBl6B7kahhJlhqPHbEWl1XrMx1P6vyzoGOLmOjIwXlHMo0TjnydXq4DVhDrEtKwKzTMw6Sgw7f3lqOVbokB9BkbKPkhIIg0AXeDiKMIl3K7BVl6U01MzR9wcqhOUR8vItXu26DH+pDjjT/X2LSNjgf7atpGli3k8+2OZNR5+Swewic0KcHarXUWGvcqf+weW1kCNMMwndWRbvMKAF/79tUpApSiN7K4JKYba49PH8dCPLyO8L4ZE0jabc3kc4HpsQ+C Received: from localhost (ip70-163-216-141.ph.ph.cox.net. [70.163.216.141]) by smtp.gmail.com with ESMTPSA id mf7-20020a0562145d8700b006852ff71ac2sm738818qvb.30.2024.02.07.08.41.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 08:41:06 -0800 (PST) Date: Wed, 7 Feb 2024 09:41:05 -0700 From: Jerry Snitselaar To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, pasha.tatashin@soleen.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, yosryahmed@google.com, john.g.garry@oracle.com Subject: Re: [PATCH v3 2/3] iommu/iova: Reorganise some code Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: 7BD3F20016 X-Rspam-User: X-Stat-Signature: azysj73txfmuuubwf34k3tcmpq3as1un X-Rspamd-Server: rspam03 X-HE-Tag: 1707324070-513437 X-HE-Meta: U2FsdGVkX18gZ3t0mk6RNvpmR1aFREobYEuH/YFS35srmNnNvxmu27QrXDNZOdEVR5922yCMEHv8H7HynCfPYmJWggsbL/KXpOnokJKAxJftg6VZPhXEql0qkxo7WtFOws9qHgC3MWx2s/EyYxMkvbY29uJreE8RyBCsPmYAUVuhvADEecFQ/aqrFIhAFqEYDkR/J2Yu+TQgNGQMsJbseFsBs+p7TflwkUzwozWrwRs7+2hWvCecQEtQ/+KTuk2T3udBKbg7gGnB6WQWE8+Wknwc95ateoWlUb0wp2lQnYEKE2it5IBs3es6IvkkOkAL+wxIShgO7AN2bdIxr1Y0LbgI4jcGyOQJFgaBVMZt7llEs2t2vpKDnEN3k1gunf6kdQ4ID98UfrowBphyT1wKRGZKeESuuERLnRutPYNUIfqy/qHEepNKdADPAQd5NOmh6pLe1DrLlRC/cjV2aQvKL+GC1WlD9BjmughVv6s7ZwEksBOpiWdG5WxQh4OFm+8YLreLWZHEPPT8UFqpwGqVxEYgKw36XKY0Fjzb5nrflRFuvHlKnSSJbVNPquXoJu5Kdz72UziaPcKMc1MSaAQhOIIK3ahMakCS9cD0zt4R26DML6yXxBh+xsUDA1yN/zlCftHaDNNIbrfZxtRIW5OJo3XYanAnagUB99HbptzEASEZ65yYavzisiv9F3beJk7Rbry/d77PqZv/e5Tm37fkMYFyb1i2tfBMtXN8Z4DZklULbD0/dFSDkjL4h050+6U/ibgKnEHso5iLzHvDMkUGHbLbLvok4EEo3cajqSX5w66s/QKAuvU5bA3dU9hYG6akRplxMBAcTF2TVsdVoG9Tg9eXcWRpYRaGBSwD0y6rSKoO5jOt+7D7dsNpGg0CtpxaohsNjrSwz7e5Rd8vRo3dmD1utwfGu4g+l+bXm+44WTeENbYOYzsJBbJQX3tgWM42Ns0HChxetPiXC8K4DFV dm7pGHbX SN/3u11KA+QFKZk4skUH411MRtU4DhsCCzFpWvXwx7+rWERw4yCkILj6ob+elhZtseWSMYEQtWXX7FxglOnOV1Khj9olaUj087w3xllkzLSi6dEeBzPqEkrI4tEq8eu4eK687dvHjoyQpfnb7xP78ZwemS7Au51hEMAZKVFw9AAps0Gy1buJEg86WXmOftSAGQyHjHbSZLgNhHbrIvy/LNltt1H1jRy/Jv0exQiwlNtiBsDjVjtySckN561SksXDAnDZRFniz/q+S6ZGRUTISGubZm3hELmbFx/Y0JBprUDy8aUF5Vspp11r/LE26zHtNNkD5bD1rIMYRPMmXGaG2q0bcX98Y72FrNWSA1Ki9FbED9yM6yUpN4ds9VqAjc2oUFFZZDfcZAdyEAKtCfXwz+vjNbogW+TaUllweL0oK91DeRaeJLKYFa4GGr6fYdplvFNeL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 03:32:40PM +0000, Robin Murphy wrote: > The iova_cache_{get,put}() calls really represent top-level lifecycle > management for the whole IOVA library, so it's long been rather > confusing to have them buried right in the middle of the allocator > implementation details. Move them to a more expected position at the end > of the file, where it will then also be easier to expand them. With > this, we can also move the rcache hotplug handler (plus another stray > function) into the rcache portion of the file. > > Signed-off-by: Robin Murphy > --- > drivers/iommu/iova.c | 128 +++++++++++++++++++++---------------------- > 1 file changed, 64 insertions(+), 64 deletions(-) > Reviewed-by: Jerry Snitselaar