From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id F34D46B0022 for ; Mon, 16 May 2011 19:11:50 -0400 (EDT) Received: by pzk4 with SMTP id 4so3266734pzk.14 for ; Mon, 16 May 2011 16:11:49 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references References: <1305580757-13175-1-git-send-email-john.stultz@linaro.org> <1305580757-13175-4-git-send-email-john.stultz@linaro.org> <1305587090.2503.42.camel@Joe-Laptop> Date: Tue, 17 May 2011 01:11:45 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Message-ID: In-Reply-To: <1305587090.2503.42.camel@Joe-Laptop> Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes , Andy Whitcroft , Joe Perches Cc: LKML , John Stultz , Ted Ts'o , Jiri Slaby , KOSAKI Motohiro , Dave Hansen , Andrew Morton , linux-mm@kvack.org On Tue, 17 May 2011 01:04:50 +0200, Joe Perches wrote: > On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote: >> On Mon, 16 May 2011, Michal Nazarewicz wrote: >> > > Now that accessing current->comm needs to be protected, >> > > +# check for current->comm usage >> > > + if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) { >> > Not a checkpatch.pl expert but as far as I'm concerned, that looks >> reasonable. > > I think the only checkpatch expert is Andy Whitcroft. > > You don't need (?: just ( Yep, it's a micro-optimisation though. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org