From: "Michal Nazarewicz" <mina86@mina86.com>
To: ext Andrea Arcangeli <aarcange@redhat.com>,
Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: akpm@linux-foundation.org, cl@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] mm: make read-only accessors take const pointer parameters
Date: Fri, 15 Apr 2011 18:12:33 +0200 [thread overview]
Message-ID: <op.vtzly7dk3l0zgt@mnazarewicz-glaptop> (raw)
In-Reply-To: <20110415155916.GD7112@esdhcp04044.research.nokia.com>
On Fri, 15 Apr 2011 17:59:16 +0200, Phil Carmody wrote:
> I'm just glad this wasn't an insta-nack, as I am quite a fan of
> consts, and hopefully something can be worked out.
I feel you man. Unfortunately, I think that const, since it's an
after-thought, is not very usable in C.
For instance, as you've pointed in your patch, the "_ro" suffix
is sort of dumb, but without it compound_head would have to take
const and return non-const (like strchr() does) which is kinda
stupid as well.
What's more, because of lack of encapsulation, “const struct page”
only means that the object is const but thighs it points to aren't.
As such, const does not really play that well with structs anyway.
const is, in my opinion, one of those things C++ actually got
right (or close to right).
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@google.com>-----ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-04-15 16:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 9:56 Phil Carmody
2011-04-15 9:56 ` [PATCH] mm: make read-only accessors take const parameters Phil Carmody
2011-04-15 14:51 ` Christoph Lameter
2011-04-15 16:07 ` Phil Carmody
2011-04-20 11:45 ` Artem Bityutskiy
2011-04-16 23:48 ` David Rientjes
2011-04-15 14:51 ` [PATCH 0/1] mm: make read-only accessors take const pointer parameters Andrea Arcangeli
2011-04-15 15:59 ` Phil Carmody
2011-04-15 16:09 ` Andrea Arcangeli
2011-04-20 9:28 ` Artem Bityutskiy
2011-04-20 11:20 ` Michal Nazarewicz
2011-04-20 11:44 ` Artem Bityutskiy
2011-04-15 16:12 ` Michal Nazarewicz [this message]
2011-04-15 16:28 ` Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.vtzly7dk3l0zgt@mnazarewicz-glaptop \
--to=mina86@mina86.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox