From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id E90298D0040 for ; Thu, 31 Mar 2011 18:18:18 -0400 (EDT) Received: by ewy9 with SMTP id 9so1160874ewy.14 for ; Thu, 31 Mar 2011 15:18:12 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added References: <1301577368-16095-1-git-send-email-m.szyprowski@samsung.com> <1301577368-16095-5-git-send-email-m.szyprowski@samsung.com> <1301587083.31087.1032.camel@nimitz> <1301606078.31087.1275.camel@nimitz> Date: Fri, 01 Apr 2011 00:18:10 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Message-ID: In-Reply-To: <1301606078.31087.1275.camel@nimitz> Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, Kyungmin Park , Andrew Morton , KAMEZAWA Hiroyuki , Ankita Garg , Daniel Walker , Johan MOSSBERG , Mel Gorman , Pawel Osciak > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: >> +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned >> long end, >> + gfp_t flag) >> +{ >> + unsigned long pfn = start, count; >> + struct page *page; >> + struct zone *zone; >> + int order; >> + >> + VM_BUG_ON(!pfn_valid(start)); On Thu, 31 Mar 2011 23:14:38 +0200, Dave Hansen wrote: > We BUG_ON() in bootmem. Basically if we try to allocate an early-boot > structure and fail, we're screwed. We can't keep running without an > inode hash, or a mem_map[]. > > This looks like it's going to at least get partially used in drivers, at > least from the examples. Are these kinds of things that, if the driver > fails to load, that the system is useless and hosed? Or, is it > something where we might limp along to figure out what went wrong before > we reboot? Bug in the above place does not mean that we could not allocate memory. It means caller is broken. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org