From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 826B28D0040 for ; Thu, 31 Mar 2011 12:26:53 -0400 (EDT) Received: by eyd9 with SMTP id 9so1035592eyd.14 for ; Thu, 31 Mar 2011 09:26:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes References: <1301577368-16095-1-git-send-email-m.szyprowski@samsung.com> <1301577368-16095-6-git-send-email-m.szyprowski@samsung.com> <1301587361.31087.1040.camel@nimitz> Subject: Re: [PATCH 05/12] mm: alloc_contig_range() added Date: Thu, 31 Mar 2011 18:26:45 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Message-ID: In-Reply-To: <1301587361.31087.1040.camel@nimitz> Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski , Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, Kyungmin Park , Andrew Morton , KAMEZAWA Hiroyuki , Ankita Garg , Daniel Walker , Johan MOSSBERG , Mel Gorman , Pawel Osciak > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: >> + ret = 0; >> + while (!PageBuddy(pfn_to_page(start & (~0UL << ret)))) >> + if (WARN_ON(++ret >= MAX_ORDER)) >> + return -EINVAL; On Thu, 31 Mar 2011 18:02:41 +0200, Dave Hansen wrote: > Holy cow, that's dense. Is there really no more straightforward way to > do that? Which part exactly is dense? What would be qualify as a more straightforward way? > In any case, please pull the ++ret bit out of the WARN_ON(). Some > people like to do: > > #define WARN_ON(...) do{}while(0) > > to save space on some systems. I don't think that's the case. Even if WARN_ON() decides not to print a warning, it will still return the value of the argument. If not, a lot of code will brake. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org