From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 01F7E8D0040 for ; Thu, 31 Mar 2011 17:09:47 -0400 (EDT) Received: by ewy9 with SMTP id 9so1141370ewy.14 for ; Thu, 31 Mar 2011 14:09:44 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 04/12] mm: alloc_contig_freed_pages() added References: <1301577368-16095-1-git-send-email-m.szyprowski@samsung.com> <1301577368-16095-5-git-send-email-m.szyprowski@samsung.com> <1301587083.31087.1032.camel@nimitz> Date: Thu, 31 Mar 2011 23:09:42 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Michal Nazarewicz" Message-ID: In-Reply-To: <1301587083.31087.1032.camel@nimitz> Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski , Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-mm@kvack.org, Kyungmin Park , Andrew Morton , KAMEZAWA Hiroyuki , Ankita Garg , Daniel Walker , Johan MOSSBERG , Mel Gorman , Pawel Osciak On Thu, 31 Mar 2011 17:58:03 +0200, Dave Hansen wrote: > On Thu, 2011-03-31 at 15:16 +0200, Marek Szyprowski wrote: >> >> +unsigned long alloc_contig_freed_pages(unsigned long start, unsigned >> long end, >> + gfp_t flag) >> +{ >> + unsigned long pfn = start, count; >> + struct page *page; >> + struct zone *zone; >> + int order; >> + >> + VM_BUG_ON(!pfn_valid(start)); > > This seems kinda mean. Could we return an error? I understand that > this is largely going to be an early-boot thing, but surely trying to > punt on crappy input beats a full-on BUG(). Actually, I would have to check but I think that the usage of this function (in this patchset) is that the caller expects the function to succeed. It is quite a low-level function so before running it a lot of preparation is needed and the caller must make sure that several conditions are met. I don't really see advantage of returning a value rather then BUG()ing. Also, CMA does not call this function at boot time. -- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michal "mina86" Nazarewicz (o o) ooo +----------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org