From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 951836B02A4 for ; Wed, 28 Jul 2010 04:51:56 -0400 (EDT) Received: from eu_spt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0L6900E0OFACOJ@mailout1.w1.samsung.com> for linux-mm@kvack.org; Wed, 28 Jul 2010 09:51:48 +0100 (BST) Received: from linux.samsung.com ([106.116.38.10]) by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L6900B7BFABFQ@spt1.w1.samsung.com> for linux-mm@kvack.org; Wed, 28 Jul 2010 09:51:48 +0100 (BST) Date: Wed, 28 Jul 2010 10:53:17 +0200 From: =?utf-8?B?TWljaGHFgiBOYXphcmV3aWN6?= Subject: Re: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added In-reply-to: <20100727120841.GC11468@n2100.arm.linux.org.uk> Message-id: MIME-version: 1.0 Content-type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-transfer-encoding: Quoted-Printable References: <743102607e2c5fb20e3c0676fadbcb93d501a78e.1280151963.git.m.nazarewicz@samsung.com> <20100727120841.GC11468@n2100.arm.linux.org.uk> Sender: owner-linux-mm@kvack.org To: Russell King - ARM Linux Cc: Daniel Walker , Jonathan Corbet , Pawel Osciak , Mark Brown , linux-kernel@vger.kernel.org, Hiremath Vaibhav , FUJITA Tomonori , linux-mm@kvack.org, Kyungmin Park , Zach Pfeffer , Marek Szyprowski , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-ID: >> +static inline dma_addr_t __must_check >> +cma_alloc(const struct device *dev, const char *kind, >> + size_t size, dma_addr_t alignment) >> +{ >> + return dev ? -EINVAL : __cma_alloc(dev, kind, size, alignment); On Tue, 27 Jul 2010 14:08:41 +0200, Russell King - ARM Linux wrote: > So I can't use this to allocate memory for anything but a NULL device?= >> +static inline int >> +cma_info(struct cma_info *info, const struct device *dev, const char= *kind) >> +{ >> + return dev ? -EINVAL : __cma_info(info, dev, kind); > This won't return information for anything but a NULL device? Obviously a bug. Thanks for spotting that. -- = Best regards, _ _ | Humble Liege of Serenely Enlightened Majesty of o' \,=3D./ `o | Computer Science, Micha=C5=82 "mina86" Nazarewicz (o o) +----[mina86*mina86.com]---[mina86*jabber.org]----ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org