From: "Michal Nazarewicz" <mina86@mina86.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Robert Nelson <robertcnelson@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linaro-mm-sig@lists.linaro.org, Ohad Ben-Cohen <ohad@wizery.com>,
Daniel Walker <dwalker@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
Mel Gorman <mel@csn.ul.ie>, Dave Hansen <dave@linux.vnet.ibm.com>,
Jesse Barker <jesse.barker@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rob Clark <rob.clark@linaro.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [Linaro-mm-sig] [PATCHv21 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks
Date: Mon, 13 Feb 2012 11:38:22 -0800 [thread overview]
Message-ID: <op.v9mt58ch3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <CAOCHtYi01NVp1j=MX+0-z7ygW5tJuoswn8eWTQp+0Z5mMGdeQw@mail.gmail.com>
> On Fri, Feb 10, 2012 at 11:32 AM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> @@ -5637,6 +5642,56 @@ static int __alloc_contig_migrate_range(unsigned long start, unsigned long end)
>> return ret > 0 ? 0 : ret;
>> }
>>
>> +/*
>> + * Update zone's cma pages counter used for watermark level calculation.
>> + */
>> +static inline void __update_cma_wmark_pages(struct zone *zone, int count)
>> +{
>> + unsigned long flags;
>> + spin_lock_irqsave(&zone->lock, flags);
>> + zone->min_cma_pages += count;
>> + spin_unlock_irqrestore(&zone->lock, flags);
>> + setup_per_zone_wmarks();
>> +}
>> +
>> +/*
>> + * Trigger memory pressure bump to reclaim some pages in order to be able to
>> + * allocate 'count' pages in single page units. Does similar work as
>> + *__alloc_pages_slowpath() function.
>> + */
>> +static int __reclaim_pages(struct zone *zone, gfp_t gfp_mask, int count)
>> +{
>> + enum zone_type high_zoneidx = gfp_zone(gfp_mask);
>> + struct zonelist *zonelist = node_zonelist(0, gfp_mask);
>> + int did_some_progress = 0;
>> + int order = 1;
>> + unsigned long watermark;
>> +
>> + /*
>> + * Increase level of watermarks to force kswapd do his job
>> + * to stabilise at new watermark level.
>> + */
>> + __modify_min_cma_pages(zone, count);
On Mon, 13 Feb 2012 10:57:58 -0800, Robert Nelson <robertcnelson@gmail.com> wrote:
> Hi Marek, This ^^^ function doesn't seem to exist in this patchset,
> is it in another set posted to lkml?
This should read __update_cma_wmark_pages(). Sorry for the incorrect patch.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-13 19:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 17:32 [PATCHv21 00/16] Contiguous Memory Allocator Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 01/16] mm: page_alloc: remove trailing whitespace Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 02/16] mm: compaction: introduce isolate_migratepages_range() Marek Szyprowski
2012-02-14 7:19 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 03/16] mm: compaction: introduce map_pages() Marek Szyprowski
2012-02-14 7:25 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 04/16] mm: compaction: introduce isolate_freepages_range() Marek Szyprowski
2012-02-14 7:30 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 05/16] mm: compaction: export some of the functions Marek Szyprowski
2012-02-14 7:47 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 06/16] mm: page_alloc: introduce alloc_contig_range() Marek Szyprowski
2012-02-14 7:54 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 07/16] mm: page_alloc: change fallbacks array handling Marek Szyprowski
2012-02-14 7:56 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 08/16] mm: mmzone: MIGRATE_CMA migration type added Marek Szyprowski
2012-02-14 8:29 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 09/16] mm: page_isolation: MIGRATE_CMA isolation functions added Marek Szyprowski
2012-02-14 8:31 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 10/16] mm: Serialize access to min_free_kbytes Marek Szyprowski
2012-02-14 8:38 ` KAMEZAWA Hiroyuki
2012-02-10 17:32 ` [PATCHv21 11/16] mm: extract reclaim code from __alloc_pages_direct_reclaim() Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 12/16] mm: trigger page reclaim in alloc_contig_range() to stabilise watermarks Marek Szyprowski
2012-02-13 18:57 ` [Linaro-mm-sig] " Robert Nelson
2012-02-13 19:38 ` Michal Nazarewicz [this message]
2012-02-13 21:15 ` Robert Nelson
2012-02-13 21:33 ` Michal Nazarewicz
2012-02-13 21:37 ` Robert Nelson
2012-02-10 17:32 ` [PATCHv21 13/16] drivers: add Contiguous Memory Allocator Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 14/16] X86: integrate CMA with DMA-mapping subsystem Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 15/16] ARM: " Marek Szyprowski
2012-02-10 17:32 ` [PATCHv21 16/16] ARM: Samsung: use CMA for 2 memory banks for s5p-mfc device Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v9mt58ch3l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dave@linux.vnet.ibm.com \
--cc=dwalker@codeaurora.org \
--cc=jesse.barker@linaro.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kyungmin.park@samsung.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mel@csn.ul.ie \
--cc=ohad@wizery.com \
--cc=rob.clark@linaro.org \
--cc=robertcnelson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox