From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id 516F66B002C for ; Sun, 5 Feb 2012 09:37:15 -0500 (EST) Received: by eaag11 with SMTP id g11so2432393eaa.14 for ; Sun, 05 Feb 2012 06:37:13 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH 08/15] mm: mmzone: MIGRATE_CMA migration type added References: <1328271538-14502-1-git-send-email-m.szyprowski@samsung.com> <1328271538-14502-9-git-send-email-m.szyprowski@samsung.com> Date: Sun, 05 Feb 2012 15:37:07 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Michal Nazarewicz" Message-ID: In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, Kyungmin Park , Russell King , Andrew Morton , KAMEZAWA Hiroyuki >>>> +static inline bool migrate_async_suitable(int migratetype) >> On Fri, 03 Feb 2012 15:19:54 +0100, Hillf Danton w= rote: >>> Just nitpick, since the helper is not directly related to what async= >>> means, how about migrate_suitable(int migrate_type) ? > 2012/2/3 Michal Nazarewicz : >> I feel current name is better suited since it says that it's OK to sc= an this >> block if it's an asynchronous compaction run. On Sat, 04 Feb 2012 10:09:02 +0100, Hillf Danton wrot= e: > The input is the migrate type of page considered, and the async is onl= y one > of the modes that compaction should be carried out. Plus the helper is= > also used in other cases where async is entirely not concerned. > > That said, the naming is not clear, if not misleading. In the first version the function was called is_migrate_cma_or_movable()= which described what the function checked. Mel did not like it though, hence = the change to migrate_async_suitable(). Honestly, I'm not sure what would b= e the best name for function. -- = Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz= (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org