From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx193.postini.com [74.125.245.193]) by kanga.kvack.org (Postfix) with SMTP id 87DF06B005A for ; Tue, 10 Jan 2012 07:49:01 -0500 (EST) Received: by eeke53 with SMTP id e53so238415eek.14 for ; Tue, 10 Jan 2012 04:48:59 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH v6 7/8] mm: only IPI CPUs to drain local pages if they exist References: <1326040026-7285-8-git-send-email-gilad@benyossef.com> Date: Tue, 10 Jan 2012 13:48:56 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Michal Nazarewicz" Message-ID: In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Gilad Ben-Yossef Cc: Christoph Lameter , linux-kernel@vger.kernel.org, Chris Metcalf , Peter Zijlstra , Frederic Weisbecker , Russell King , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Sasha Levin , Rik van Riel , Andi Kleen , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, Avi Kivity > 2012/1/9 Michal Nazarewicz : >> This is initialised in setup_per_cpu_pageset() so it needs to be file= >> scoped. On Tue, 10 Jan 2012 13:43:21 +0100, Gilad Ben-Yossef wrote: > Yes. The cpumask_var_t abstraction is convenient and all but it does > make the allocation very non obvious when it does not happen in > proximity to the variable use - it doesn't *look* like a pointer. You can say that about any file scoped variable that needs non-const initialisation, not only pointers. -- = Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz= (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org