From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx127.postini.com [74.125.245.127]) by kanga.kvack.org (Postfix) with SMTP id D1A366B0062 for ; Tue, 3 Jan 2012 03:57:57 -0500 (EST) Received: by eekc41 with SMTP id c41so18036734eek.14 for ; Tue, 03 Jan 2012 00:57:56 -0800 (PST) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Subject: Re: [PATCH v5 1/8] smp: Introduce a generic on_each_cpu_mask function References: <1325499859-2262-1-git-send-email-gilad@benyossef.com> <1325499859-2262-2-git-send-email-gilad@benyossef.com> Date: Tue, 03 Jan 2012 09:57:35 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Michal Nazarewicz" Message-ID: In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Gilad Ben-Yossef Cc: linux-kernel@vger.kernel.org, Chris Metcalf , Peter Zijlstra , Frederic Weisbecker , Russell King , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Rik van Riel , Andi Kleen , Sasha Levin , Mel Gorman , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, Avi Kivity > 2012/1/3 Michal Nazarewicz : >> on_each_cpu() returns an int. For consistency reasons, would it make= sense >> to make on_each_cpu_maks() to return and int? I know that the differ= ence >> is that smp_call_function() returns and int and smp_call_function_man= y() >> returns void, but to me it actually seems strange and either I'm miss= ing >> something important (which is likely) or this needs to get cleaned up= at >> one point as well. On Tue, 03 Jan 2012 09:12:21 +0100, Gilad Ben-Yossef wrote: > I'd say we should go the other way around - kill the return value on > on_each_cpu() > > The return value is always a hard coded zero and we have some code tha= t tests > for that return value. Silly... > > It looks like it's there for hysterical reasons to me :-) That might be right. Of course, this goes deeper then on_each_cpu() sin= ce some of the smp_call_function functions have an int return value, but I couldn't find an instance when they return non-zero. I'd offer to volunteer to do the clean-up but I have too little experien= ce in IPI to say with confidence that we in fact can and want to drop the =E2= =80=9Cint=E2=80=9D return value from all of those functions. -- = Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz= (o o) ooo +------------------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org