From: "Michal Nazarewicz" <mina86@mina86.com>
To: Joe Perches <joe@perches.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmalloc: remove #ifdef in function body
Date: Wed, 21 Dec 2011 07:47:17 +0100 [thread overview]
Message-ID: <op.v6tug3vi3l0zgt@mpn-glaptop> (raw)
In-Reply-To: <1324449156.21735.7.camel@joe2Laptop>
On Wed, 21 Dec 2011 07:32:36 +0100, Joe Perches <joe@perches.com> wrote:
> On Wed, 2011-12-21 at 07:21 +0100, Michal Nazarewicz wrote:
>> it seems the community prefers
>> having ifdefs outside of the function.
>
> Some do, some don't.
>
> http://comments.gmane.org/gmane.linux.network/214543
This patch that you pointed to is against “#ifdefs are ugly” style
described in Documentation/SubmittingPatches.
> If it's not in coding style, I suggest
> it should be changed if it doesn't
> add some other useful value.
That my be true. I guess no one took time to adding it to the document.
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-21 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 5:17 Minchan Kim
2011-12-21 5:31 ` Joe Perches
2011-12-21 5:45 ` Minchan Kim
2011-12-21 5:58 ` Joe Perches
2011-12-21 6:07 ` Minchan Kim
2011-12-21 6:27 ` Joe Perches
2011-12-21 6:21 ` Michal Nazarewicz
2011-12-21 6:32 ` Joe Perches
2011-12-21 6:47 ` Michal Nazarewicz [this message]
2011-12-21 15:21 ` Ted Ts'o
2011-12-21 6:13 ` Michal Nazarewicz
2011-12-21 6:22 ` Minchan Kim
2011-12-21 6:24 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.v6tug3vi3l0zgt@mpn-glaptop \
--to=mina86@mina86.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox